-
Notifications
You must be signed in to change notification settings - Fork 694
Import changefeed's configuration from s3 #13943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import changefeed's configuration from s3 #13943
Conversation
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
cd96ff4
to
cb9b9bd
Compare
cb9b9bd
to
078c578
Compare
✅ Documentation buildRevision built successfully |
⚪ |
⚪ |
⚪ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тесты можно поправить отдельно.
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
⚪ |
if (path->PathState != NKikimrSchemeOp::EPathStateAlter) { | ||
return InvalidTxId; | ||
} | ||
|
||
return path->LastTxId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выглядит не очень надежно, между схемными транзакциями импорта же могут влезть другие схемные операции.
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK LGTM
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
Changelog entry
...
Changelog category
Additional information
...