Skip to content

Import changefeed's configuration from s3 #13943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stanislav-shchetinin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@stanislav-shchetinin stanislav-shchetinin self-assigned this Jan 29, 2025
@stanislav-shchetinin stanislav-shchetinin changed the title Import changefeed's configuration to s3 Import changefeed's configuration from s3 Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 07:14:33 UTC Pre-commit check linux-x86_64-release-asan for f496bda has started.
2025-01-29 07:15:03 UTC Artifacts will be uploaded here
2025-01-29 07:18:15 UTC ya make is running...
🔴 2025-01-29 07:22:10 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 07:15:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for f496bda has started.
2025-01-29 07:15:59 UTC Artifacts will be uploaded here
2025-01-29 07:19:27 UTC ya make is running...
🔴 2025-01-29 07:22:52 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 09:40:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 910068d has started.
2025-01-30 09:40:46 UTC Artifacts will be uploaded here
2025-01-30 09:43:49 UTC ya make is running...
🔴 2025-01-30 09:57:31 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 09:40:55 UTC Pre-commit check linux-x86_64-release-asan for 910068d has started.
2025-01-30 09:41:07 UTC Artifacts will be uploaded here
2025-01-30 09:44:25 UTC ya make is running...
🔴 2025-01-30 09:49:30 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 10:44:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for f4e5260 has started.
2025-01-30 10:45:09 UTC Artifacts will be uploaded here
2025-01-30 10:48:26 UTC ya make is running...
2025-01-30 10:49:43 UTC Check cancelled

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 10:55:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for b84b276 has started.
2025-01-30 10:55:20 UTC Artifacts will be uploaded here
2025-01-30 10:58:37 UTC ya make is running...
🔴 2025-01-30 11:02:44 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 10:55:08 UTC Pre-commit check linux-x86_64-release-asan for b84b276 has started.
2025-01-30 10:55:19 UTC Artifacts will be uploaded here
2025-01-30 10:58:36 UTC ya make is running...
🔴 2025-01-30 11:07:31 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 11:55:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for a642ab4 has started.
2025-01-30 11:55:24 UTC Artifacts will be uploaded here
2025-01-30 11:58:41 UTC ya make is running...
🔴 2025-01-30 12:03:31 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 11:56:07 UTC Pre-commit check linux-x86_64-release-asan for a642ab4 has started.
2025-01-30 11:56:19 UTC Artifacts will be uploaded here
2025-01-30 11:59:39 UTC ya make is running...
🔴 2025-01-30 12:09:56 UTC Build failed, see the logs. Also see fail summary

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 12:15:44 UTC Pre-commit check linux-x86_64-release-asan for 37a52ed has started.
2025-01-30 12:16:13 UTC Artifacts will be uploaded here
2025-01-30 12:19:26 UTC ya make is running...
🔴 2025-01-30 12:26:32 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 12:16:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37a52ed has started.
2025-01-30 12:16:30 UTC Artifacts will be uploaded here
2025-01-30 12:19:33 UTC ya make is running...
🔴 2025-01-30 12:24:37 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 30, 2025

2025-01-30 12:57:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for a443231 has started.
2025-01-30 12:57:36 UTC Artifacts will be uploaded here
2025-01-30 13:00:52 UTC ya make is running...
🔴 2025-01-30 13:05:41 UTC Build failed, see the logs. Also see fail summary

CyberROFL
CyberROFL previously approved these changes Feb 18, 2025
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тесты можно поправить отдельно.

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 16:42:12 UTC Pre-commit check linux-x86_64-release-asan for b315f6d has started.
2025-02-18 16:44:37 UTC Artifacts will be uploaded here
2025-02-18 16:48:06 UTC ya make is running...
2025-02-18 16:54:41 UTC Check cancelled

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 16:43:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for b315f6d has started.
2025-02-18 16:43:39 UTC Artifacts will be uploaded here
2025-02-18 16:47:03 UTC ya make is running...
2025-02-18 16:54:41 UTC Check cancelled

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 16:58:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4ac4b45 has started.
2025-02-18 16:58:40 UTC Artifacts will be uploaded here
2025-02-18 17:01:52 UTC ya make is running...
2025-02-18 17:13:20 UTC Check cancelled

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 16:58:59 UTC Pre-commit check linux-x86_64-release-asan for 4ac4b45 has started.
2025-02-18 17:01:11 UTC Artifacts will be uploaded here
2025-02-18 17:04:28 UTC ya make is running...
2025-02-18 17:13:21 UTC Check cancelled

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 17:14:05 UTC Pre-commit check linux-x86_64-release-asan for e212e56 has started.
2025-02-18 17:14:30 UTC Artifacts will be uploaded here
2025-02-18 17:17:49 UTC ya make is running...
2025-02-18 17:48:40 UTC Check cancelled

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 17:15:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for e212e56 has started.
2025-02-18 17:15:59 UTC Artifacts will be uploaded here
2025-02-18 17:19:15 UTC ya make is running...
🔴 2025-02-18 17:38:22 UTC Build failed, see the logs. Also see fail summary

Comment on lines +618 to +622
if (path->PathState != NKikimrSchemeOp::EPathStateAlter) {
return InvalidTxId;
}

return path->LastTxId;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит не очень надежно, между схемными транзакциями импорта же могут влезть другие схемные операции.

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 17:50:28 UTC Pre-commit check linux-x86_64-release-asan for 8c1932a has started.
2025-02-18 17:50:42 UTC Artifacts will be uploaded here
2025-02-18 17:54:02 UTC ya make is running...
🟡 2025-02-18 19:30:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14280 14126 0 101 14 39

2025-02-18 19:31:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 19:43:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 160 0 0 8 36

🟢 2025-02-18 19:43:59 UTC Build successful.
🟡 2025-02-18 19:44:27 UTC ydbd size 3.6 GiB changed* by +401.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e31ed43 merge: 8c1932a diff diff %
ydbd size 3 892 841 272 Bytes 3 893 252 024 Bytes +401.1 KiB +0.011%
ydbd stripped size 1 362 901 728 Bytes 1 363 045 984 Bytes +140.9 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 17:51:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8c1932a has started.
2025-02-18 17:52:24 UTC Artifacts will be uploaded here
2025-02-18 17:55:37 UTC ya make is running...
🟡 2025-02-18 19:12:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28524 25910 0 2 2473 139

2025-02-18 19:15:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 19:38:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
225 (only retried tests) 91 0 0 3 131

🟢 2025-02-18 19:38:11 UTC Build successful.
🟡 2025-02-18 19:38:31 UTC ydbd size 2.1 GiB changed* by +184.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: eb1eed1 merge: 8c1932a diff diff %
ydbd size 2 237 644 416 Bytes 2 237 833 376 Bytes +184.5 KiB +0.008%
ydbd stripped size 474 180 312 Bytes 474 220 920 Bytes +39.7 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK LGTM

@stanislav-shchetinin stanislav-shchetinin merged commit 9dda4cb into ydb-platform:main Feb 19, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants