The values of PartNo must be added #13863

Alek5andr-Kotov · 2025-01-27T08:39:51Z

Changelog entry

Two transactions. In the head of the first one is PartNo != 0. During the commit, the partition gathers them together to write them in one operation. The final key does not take into account the PartNo from the head of the first transaction.

The TBlobIterator constructor checks that the key is correct. As a result, the program crashes.

Changelog category

Bugfix
Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2025-01-27T08:43:09Z

⚪ 2025-01-27 08:43:08 UTC Pre-commit check linux-x86_64-release-asan for 48b75c5 has started.
⚪ 2025-01-27 08:43:19 UTC Artifacts will be uploaded here
⚪ 2025-01-27 08:46:10 UTC ya make is running...
🟡 2025-01-27 09:49:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11312	11227	0	43	12	30

⚪ 2025-01-27 09:50:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-27 10:02:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
131 (only retried tests)	99	0	2	4	26

⚪ 2025-01-27 10:02:27 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-27 10:14:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
54 (only retried tests)	24	0	2	4	24

🟢 2025-01-27 10:14:37 UTC Build successful.
🟢 2025-01-27 10:15:06 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `d050a4a`	merge: `48b75c5`	diff	diff %
ydbd size	3 864 160 416 Bytes	3 864 160 320 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 351 465 552 Bytes	1 351 465 488 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-27T08:43:28Z

⚪ 2025-01-27 08:43:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 48b75c5 has started.
⚪ 2025-01-27 08:43:38 UTC Artifacts will be uploaded here
⚪ 2025-01-27 08:46:27 UTC ya make is running...
🟡 2025-01-27 09:33:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18788	17475	0	7	1183	123

⚪ 2025-01-27 09:35:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-27 09:45:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
189 (only retried tests)	71	0	1	0	117

⚪ 2025-01-27 09:45:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-27 09:54:45 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
173 (only retried tests)	56	0	1	0	116

🟢 2025-01-27 09:54:52 UTC Build successful.
🟢 2025-01-27 09:55:15 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `d050a4a`	merge: `48b75c5`	diff	diff %
ydbd size	2 223 851 168 Bytes	2 223 851 168 Bytes	0 Bytes	0.000%
ydbd stripped size	470 202 576 Bytes	470 202 576 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-27T16:05:03Z

⚪ 2025-01-27 16:05:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for cfd1eca has started.
⚪ 2025-01-27 16:05:53 UTC Artifacts will be uploaded here
⚪ 2025-01-27 16:08:43 UTC ya make is running...
🟡 2025-01-27 19:28:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18794	17482	0	3	1183	126

⚪ 2025-01-27 19:30:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-27 19:41:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
189 (only retried tests)	69	0	0	0	120

🟢 2025-01-27 19:41:17 UTC Build successful.
🟢 2025-01-27 19:41:35 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `7567814`	merge: `cfd1eca`	diff	diff %
ydbd size	2 223 875 304 Bytes	2 223 875 304 Bytes	0 Bytes	0.000%
ydbd stripped size	470 212 208 Bytes	470 212 208 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-27T16:06:14Z

⚪ 2025-01-27 16:06:14 UTC Pre-commit check linux-x86_64-release-asan for cfd1eca has started.
⚪ 2025-01-27 16:06:54 UTC Artifacts will be uploaded here
⚪ 2025-01-27 16:09:45 UTC ya make is running...
🟡 2025-01-27 17:33:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11318	11253	0	20	12	33

⚪ 2025-01-27 17:34:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-27 17:52:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
99 (only retried tests)	65	0	3	3	28

⚪ 2025-01-27 17:52:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-27 18:03:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58 (only retried tests)	26	0	3	2	27

🟢 2025-01-27 18:03:45 UTC Build successful.
🟢 2025-01-27 18:04:12 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `7567814`	merge: `cfd1eca`	diff	diff %
ydbd size	3 864 227 280 Bytes	3 864 227 184 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 351 488 656 Bytes	1 351 488 592 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Gazizonoki · 2025-01-27T18:36:55Z

ydb/public/sdk/cpp/src/client/topic/ut/topic_to_table_ut.cpp

+    }
+
+    // We are doing an asynchronous commit of transactions. They will be executed simultaneously.
+    TVector<NTable::TAsyncCommitTransactionResult> futures;


Может sessions, transactions и futures сделать std::vector?

Согласен. Исправил
c838dd3

github-actions · 2025-01-28T05:36:43Z

⚪ 2025-01-28 05:36:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for bf97b65 has started.
⚪ 2025-01-28 05:36:54 UTC Artifacts will be uploaded here
⚪ 2025-01-28 05:56:17 UTC ya make is running...
🟡 2025-01-28 06:42:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18797	17482	0	2	1189	124

⚪ 2025-01-28 06:43:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-28 06:56:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
189 (only retried tests)	67	0	0	0	122

🟢 2025-01-28 06:57:05 UTC Build successful.
🟡 2025-01-28 06:57:23 UTC ydbd size 2.1 GiB changed* by +215.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `818a8a0`	merge: `bf97b65`	diff	diff %
ydbd size	2 223 875 304 Bytes	2 224 096 312 Bytes	+215.8 KiB	+0.010%
ydbd stripped size	470 212 208 Bytes	470 241 456 Bytes	+28.6 KiB	+0.006%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-28T05:36:44Z

⚪ 2025-01-28 05:36:43 UTC Pre-commit check linux-x86_64-release-asan for bf97b65 has started.
⚪ 2025-01-28 05:36:55 UTC Artifacts will be uploaded here
⚪ 2025-01-28 05:56:18 UTC ya make is running...
🟡 2025-01-28 07:02:13 UTC ydbd size 3.6 GiB changed* by +473.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `818a8a0`	merge: `bf97b65`	diff	diff %
ydbd size	3 864 227 280 Bytes	3 864 711 920 Bytes	+473.3 KiB	+0.013%
ydbd stripped size	1 351 488 656 Bytes	1 351 578 832 Bytes	+88.1 KiB	+0.007%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2025-01-28 07:02:15 UTC Check cancelled

github-actions · 2025-01-28T07:03:45Z

⚪ 2025-01-28 07:03:44 UTC Pre-commit check linux-x86_64-release-asan for 3aafd58 has started.
⚪ 2025-01-28 07:03:56 UTC Artifacts will be uploaded here
⚪ 2025-01-28 07:06:51 UTC ya make is running...
🟡 2025-01-28 08:11:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11318	11229	0	29	20	40

⚪ 2025-01-28 08:12:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-28 08:25:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
126 (only retried tests)	86	0	6	5	29

⚪ 2025-01-28 08:25:32 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-28 08:37:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
65 (only retried tests)	30	0	2	4	29

🟢 2025-01-28 08:37:18 UTC Build successful.
🟢 2025-01-28 08:37:49 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `f58d015`	merge: `3aafd58`	diff	diff %
ydbd size	3 864 803 616 Bytes	3 864 803 520 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 351 604 112 Bytes	1 351 604 048 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-28T07:05:18Z

⚪ 2025-01-28 07:05:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3aafd58 has started.
⚪ 2025-01-28 07:05:47 UTC Artifacts will be uploaded here
⚪ 2025-01-28 07:09:28 UTC ya make is running...
🟡 2025-01-28 07:57:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18798	17465	0	10	1191	132

⚪ 2025-01-28 07:58:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-28 08:11:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
208 (only retried tests)	83	0	0	0	125

🟢 2025-01-28 08:11:19 UTC Build successful.
🟢 2025-01-28 08:11:39 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `f58d015`	merge: `3aafd58`	diff	diff %
ydbd size	2 224 135 808 Bytes	2 224 135 808 Bytes	0 Bytes	0.000%
ydbd stripped size	470 246 576 Bytes	470 246 576 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Alek5andr-Kotov requested a review from a team as a code owner January 27, 2025 08:39

Alek5andr-Kotov requested a review from a-serebryanskiy January 27, 2025 08:39

github-actions bot added the bugfix label Jan 27, 2025

github-actions bot added bugfix and removed bugfix labels Jan 27, 2025

Alek5andr-Kotov mentioned this pull request Jan 27, 2025

The values of PartNo must be added #13869

Merged

Alek5andr-Kotov force-pushed the LOGBROKER-9453 branch from c89975c to 6a6e4ee Compare January 27, 2025 16:02

Alek5andr-Kotov requested a review from a team as a code owner January 27, 2025 16:02

Alek5andr-Kotov changed the title ~~WIP: The values of PartNo must be added~~ The values of PartNo must be added Jan 27, 2025

github-actions bot added bugfix and removed bugfix labels Jan 27, 2025

Gazizonoki reviewed Jan 27, 2025

View reviewed changes

Alek5andr-Kotov added 3 commits January 28, 2025 08:25

[+] test

1483cb0

[-] the values of PartNo must be added

7bc7d5d

[+] comments

d92de94

Alek5andr-Kotov force-pushed the LOGBROKER-9453 branch from 6a6e4ee to d92de94 Compare January 28, 2025 05:33

[*] std::vector together with TVector

c838dd3

alexnick88 approved these changes Jan 28, 2025

View reviewed changes

Alek5andr-Kotov mentioned this pull request Jan 28, 2025

The values of PartNo must be added #13914

Merged

a-serebryanskiy approved these changes Jan 28, 2025

View reviewed changes

Gazizonoki approved these changes Jan 28, 2025

View reviewed changes

Alek5andr-Kotov merged commit a89d4c9 into ydb-platform:main Jan 28, 2025
12 checks passed

This was referenced Jan 29, 2025

YQ-4046 KqpRun improved templates #13951

Merged

YQ-4043 fixed hanging in kqp write actor #14017

Merged

azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025

The values of PartNo must be added (ydb-platform#13863)

374f9b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

The values of PartNo must be added #13863

The values of PartNo must be added #13863

Uh oh!

Alek5andr-Kotov commented Jan 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

Gazizonoki Jan 27, 2025

Uh oh!

Alek5andr-Kotov Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

The values of PartNo must be added #13863

The values of PartNo must be added #13863

Uh oh!

Conversation

Alek5andr-Kotov commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gazizonoki Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

Alek5andr-Kotov Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alek5andr-Kotov commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading