Skip to content

24-3: Configure minimum coordinator resolution with icb #13747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 23, 2025

Changelog entry

Coordinator plan resolution can now be configured using immediate control board

Changelog category

  • Improvement

Additional information

Coordinators in large databases spend too much cpu time broadcasting planned steps to other nodes, which in turn hurts tail latency. This PR allows configuring the minimum plan resolution, which can help reducing the number of ticks per second produced by coordinators, indirectly reducing network-related activity and improving tail latency in large databases.

Additionally, it was discovered that plan step alignment was not working correctly due to almost all non-volatile transactions planning using "rapid" slots. Support for rapid planning has been removed and transactions are now always planned to some future step, which is aligned when possible.

Fixes #13693.

@snaury snaury self-assigned this Jan 23, 2025
@snaury snaury marked this pull request as ready for review January 23, 2025 07:56
@snaury snaury requested a review from a team as a code owner January 23, 2025 07:56
Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 07:57:09 UTC Pre-commit check for b15bfd0 has started.
2025-01-23 08:00:07 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-23 08:41:02 UTC Build successful.
2025-01-23 08:41:20 UTC Tests are running...
🔴 2025-01-23 10:58:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11838 11735 0 33 26 44

🟢 2025-01-23 10:59:56 UTC ydbd size 5.6 GiB changed* by +13.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f4c85ea merge: b15bfd0 diff diff %
ydbd size 6 002 539 544 Bytes 6 002 553 472 Bytes +13.6 KiB +0.000%
ydbd stripped size 1 504 209 088 Bytes 1 504 213 632 Bytes +4.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 07:57:09 UTC Pre-commit check for b15bfd0 has started.
2025-01-23 08:00:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-23 09:04:02 UTC Build successful.
2025-01-23 09:04:17 UTC Tests are running...
🔴 2025-01-23 10:58:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40421 35145 0 18 5218 40

🟢 2025-01-23 10:59:21 UTC ydbd size 8.3 GiB changed* by +11.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f4c85ea merge: b15bfd0 diff diff %
ydbd size 8 874 209 936 Bytes 8 874 221 520 Bytes +11.3 KiB +0.000%
ydbd stripped size 484 292 424 Bytes 484 292 744 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 6676ba4 into ydb-platform:stable-24-3 Jan 23, 2025
6 of 10 checks passed
@snaury snaury deleted the feature-13693-limit-volatile-plan-resolution-24-3 branch January 23, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants