Skip to content

KIKIMR-20842: make error non-retryable again #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2024
Merged

KIKIMR-20842: make error non-retryable again #1364

merged 1 commit into from
Jan 27, 2024

Conversation

eivanov89
Copy link
Member

@eivanov89 eivanov89 commented Jan 27, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@eivanov89 eivanov89 requested a review from Enjection January 27, 2024 20:34
Enjection
Enjection approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@Enjection Enjection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge, but will discuss regression fix for this later.

@eivanov89 eivanov89 merged commit 62f8e34 into ydb-platform:main Jan 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2024 •
edited
Loading

⚪ 2024-01-27 20:37:43 UTC Pre-commit check for 6e988b0 has started.
⚪ 2024-01-27 20:37:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-27 20:40:02 UTC Build successful.
⚪ 2024-01-27 20:40:19 UTC Tests are running...
🔴 2024-01-27 21:51:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60225 50952 0 2 9253 18

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2024 •
edited
Loading

⚪ 2024-01-27 20:37:51 UTC Pre-commit check for 6e988b0 has started.
⚪ 2024-01-27 20:37:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-27 20:40:26 UTC Build successful.
⚪ 2024-01-27 20:40:39 UTC Tests are running...
🔴 2024-01-27 22:18:05 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15995 15860 0 44 61 30

@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
@eivanov89 eivanov89 deleted the KIKIMR-20842-fix-perf-regression branch September 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enjection Enjection Enjection approved these changes

Assignees
No one assigned
Labels
new-feature not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eivanov89 @Enjection