Skip to content

24-3-15: Return default decimal if scheme proto is empty #13554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Jan 20, 2025

Changelog entry

Scheme proto propagation could be slow in some races and new code can return old proto. In this case we should not throw exception.

Changelog category

  • Bugfix

Additional information

...

@azevaykin azevaykin requested a review from a team as a code owner January 20, 2025 08:48
Copy link

github-actions bot commented Jan 20, 2025

2025-01-20 08:52:27 UTC Pre-commit check for 779d15f has started.
2025-01-20 08:55:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-20 09:35:49 UTC Build successful.
2025-01-20 09:36:06 UTC Tests are running...
🔴 2025-01-20 11:25:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39617 34345 0 17 5217 38

🟢 2025-01-20 11:25:48 UTC ydbd size 8.3 GiB changed* by -600 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 2257ad4 merge: 779d15f diff diff %
ydbd size 8 874 221 136 Bytes 8 874 220 536 Bytes -600 Bytes -0.000%
ydbd stripped size 484 292 680 Bytes 484 292 552 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 20, 2025

2025-01-20 08:52:37 UTC Pre-commit check for 779d15f has started.
2025-01-20 08:55:15 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-20 09:18:53 UTC Build successful.
2025-01-20 09:19:10 UTC Tests are running...
🔴 2025-01-20 11:22:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11045 10944 0 28 30 43

🟢 2025-01-20 11:23:19 UTC ydbd size 5.6 GiB changed* by -4.4 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 2257ad4 merge: 779d15f diff diff %
ydbd size 6 002 552 696 Bytes 6 002 548 168 Bytes -4.4 KiB -0.000%
ydbd stripped size 1 504 212 960 Bytes 1 504 208 480 Bytes -4.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin changed the title 24-3: Return default decimal if scheme proto is empty 24-3-15: Return default decimal if scheme proto is empty Jan 20, 2025
@azevaykin azevaykin merged commit d112eb7 into ydb-platform:stable-24-3 Jan 20, 2025
6 of 10 checks passed
@azevaykin azevaykin deleted the stable-24-3 branch January 20, 2025 12:03
@azevaykin azevaykin restored the stable-24-3 branch January 21, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants