Skip to content

BATCH UPDATE/DELETE queries for per row updates with NoTx #13340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Feb 20, 2025
Merged

BATCH UPDATE/DELETE queries for per row updates with NoTx #13340

merged 35 commits into from
Feb 20, 2025

Conversation

dahbka-lis
Copy link
Member

@dahbka-lis dahbka-lis commented Jan 13, 2025 •
edited
Loading

Changelog entry

Implemented BATCH UPDATE/DELETE syntax with query checks for idempotent, multi tables and multi statements. New queries with new PartitionedExecuterActor make per row updates for every data shard as an immediate commit.

...

Changelog category

  • New feature

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 15:35:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 84d4910 has started.
⚪ 2025-01-13 15:35:59 UTC Artifacts will be uploaded here
⚪ 2025-01-13 15:38:52 UTC ya make is running...
🔴 2025-01-13 15:41:29 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 15:36:02 UTC Pre-commit check linux-x86_64-release-asan for 84d4910 has started.
⚪ 2025-01-13 15:36:16 UTC Artifacts will be uploaded here
⚪ 2025-01-13 15:39:08 UTC ya make is running...
🔴 2025-01-13 15:41:57 UTC Build failed, see the logs. Also see fail summary

nikvas0
nikvas0 requested changes Jan 15, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 14:19:13 UTC Pre-commit check linux-x86_64-release-asan for ea69507 has started.
⚪ 2025-01-15 14:19:46 UTC Artifacts will be uploaded here
⚪ 2025-01-15 14:23:16 UTC ya make is running...
🔴 2025-01-15 14:39:15 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 14:20:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for ea69507 has started.
⚪ 2025-01-15 14:20:27 UTC Artifacts will be uploaded here
⚪ 2025-01-15 14:23:25 UTC ya make is running...
🔴 2025-01-15 14:26:23 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 11:48:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8abe2fd has started.
⚪ 2025-01-20 11:48:12 UTC Artifacts will be uploaded here
⚪ 2025-01-20 11:51:22 UTC ya make is running...
🟡 2025-01-20 12:47:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25717 23200 0 1 2390 126

⚪ 2025-01-20 12:50:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-20 13:01:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 72 0 0 0 120

🟢 2025-01-20 13:01:59 UTC Build successful.
🟢 2025-01-20 13:02:19 UTC ydbd size 2.1 GiB changed* by +68.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04f4156 merge: 8abe2fd diff diff %
ydbd size 2 216 627 368 Bytes 2 216 697 160 Bytes +68.2 KiB +0.003%
ydbd stripped size 468 629 104 Bytes 468 637 872 Bytes +8.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis requested a review from nikvas0 January 20, 2025 11:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 15:27:47 UTC Pre-commit check linux-x86_64-release-asan for 956ac0f has started.
⚪ 2025-01-20 15:28:39 UTC Artifacts will be uploaded here
⚪ 2025-01-20 15:31:32 UTC ya make is running...
⚫ 2025-01-20 15:35:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 15:27:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 956ac0f has started.
⚪ 2025-01-20 15:28:02 UTC Artifacts will be uploaded here
⚪ 2025-01-20 15:30:59 UTC ya make is running...
⚫ 2025-01-20 15:35:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 15:37:08 UTC Pre-commit check linux-x86_64-release-asan for 05ad2e8 has started.
⚪ 2025-01-20 15:37:18 UTC Artifacts will be uploaded here
⚪ 2025-01-20 15:40:13 UTC ya make is running...
🟡 2025-01-20 17:01:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11517 11361 0 92 35 29

⚪ 2025-01-20 17:02:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-20 17:17:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
241 (only retried tests) 204 0 3 8 26

⚪ 2025-01-20 17:17:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-20 17:28:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 37 0 1 0 23

🟢 2025-01-20 17:28:54 UTC Build successful.
🟡 2025-01-20 17:29:24 UTC ydbd size 3.6 GiB changed* by +310.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 345e7b5 merge: 05ad2e8 diff diff %
ydbd size 3 853 055 416 Bytes 3 853 373 488 Bytes +310.6 KiB +0.008%
ydbd stripped size 1 346 223 920 Bytes 1 346 302 736 Bytes +77.0 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 15:37:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 05ad2e8 has started.
⚪ 2025-01-20 15:37:26 UTC Artifacts will be uploaded here
⚪ 2025-01-20 15:40:32 UTC ya make is running...
🟡 2025-01-20 16:43:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25732 23223 0 2 2380 127

⚪ 2025-01-20 16:45:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-20 16:58:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
187 (only retried tests) 68 0 0 0 119

🟢 2025-01-20 16:58:18 UTC Build successful.
🟡 2025-01-20 16:58:38 UTC ydbd size 2.1 GiB changed* by +113.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 345e7b5 merge: 05ad2e8 diff diff %
ydbd size 2 216 662 904 Bytes 2 216 778 984 Bytes +113.4 KiB +0.005%
ydbd stripped size 468 635 152 Bytes 468 655 888 Bytes +20.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 15:10:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 39e46d9 has started.
⚪ 2025-01-22 15:10:13 UTC Artifacts will be uploaded here
⚪ 2025-01-22 15:13:08 UTC ya make is running...
🟡 2025-01-22 16:25:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25943 23399 0 8 2402 134

⚪ 2025-01-22 16:28:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-22 16:39:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 89 0 0 0 119

🟢 2025-01-22 16:39:38 UTC Build successful.
🟡 2025-01-22 16:40:01 UTC ydbd size 2.1 GiB changed* by +133.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0dc9b3c merge: 39e46d9 diff diff %
ydbd size 2 219 461 776 Bytes 2 219 598 880 Bytes +133.9 KiB +0.006%
ydbd stripped size 469 482 128 Bytes 469 509 008 Bytes +26.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 15:10:40 UTC Pre-commit check linux-x86_64-release-asan for 39e46d9 has started.
⚪ 2025-01-22 15:10:46 UTC Artifacts will be uploaded here
⚪ 2025-01-22 15:13:43 UTC ya make is running...
🟡 2025-01-22 16:12:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11677 11595 0 22 32 28

⚪ 2025-01-22 16:13:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 16:25:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 68 0 4 20 25

⚪ 2025-01-22 16:25:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-22 16:37:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 46 0 2 0 25

🟢 2025-01-22 16:37:31 UTC Build successful.
🟡 2025-01-22 16:37:59 UTC ydbd size 3.6 GiB changed* by +381.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0dc9b3c merge: 39e46d9 diff diff %
ydbd size 3 856 111 672 Bytes 3 856 502 304 Bytes +381.5 KiB +0.010%
ydbd stripped size 1 348 642 992 Bytes 1 348 744 848 Bytes +99.5 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

⚪ 2025-02-03 08:45:28 UTC Pre-commit check linux-x86_64-release-asan for eff12e8 has started.
⚪ 2025-02-03 08:45:41 UTC Artifacts will be uploaded here
⚪ 2025-02-03 08:48:34 UTC ya make is running...
⚫ 2025-02-03 08:50:11 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

⚪ 2025-02-03 08:45:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for eff12e8 has started.
⚪ 2025-02-03 08:45:43 UTC Artifacts will be uploaded here
⚪ 2025-02-03 08:48:45 UTC ya make is running...
⚫ 2025-02-03 08:50:11 UTC Check cancelled

@dahbka-lis dahbka-lis changed the title Syntax of UPDATE/DELETE PER ROW with query checks BATCH UPDATE/DELETE queries for per row updates with NoTx Feb 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

🟢 2025-02-20 10:32:11 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 12:02:18 UTC Pre-commit check linux-x86_64-release-asan for 7662846 has started.
⚪ 2025-02-20 12:03:47 UTC Artifacts will be uploaded here
⚪ 2025-02-20 12:07:08 UTC ya make is running...
🟡 2025-02-20 13:59:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13800 13718 0 31 10 41

⚪ 2025-02-20 14:00:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-20 14:05:02 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4a69e43 merge: 7662846 diff diff %
ydbd size 3 895 485 704 Bytes 3 896 638 488 Bytes +1.1 MiB +0.030%
ydbd stripped size 1 364 012 320 Bytes 1 364 311 936 Bytes +292.6 KiB +0.022%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-20 14:05:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 12:02:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7662846 has started.
⚪ 2025-02-20 12:02:37 UTC Artifacts will be uploaded here
⚪ 2025-02-20 12:05:53 UTC ya make is running...
🟢 2025-02-20 13:37:08 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28038 25443 0 0 2461 134

🟢 2025-02-20 13:40:33 UTC Build successful.
🟡 2025-02-20 13:40:54 UTC ydbd size 2.1 GiB changed* by +493.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fbd1743 merge: 7662846 diff diff %
ydbd size 2 239 408 136 Bytes 2 239 913 248 Bytes +493.3 KiB +0.023%
ydbd stripped size 474 528 760 Bytes 474 608 952 Bytes +78.3 KiB +0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

nikvas0
nikvas0 requested changes Feb 20, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 14:15:55 UTC Pre-commit check linux-x86_64-release-asan for c3b0121 has started.
⚪ 2025-02-20 14:16:09 UTC Artifacts will be uploaded here
⚪ 2025-02-20 14:19:32 UTC ya make is running...
🟡 2025-02-20 15:57:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13800 13690 0 54 17 39

⚪ 2025-02-20 15:58:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 16:21:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
155 (only retried tests) 114 0 0 9 32

🟢 2025-02-20 16:21:55 UTC Build successful.
🟡 2025-02-20 16:22:23 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8e57514 merge: c3b0121 diff diff %
ydbd size 3 895 673 176 Bytes 3 896 813 384 Bytes +1.1 MiB +0.029%
ydbd stripped size 1 364 069 600 Bytes 1 364 362 752 Bytes +286.3 KiB +0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 16:46:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for c3b0121 has started.
⚪ 2025-02-20 16:46:21 UTC Artifacts will be uploaded here
⚪ 2025-02-20 16:49:42 UTC ya make is running...
⚫ 2025-02-20 17:22:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 17:24:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for efcc4a5 has started.
⚪ 2025-02-20 17:26:07 UTC Artifacts will be uploaded here
⚪ 2025-02-20 17:29:19 UTC ya make is running...
🟡 2025-02-20 18:54:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28038 25438 0 1 2462 137

⚪ 2025-02-20 18:57:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 19:23:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 81 0 0 1 130

🟢 2025-02-20 19:24:08 UTC Build successful.
🟡 2025-02-20 19:24:28 UTC ydbd size 2.1 GiB changed* by +497.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd6334d merge: efcc4a5 diff diff %
ydbd size 2 239 517 968 Bytes 2 240 027 032 Bytes +497.1 KiB +0.023%
ydbd stripped size 474 552 088 Bytes 474 636 376 Bytes +82.3 KiB +0.018%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 17:25:10 UTC Pre-commit check linux-x86_64-release-asan for efcc4a5 has started.
⚪ 2025-02-20 17:25:21 UTC Artifacts will be uploaded here
⚪ 2025-02-20 17:28:37 UTC ya make is running...
🟡 2025-02-20 19:04:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13800 13711 0 26 27 36

⚪ 2025-02-20 19:05:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 19:23:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 91 0 0 3 34

🟢 2025-02-20 19:24:11 UTC Build successful.
🟡 2025-02-20 19:24:38 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd6334d merge: efcc4a5 diff diff %
ydbd size 3 895 685 600 Bytes 3 896 821 640 Bytes +1.1 MiB +0.029%
ydbd stripped size 1 364 075 168 Bytes 1 364 364 160 Bytes +282.2 KiB +0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit 23aa667 into ydb-platform:main Feb 20, 2025
12 checks passed
This was referenced Feb 21, 2025
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@dahbka-lis
BATCH UPDATE/DELETE queries for per row updates with NoTx (ydb-platfo…
84c8e5b 
…rm#13340)
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
@naspirato naspirato mentioned this pull request Mar 5, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@dahbka-lis @blinkov
BATCH UPDATE/DELETE queries for per row updates with NoTx (#13340)
c8a7296
@dahbka-lis dahbka-lis linked an issue Mar 31, 2025 that may be closed by this pull request
implement batch update & delete operations #15695
Closed
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request May 7, 2025
@dahbka-lis
BATCH UPDATE/DELETE queries for per row updates with NoTx (ydb-platfo…
d7c2e4d 
…rm#13340)
@dahbka-lis dahbka-lis mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikvas0 nikvas0 nikvas0 approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement batch update & delete operations
2 participants
@dahbka-lis @nikvas0