Skip to content

Fix group resolver bug #13282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jan 10, 2025

Changelog entry

Fix group resolver bug

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Group resolver bug leading to incorrect assertion failure has been fixed.

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 15:32:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5ac564a has started.
2025-01-10 15:32:45 UTC Artifacts will be uploaded here
2025-01-10 15:35:41 UTC ya make is running...
🟡 2025-01-10 16:24:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18971 17673 0 3 1169 126

2025-01-10 16:26:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-10 16:39:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 63 0 0 0 123

🟢 2025-01-10 16:39:07 UTC Build successful.
🟢 2025-01-10 16:39:28 UTC ydbd size 2.1 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1a38741 merge: 5ac564a diff diff %
ydbd size 2 245 015 256 Bytes 2 245 018 840 Bytes +3.5 KiB +0.000%
ydbd stripped size 472 462 576 Bytes 472 462 768 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 15:33:35 UTC Pre-commit check linux-x86_64-release-asan for 5ac564a has started.
2025-01-10 15:33:48 UTC Artifacts will be uploaded here
2025-01-10 15:36:40 UTC ya make is running...
🟡 2025-01-10 16:31:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11848 11796 0 15 3 34

2025-01-10 16:32:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 16:44:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
89 (only retried tests) 53 0 4 1 31

2025-01-10 16:44:32 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-10 16:55:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 35 0 1 2 26

🟢 2025-01-10 16:55:57 UTC Build successful.
🟢 2025-01-10 16:56:23 UTC ydbd size 3.6 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1a38741 merge: 5ac564a diff diff %
ydbd size 3 875 059 232 Bytes 3 875 063 904 Bytes +4.6 KiB +0.000%
ydbd stripped size 1 351 054 864 Bytes 1 351 055 120 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) January 10, 2025 15:33
@alexvru alexvru merged commit 6551911 into ydb-platform:main Jan 10, 2025
13 checks passed
@alexvru alexvru deleted the nodewarden/fix-group-resolver branch January 10, 2025 18:26
SvartMetal pushed a commit to ydb-platform/nbs that referenced this pull request Jan 23, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
SvartMetal pushed a commit to ydb-platform/nbs that referenced this pull request Feb 12, 2025
SvartMetal added a commit to ydb-platform/nbs that referenced this pull request Feb 13, 2025
serbel324 pushed a commit to serbel324/ydb that referenced this pull request Mar 19, 2025
serbel324 pushed a commit to serbel324/ydb that referenced this pull request Mar 19, 2025
serbel324 added a commit that referenced this pull request Mar 19, 2025
Co-authored-by: Alexander Rutkovsky <alexvru@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants