Skip to content

Conversation

@andrewstalin
Copy link
Contributor

@andrewstalin andrewstalin commented Jan 10, 2025

Changelog entry

Add LastSuccessfulLogin time point to TSidRecord. In the future, this information will be added to the audit log.

Changelog category

  • Not for changelog

Additional information

Schemeshard stores all the data in memory and when performing the operation it is not possible to read the data from local db.Therefore, to get the time of the last successful login, we need to receive it along with the user sid from LoginProvider.

@github-actions
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 05:38:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e3f5a0 has started.
2025-01-10 05:38:33 UTC Artifacts will be uploaded here
2025-01-10 05:54:24 UTC ya make is running...
🟡 2025-01-10 07:21:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27667 25155 0 4 2383 125

2025-01-10 07:23:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 07:35:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 68 0 3 0 121

2025-01-10 07:36:01 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-10 07:48:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 63 0 0 0 119

🟢 2025-01-10 07:48:18 UTC Build successful.
🟢 2025-01-10 07:48:39 UTC ydbd size 2.1 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 046fc2f merge: 6e3f5a0 diff diff %
ydbd size 2 244 801 784 Bytes 2 244 805 840 Bytes +4.0 KiB +0.000%
ydbd stripped size 472 424 080 Bytes 472 424 592 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 05:38:36 UTC Pre-commit check linux-x86_64-release-asan for 6e3f5a0 has started.
2025-01-10 05:38:47 UTC Artifacts will be uploaded here
2025-01-10 05:54:39 UTC ya make is running...
🟡 2025-01-10 07:24:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13664 13607 0 27 3 27

2025-01-10 07:25:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 07:37:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 67 0 7 1 24

2025-01-10 07:37:30 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-10 07:49:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 29 0 6 0 25

🟢 2025-01-10 07:49:28 UTC Build successful.
🟢 2025-01-10 07:49:59 UTC ydbd size 3.6 GiB changed* by +5.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 046fc2f merge: 6e3f5a0 diff diff %
ydbd size 3 874 667 936 Bytes 3 874 673 080 Bytes +5.0 KiB +0.000%
ydbd stripped size 1 350 937 552 Bytes 1 350 938 992 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

adameat
adameat previously approved these changes Jan 13, 2025
ijon
ijon previously approved these changes Jan 15, 2025
@andrewstalin andrewstalin dismissed stale reviews from ijon and adameat via 0754c4a January 15, 2025 08:59
@andrewstalin andrewstalin requested a review from ijon January 15, 2025 09:01
@github-actions
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 09:02:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e3a2a8 has started.
2025-01-15 09:02:34 UTC Artifacts will be uploaded here
2025-01-15 09:06:28 UTC ya make is running...
🟡 2025-01-15 10:34:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27702 25189 0 4 2380 129

2025-01-15 10:37:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 10:52:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 72 0 0 0 121

🟢 2025-01-15 10:52:17 UTC Build successful.
🟢 2025-01-15 10:52:38 UTC ydbd size 2.1 GiB changed* by +3.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b7192f6 merge: 8e3a2a8 diff diff %
ydbd size 2 247 465 736 Bytes 2 247 469 600 Bytes +3.8 KiB +0.000%
ydbd stripped size 472 858 544 Bytes 472 858 992 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 09:04:10 UTC Pre-commit check linux-x86_64-release-asan for 8e3a2a8 has started.
2025-01-15 09:04:22 UTC Artifacts will be uploaded here
2025-01-15 09:07:51 UTC ya make is running...
🟡 2025-01-15 10:49:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13691 13633 0 20 12 26

2025-01-15 10:50:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 11:02:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 65 0 0 1 26

🟢 2025-01-15 11:02:30 UTC Build successful.
🟢 2025-01-15 11:02:55 UTC ydbd size 3.6 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b7192f6 merge: 8e3a2a8 diff diff %
ydbd size 3 895 388 520 Bytes 3 895 393 192 Bytes +4.6 KiB +0.000%
ydbd stripped size 1 360 960 784 Bytes 1 360 961 808 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@andrewstalin andrewstalin merged commit 0913a5c into ydb-platform:main Jan 15, 2025
12 checks passed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants