Skip to content

generic lookup: handle retrievable errors in grpc #13119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Dec 28, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 12:09:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9453b0 has started.
2024-12-28 12:10:05 UTC Artifacts will be uploaded here
2024-12-28 12:12:56 UTC ya make is running...
🟡 2024-12-28 13:49:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20506 19916 0 5 461 124

2024-12-28 13:51:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-28 14:02:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 70 0 0 0 122

🟢 2024-12-28 14:02:59 UTC Build successful.
🟢 2024-12-28 14:03:18 UTC ydbd size 2.1 GiB changed* by +9.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e1ce008 merge: a9453b0 diff diff %
ydbd size 2 242 053 384 Bytes 2 242 063 480 Bytes +9.9 KiB +0.000%
ydbd stripped size 472 101 744 Bytes 472 103 536 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 12:10:01 UTC Pre-commit check linux-x86_64-release-asan for a9453b0 has started.
2024-12-28 12:10:13 UTC Artifacts will be uploaded here
2024-12-28 12:13:14 UTC ya make is running...
🟡 2024-12-28 13:38:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11570 11501 0 35 4 30

2024-12-28 13:40:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 13:52:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 82 0 7 2 27

2024-12-28 13:52:48 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-28 14:04:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 35 0 5 0 26

🟢 2024-12-28 14:04:38 UTC Build successful.
🟢 2024-12-28 14:05:09 UTC ydbd size 3.6 GiB changed* by +20.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e1ce008 merge: a9453b0 diff diff %
ydbd size 3 870 467 528 Bytes 3 870 488 184 Bytes +20.2 KiB +0.001%
ydbd stripped size 1 349 997 072 Bytes 1 350 006 736 Bytes +9.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

vitalyisaev2
vitalyisaev2 previously approved these changes Dec 28, 2024
Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 16:23:52 UTC Pre-commit check linux-x86_64-release-asan for 25d045b has started.
2024-12-28 16:24:03 UTC Artifacts will be uploaded here
2024-12-28 16:26:54 UTC ya make is running...
🟡 2024-12-28 17:21:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11567 11511 0 27 1 28

2024-12-28 17:22:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 17:34:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 65 0 8 1 27

2024-12-28 17:35:07 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-28 17:46:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 33 0 3 0 27

🟢 2024-12-28 17:46:55 UTC Build successful.
🟢 2024-12-28 17:47:27 UTC ydbd size 3.6 GiB changed* by +30.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e1ce008 merge: 25d045b diff diff %
ydbd size 3 870 467 528 Bytes 3 870 499 104 Bytes +30.8 KiB +0.001%
ydbd stripped size 1 349 997 072 Bytes 1 350 009 552 Bytes +12.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 16:23:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 25d045b has started.
2024-12-28 16:24:06 UTC Artifacts will be uploaded here
2024-12-28 16:26:56 UTC ya make is running...
🟡 2024-12-28 17:29:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20506 19915 0 3 461 127

2024-12-28 17:31:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-28 17:43:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 70 0 0 0 120

🟢 2024-12-28 17:43:44 UTC Build successful.
🟢 2024-12-28 17:44:03 UTC ydbd size 2.1 GiB changed* by +17.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 22e791d merge: 25d045b diff diff %
ydbd size 2 242 053 384 Bytes 2 242 071 376 Bytes +17.6 KiB +0.001%
ydbd stripped size 472 101 744 Bytes 472 104 880 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam changed the title [WIP] [RFC] generic lookup: handle retrievable errors in grpc [RFC] generic lookup: handle retrievable errors in grpc Dec 28, 2024
@yumkam yumkam changed the title [RFC] generic lookup: handle retrievable errors in grpc generic lookup: handle retrievable errors in grpc Jan 9, 2025
@yumkam yumkam marked this pull request as ready for review January 9, 2025 08:49
@yumkam yumkam requested a review from a team as a code owner January 9, 2025 08:49
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 10:19:48 UTC Pre-commit check linux-x86_64-release-asan for 9f0c221 has started.
2025-01-10 10:19:59 UTC Artifacts will be uploaded here
2025-01-10 10:22:48 UTC ya make is running...
🟡 2025-01-10 11:23:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11585 11522 0 27 4 32

2025-01-10 11:24:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-10 11:37:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 79 0 0 1 29

🟢 2025-01-10 11:37:31 UTC Build successful.
🟢 2025-01-10 11:37:57 UTC ydbd size 3.6 GiB changed* by +39.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: caaa1f0 merge: 9f0c221 diff diff %
ydbd size 3 874 737 152 Bytes 3 874 777 976 Bytes +39.9 KiB +0.001%
ydbd stripped size 1 350 962 640 Bytes 1 350 980 496 Bytes +17.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 10:20:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9f0c221 has started.
2025-01-10 10:20:55 UTC Artifacts will be uploaded here
2025-01-10 10:24:16 UTC ya make is running...
🟡 2025-01-10 11:17:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25295 22785 0 1 2383 126

2025-01-10 11:19:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-10 11:32:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 66 0 0 0 119

🟢 2025-01-10 11:32:47 UTC Build successful.
🟢 2025-01-10 11:33:11 UTC ydbd size 2.1 GiB changed* by +20.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d6febab merge: 9f0c221 diff diff %
ydbd size 2 244 844 376 Bytes 2 244 864 880 Bytes +20.0 KiB +0.001%
ydbd stripped size 472 435 536 Bytes 472 439 184 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

YQL_CLOG(DEBUG, ProviderGeneric) << "ActorId=" << selfId << " Got ReadSplitsStreamIterator from Connector";
auto result = ExtractFromConstFuture(asyncResult);
if (result.Status.Ok()) {
auto ev = new TEvReadSplitsIterator(std::move(result.Iterator));
actorSystem->Send(new NActors::IEventHandle(selfId, selfId, ev));
} else {
SendError(actorSystem, selfId, result.Status);
SendRetryOrError(actorSystem, selfId, result.Status, retriesRemaining);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оно будет работать так, ну нужно ли заново начинать (ListSplits) ? (я сам особо ничего не знаю как тут работает)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не вполне понятно в каком состоянии находится коннектор (особенно в случае таймаута), так что просто начинаем с нуля (ListSplits)

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 11:40:54 UTC Pre-commit check linux-x86_64-release-asan for 0bb733b has started.
2025-01-14 11:41:06 UTC Artifacts will be uploaded here
2025-01-14 11:43:56 UTC ya make is running...
🟡 2025-01-14 12:38:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11591 11548 0 15 2 26

2025-01-14 12:39:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-14 12:51:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 45 0 0 1 26

🟢 2025-01-14 12:51:24 UTC Build successful.
🟢 2025-01-14 12:51:48 UTC ydbd size 3.6 GiB changed* by +30.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecc265c merge: 0bb733b diff diff %
ydbd size 3 895 285 816 Bytes 3 895 317 368 Bytes +30.8 KiB +0.001%
ydbd stripped size 1 360 915 440 Bytes 1 360 927 920 Bytes +12.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 11:41:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0bb733b has started.
2025-01-14 11:41:17 UTC Artifacts will be uploaded here
2025-01-14 11:44:24 UTC ya make is running...
🟢 2025-01-14 12:38:46 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25306 22802 0 0 2380 124

🟢 2025-01-14 12:40:54 UTC Build successful.
🟢 2025-01-14 12:41:10 UTC ydbd size 2.1 GiB changed* by +17.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecc265c merge: 0bb733b diff diff %
ydbd size 2 247 422 776 Bytes 2 247 440 768 Bytes +17.6 KiB +0.001%
ydbd stripped size 472 862 928 Bytes 472 866 064 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam requested a review from uzhastik January 14, 2025 12:55
@yumkam yumkam requested a review from kardymonds January 14, 2025 12:55
kardymonds
kardymonds previously approved these changes Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 09:20:14 UTC Pre-commit check linux-x86_64-release-asan for 0136a66 has started.
2025-01-15 09:20:18 UTC Artifacts will be uploaded here
2025-01-15 09:23:17 UTC ya make is running...
🟡 2025-01-15 10:54:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11597 11523 0 37 9 28

2025-01-15 10:55:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 11:07:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 95 0 1 7 24

2025-01-15 11:07:37 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-15 11:16:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 31 0 0 0 23

🟢 2025-01-15 11:17:01 UTC Build successful.
🟢 2025-01-15 11:17:31 UTC ydbd size 3.6 GiB changed* by +28.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 179f412 merge: 0136a66 diff diff %
ydbd size 3 895 413 760 Bytes 3 895 443 352 Bytes +28.9 KiB +0.001%
ydbd stripped size 1 360 966 096 Bytes 1 360 975 216 Bytes +8.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 09:21:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0136a66 has started.
2025-01-15 09:21:58 UTC Artifacts will be uploaded here
2025-01-15 09:24:49 UTC ya make is running...
🟡 2025-01-15 10:17:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25315 22813 0 3 2380 119

2025-01-15 10:19:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 10:31:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 59 0 0 0 117

🟢 2025-01-15 10:31:42 UTC Build successful.
🟢 2025-01-15 10:32:02 UTC ydbd size 2.1 GiB changed* by +18.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 179f412 merge: 0136a66 diff diff %
ydbd size 2 247 483 592 Bytes 2 247 502 760 Bytes +18.7 KiB +0.001%
ydbd stripped size 472 860 816 Bytes 472 864 336 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit 27eb560 into ydb-platform:main Jan 16, 2025
12 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Jan 16, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants