Skip to content

Fix viewer nodes #13021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix viewer nodes #13021

merged 2 commits into from
Jan 10, 2025

Conversation

adameat
Copy link
Member

@adameat adameat commented Dec 26, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

fix crash. add storage nodes in database.
closes #12288
closes #12852

@adameat adameat requested a review from a team as a code owner December 26, 2024 08:07
alexvru
alexvru previously approved these changes Dec 26, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

2024-12-26 08:09:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 53b88fe has started.
2024-12-26 08:09:38 UTC Artifacts will be uploaded here
2024-12-26 08:12:24 UTC ya make is running...
🟡 2024-12-26 09:17:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18895 17350 0 5 1419 121

2024-12-26 09:18:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 09:30:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 67 0 1 1 117

2024-12-26 09:30:14 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-26 09:41:53 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 52 0 1 0 117

🟢 2024-12-26 09:42:00 UTC Build successful.
🟢 2024-12-26 09:42:21 UTC ydbd size 2.1 GiB changed* by +27.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9cffaed merge: 53b88fe diff diff %
ydbd size 2 239 300 192 Bytes 2 239 328 696 Bytes +27.8 KiB +0.001%
ydbd stripped size 471 404 016 Bytes 471 460 848 Bytes +55.5 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 26, 2024

2024-12-26 08:09:47 UTC Pre-commit check linux-x86_64-release-asan for 53b88fe has started.
2024-12-26 08:09:51 UTC Artifacts will be uploaded here
2024-12-26 08:12:40 UTC ya make is running...
🟡 2024-12-26 09:32:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11019 10955 0 24 9 31

2024-12-26 09:33:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 09:45:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 72 0 3 0 25

2024-12-26 09:45:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-26 09:57:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 29 0 2 0 23

🟢 2024-12-26 09:57:29 UTC Build successful.
🟡 2024-12-26 09:57:56 UTC ydbd size 3.6 GiB changed* by +109.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9cffaed merge: 53b88fe diff diff %
ydbd size 3 865 513 400 Bytes 3 865 625 400 Bytes +109.4 KiB +0.003%
ydbd stripped size 1 347 672 400 Bytes 1 347 847 696 Bytes +171.2 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 13:42:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for d6fd5c9 has started.
2024-12-27 13:42:55 UTC Artifacts will be uploaded here
2024-12-27 13:45:53 UTC ya make is running...
🟡 2024-12-27 14:58:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19131 17586 0 1 1417 127

2024-12-27 15:00:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 15:12:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 64 0 1 0 120

2024-12-27 15:12:50 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-27 15:24:31 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 55 0 1 0 120

🟢 2024-12-27 15:24:43 UTC Build successful.
🟢 2024-12-27 15:25:07 UTC ydbd size 2.1 GiB changed* by +14.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a4e0377 merge: d6fd5c9 diff diff %
ydbd size 2 241 674 304 Bytes 2 241 688 624 Bytes +14.0 KiB +0.001%
ydbd stripped size 471 948 688 Bytes 471 951 376 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 13:43:01 UTC Pre-commit check linux-x86_64-release-asan for d6fd5c9 has started.
2024-12-27 13:43:13 UTC Artifacts will be uploaded here
2024-12-27 13:46:01 UTC ya make is running...
🟡 2024-12-27 14:41:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11251 11191 0 28 3 29

2024-12-27 14:42:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 14:52:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 67 0 8 0 26

2024-12-27 14:52:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 15:04:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 37 0 5 0 26

🟢 2024-12-27 15:04:30 UTC Build successful.
🟢 2024-12-27 15:05:00 UTC ydbd size 3.6 GiB changed* by +32.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 654938c merge: d6fd5c9 diff diff %
ydbd size 3 869 478 304 Bytes 3 869 511 144 Bytes +32.1 KiB +0.001%
ydbd stripped size 1 349 128 368 Bytes 1 349 144 944 Bytes +16.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 11:24:32 UTC Pre-commit check linux-x86_64-release-asan for 8b89b36 has started.
2024-12-28 11:25:09 UTC Artifacts will be uploaded here
2024-12-28 11:28:32 UTC ya make is running...
🟡 2024-12-28 12:44:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11254 11200 0 21 4 29

2024-12-28 12:45:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 12:57:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 60 0 7 2 26

2024-12-28 12:57:26 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-28 13:09:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 35 0 2 2 26

🟢 2024-12-28 13:09:13 UTC Build successful.
🟢 2024-12-28 13:09:48 UTC ydbd size 3.6 GiB changed* by +32.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4976af0 merge: 8b89b36 diff diff %
ydbd size 3 870 425 384 Bytes 3 870 458 912 Bytes +32.7 KiB +0.001%
ydbd stripped size 1 349 973 040 Bytes 1 349 989 808 Bytes +16.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 11:28:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b89b36 has started.
2024-12-28 11:28:27 UTC Artifacts will be uploaded here
2024-12-28 11:31:27 UTC ya make is running...
🟡 2024-12-28 12:31:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16972 16557 0 6 277 132

2024-12-28 12:32:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 12:45:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 69 0 1 0 124

2024-12-28 12:45:34 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-28 12:56:52 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 59 0 1 0 120

🟢 2024-12-28 12:57:01 UTC Build successful.
🟢 2024-12-28 12:57:24 UTC ydbd size 2.1 GiB changed* by -191.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dd6b961 merge: 8b89b36 diff diff %
ydbd size 2 242 251 120 Bytes 2 242 054 704 Bytes -191.8 KiB -0.009%
ydbd stripped size 472 136 816 Bytes 472 100 592 Bytes -35.4 KiB -0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 11:48:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5590248 has started.
2025-01-09 11:49:03 UTC Artifacts will be uploaded here
2025-01-09 11:51:51 UTC ya make is running...
🟡 2025-01-09 12:37:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18183 16885 0 7 1169 122

2025-01-09 12:38:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 12:51:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 70 0 2 0 120

2025-01-09 12:51:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-09 13:02:58 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 55 0 2 0 119

🟢 2025-01-09 13:03:08 UTC Build successful.
🟢 2025-01-09 13:03:30 UTC ydbd size 2.1 GiB changed* by +10.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 286332a merge: 5590248 diff diff %
ydbd size 2 244 704 016 Bytes 2 244 715 216 Bytes +10.9 KiB +0.000%
ydbd stripped size 472 407 504 Bytes 472 409 360 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 11:49:15 UTC Pre-commit check linux-x86_64-release-asan for 5590248 has started.
2025-01-09 11:49:19 UTC Artifacts will be uploaded here
2025-01-09 11:52:05 UTC ya make is running...
🟡 2025-01-09 12:48:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11265 11212 0 23 3 27

2025-01-09 12:49:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 13:01:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 60 0 8 2 25

2025-01-09 13:01:55 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-09 13:13:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 30 0 6 1 25

🟢 2025-01-09 13:13:57 UTC Build successful.
🟢 2025-01-09 13:14:26 UTC ydbd size 3.6 GiB changed* by +26.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 286332a merge: 5590248 diff diff %
ydbd size 3 874 446 160 Bytes 3 874 473 296 Bytes +26.5 KiB +0.001%
ydbd stripped size 1 350 832 688 Bytes 1 350 847 152 Bytes +14.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) January 9, 2025 12:37
@adameat adameat self-assigned this Jan 9, 2025
@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Jan 9, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 16:39:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1b79a41 has started.
2025-01-09 16:39:43 UTC Artifacts will be uploaded here
2025-01-09 16:42:32 UTC ya make is running...
🟡 2025-01-09 17:29:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18186 16892 0 4 1169 121

2025-01-09 17:31:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 17:43:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 64 0 1 0 119

2025-01-09 17:43:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-09 18:01:22 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 54 0 1 0 119

🟢 2025-01-09 18:01:41 UTC Build successful.
🟢 2025-01-09 18:02:02 UTC ydbd size 2.1 GiB changed* by +15.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 275b86e merge: 1b79a41 diff diff %
ydbd size 2 244 709 424 Bytes 2 244 724 984 Bytes +15.2 KiB +0.001%
ydbd stripped size 472 409 936 Bytes 472 416 080 Bytes +6.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 16:39:51 UTC Pre-commit check linux-x86_64-release-asan for 1b79a41 has started.
2025-01-09 16:40:03 UTC Artifacts will be uploaded here
2025-01-09 16:42:53 UTC ya make is running...
🟡 2025-01-09 17:42:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11267 11189 0 43 7 28

2025-01-09 17:43:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 18:01:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 94 0 6 4 25

2025-01-09 18:02:05 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-09 18:13:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 33 0 4 0 24

🟢 2025-01-09 18:13:59 UTC Build successful.
🟢 2025-01-09 18:14:30 UTC ydbd size 3.6 GiB changed* by +27.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 14a7b7e merge: 1b79a41 diff diff %
ydbd size 3 874 456 216 Bytes 3 874 483 992 Bytes +27.1 KiB +0.001%
ydbd stripped size 1 350 840 112 Bytes 1 350 854 768 Bytes +14.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Jan 9, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 22:12:05 UTC Pre-commit check linux-x86_64-release-asan for c7010ad has started.
2025-01-09 22:12:27 UTC Artifacts will be uploaded here
2025-01-09 22:15:24 UTC ya make is running...
🟡 2025-01-09 23:10:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11267 11202 0 35 3 27

2025-01-09 23:11:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 23:23:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 74 0 7 1 24

2025-01-09 23:23:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-09 23:35:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 32 0 4 0 24

🟢 2025-01-09 23:35:09 UTC Build successful.
🟢 2025-01-09 23:35:38 UTC ydbd size 3.6 GiB changed* by +19.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 046fc2f merge: c7010ad diff diff %
ydbd size 3 874 667 936 Bytes 3 874 687 584 Bytes +19.2 KiB +0.001%
ydbd stripped size 1 350 937 552 Bytes 1 350 944 080 Bytes +6.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 22:14:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for c7010ad has started.
2025-01-09 22:14:48 UTC Artifacts will be uploaded here
2025-01-09 22:17:45 UTC ya make is running...
🟡 2025-01-09 23:05:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18186 16882 0 7 1169 128

2025-01-09 23:07:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-09 23:19:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 66 0 0 0 119

🟢 2025-01-09 23:19:34 UTC Build successful.
🟢 2025-01-09 23:19:53 UTC ydbd size 2.1 GiB changed* by +15.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 046fc2f merge: c7010ad diff diff %
ydbd size 2 244 801 784 Bytes 2 244 817 344 Bytes +15.2 KiB +0.001%
ydbd stripped size 472 424 080 Bytes 472 430 224 Bytes +6.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit b4275e1 into ydb-platform:main Jan 10, 2025
22 of 24 checks passed
adameat added a commit to adameat/ydb that referenced this pull request Jan 16, 2025
adameat added a commit to adameat/ydb that referenced this pull request Jan 17, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify with olap + olap_workload (12) diagnostics/storage – empty list of nodes for a database
2 participants