Skip to content

Add range read border to key sampler KIKIMR-20859 #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 24, 2024

Changelog entry

Add range read border to key sampler.

Changelog category

  • Improvement

Additional information

Previously range reads that result in zero rows didn't add any keys to the key sampler, and split by load didn't have any access patterns to base split by load decisions on.

Copy link

github-actions bot commented Jan 24, 2024

2024-01-24 09:35:06 UTC Pre-commit check for e1f7eff has started.
2024-01-24 09:35:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 09:37:16 UTC Build successful.
2024-01-24 09:37:28 UTC Tests are running...
🔴 2024-01-24 10:49:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60022 50755 0 17 9232 18

Copy link

github-actions bot commented Jan 24, 2024

2024-01-24 09:35:40 UTC Pre-commit check for e1f7eff has started.
2024-01-24 09:35:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 09:37:47 UTC Build successful.
2024-01-24 09:37:58 UTC Tests are running...
🔴 2024-01-24 11:09:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15917 15815 0 21 49 32

@snaury snaury requested a review from eivanov89 January 24, 2024 09:42
@snaury snaury marked this pull request as ready for review January 24, 2024 09:42
@snaury snaury merged commit 8a21d0e into ydb-platform:main Jan 24, 2024
@snaury snaury deleted the KIKIMR-20859-range-start-in-stats branch January 24, 2024 11:07
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
@vitstn vitstn mentioned this pull request Jan 29, 2024
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants