Skip to content

ci: run pr checks on a merge commit instead of the PR head, add rebase-and-check label support #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2024
Merged

ci: run pr checks on a merge commit instead of the PR head, add rebase-and-check label support #1244

merged 4 commits into from
Jan 24, 2024

Conversation

nikitka
Copy link
Collaborator

@nikitka nikitka commented Jan 23, 2024 •
edited
Loading

Changelog entry

  1. Run PR checks on a merge commit instead of the PR head commit.
  2. Add support for automatic deletion of the rebase-and-check label. This label triggers a new build on the actual merge commit.

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@nikitka nikitka requested a review from alexv-smirnov January 23, 2024 17:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-24 10:12:33 UTC Pre-commit check for 0bb7406 has started.
⚪ 2024-01-24 10:12:35 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-24 10:14:36 UTC Build failed. see the build logs.
⚪ 2024-01-24 10:14:49 UTC Tests are running...
🔴 2024-01-24 10:24:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59816 50550 0 21 9232 13

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-24 10:12:23 UTC Pre-commit check for 0bb7406 has started.
⚪ 2024-01-24 10:12:26 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-24 10:14:38 UTC Build failed. see the build logs.
⚪ 2024-01-24 10:14:50 UTC Tests are running...
🔴 2024-01-24 10:19:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15721 15608 0 40 61 12

@nikitka nikitka force-pushed the ci-pr-merge-commit branch from a990e75 to 136522a Compare January 24, 2024 09:33
@nikitka nikitka merged commit eb06b66 into ydb-platform:main Jan 24, 2024
@nikitka nikitka deleted the ci-pr-merge-commit branch January 24, 2024 10:31
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexv-smirnov alexv-smirnov alexv-smirnov approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitka @alexv-smirnov