Skip to content

Fixing muted SQS tests #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2024
Merged

Fixing muted SQS tests #1234

merged 4 commits into from
Jan 24, 2024

Conversation

@siarheivesialou
Copy link
Contributor

@siarheivesialou siarheivesialou commented Jan 23, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-24 13:06:55 UTC Pre-commit check for bc5ffaf has started.
⚪ 2024-01-24 13:06:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 13:08:01 UTC Build successful.
⚪ 2024-01-24 13:08:10 UTC Tests are running...
🔴 2024-01-24 14:04:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60089 50810 0 13 9235 31

siarheivesialou
siarheivesialou commented Jan 23, 2024
View reviewed changes
ydb/tests/functional/sqs/cloud/test_yandex_cloud_mode.py
# shouldn't get any error
result_list = self._read_single_message_no_wait(queue1_url)
assert len(result_list) == 0 or result_list[0]['Body'] == msg_body
# waiting until the message appears in queue1 again
Copy link
Contributor Author

@siarheivesialou siarheivesialou Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проблема была в том, что self._read_single_message_no_wait(queue1_url) могла прочитать как 1, так и 0 сообщений. Тесть падал, когда вычитвалось 1. Фикс - читать, дожидаясь этого сообщения.

siarheivesialou
siarheivesialou commented Jan 23, 2024
View reviewed changes
ydb/tests/functional/sqs/cloud/test_yandex_cloud_queue_counters.py

self._sqs_api.send_message(queue_url, "bar")
self._sqs_api.purge_queue(queue_url)
for _ in range(20):
Copy link
Contributor Author

@siarheivesialou siarheivesialou Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень редко счётчик успевал упасть до 0. Опытным путём выяснилось, что 20 после таких итераций счётчик будет точно больше 0, а точного значения тут на самом деле и не нужно.

@github-actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-24 13:11:41 UTC Pre-commit check for bc5ffaf has started.
⚪ 2024-01-24 13:11:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 13:12:50 UTC Build successful.
⚪ 2024-01-24 13:16:20 UTC Tests are running...
🔴 2024-01-24 14:19:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15928 15834 0 26 38 30

@CyberROFL
Copy link
Member

CyberROFL commented Jan 24, 2024

rebase please

@siarheivesialou
Copy link
Contributor Author

siarheivesialou commented Jan 24, 2024

rebase please

Rebased, there were no conflicts

@siarheivesialou siarheivesialou merged commit 69d045d into ydb-platform:main Jan 24, 2024
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshestakov nshestakov nshestakov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siarheivesialou @CyberROFL @nshestakov