Skip to content

Conversation

@rekby
Copy link
Member

@rekby rekby commented Dec 3, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:33:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 671513b has started.
2024-12-03 10:33:37 UTC Artifacts will be uploaded here
2024-12-03 10:36:06 UTC ya make is running...
🟢 2024-12-03 10:36:11 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-03 10:36:17 UTC Build successful.
2024-12-03 10:36:20 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:38:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for ea5e370 has started.
2024-12-03 10:38:13 UTC Artifacts will be uploaded here
2024-12-03 10:40:38 UTC ya make is running...
2024-12-03 10:43:30 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:40:02 UTC Pre-commit check linux-x86_64-release-asan for ea5e370 has started.
2024-12-03 10:40:13 UTC Artifacts will be uploaded here
2024-12-03 10:42:41 UTC ya make is running...
2024-12-03 10:43:29 UTC Check cancelled

@rekby rekby force-pushed the 11005-local-kafka-api branch from 49eae52 to 63f9488 Compare December 3, 2024 10:43
@rekby rekby marked this pull request as ready for review December 3, 2024 10:44
@rekby rekby requested a review from maximyurchuk December 3, 2024 10:44
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:44:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 003e981 has started.
2024-12-03 10:44:58 UTC Artifacts will be uploaded here
2024-12-03 10:47:25 UTC ya make is running...
🟡 2024-12-03 11:27:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1780 1761 0 1 17 1

2024-12-03 11:27:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-03 11:28:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 0 0 1

🟢 2024-12-03 11:29:05 UTC Build successful.
🟢 2024-12-03 11:29:16 UTC ydbd size 2.5 GiB changed* by +52.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 73759b6 merge: 003e981 diff diff %
ydbd size 2 692 775 432 Bytes 2 692 829 280 Bytes +52.6 KiB +0.002%
ydbd stripped size 483 543 184 Bytes 483 553 296 Bytes +9.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:47:05 UTC Pre-commit check linux-x86_64-release-asan for 003e981 has started.
2024-12-03 10:47:17 UTC Artifacts will be uploaded here
2024-12-03 10:49:43 UTC ya make is running...
🟡 2024-12-03 11:27:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
364 356 0 1 5 2

🟢 2024-12-03 11:27:44 UTC Build successful.
🟡 2024-12-03 11:27:59 UTC ydbd size 4.9 GiB changed* by +106.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 73759b6 merge: 003e981 diff diff %
ydbd size 5 293 109 376 Bytes 5 293 218 168 Bytes +106.2 KiB +0.002%
ydbd stripped size 1 365 363 600 Bytes 1 365 396 880 Bytes +32.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rekby rekby enabled auto-merge (squash) December 3, 2024 11:55
if _is_env_option_enabled('YDB_KAFKA_API_ENABLED'):
kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT", "9092"))
kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT", "0"))
if kafka_api_port != 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У тебя ошибка фактическая: по дефолту возвращается "0", а сравниваешь с 0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю

    kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT"))
    if kafka_api_port is not None:
        ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

у меня там ещё приведение к int-у есть:

int(os.environ.get("YDB_KAFKA_PROXY_PORT", "0"))

@rekby rekby merged commit 2ab3fa0 into ydb-platform:main Dec 3, 2024
10 checks passed
@rekby rekby deleted the 11005-local-kafka-api branch December 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants