-
Notifications
You must be signed in to change notification settings - Fork 734
use YDB_KAFKA_PROXY_PORT for enable kafka #12242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⚪ Test history | Ya make output | Test bloat
🟢 |
4d7700e to
49eae52
Compare
49eae52 to
63f9488
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if _is_env_option_enabled('YDB_KAFKA_API_ENABLED'): | ||
| kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT", "9092")) | ||
| kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT", "0")) | ||
| if kafka_api_port != 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У тебя ошибка фактическая: по дефолту возвращается "0", а сравниваешь с 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Предлагаю
kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT"))
if kafka_api_port is not None:
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
у меня там ещё приведение к int-у есть:
int(os.environ.get("YDB_KAFKA_PROXY_PORT", "0"))
Changelog entry
...
Changelog category
Additional information
...