Skip to content

fix allow single partition optimization #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

fix single optimization in kqp planner

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Jan 22, 2024

2024-01-22 18:43:47 UTC Pre-commit check for 7e49643 has started.
2024-01-22 18:43:49 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-22 18:46:33 UTC Build failed. see the build logs.
2024-01-22 18:46:46 UTC Tests are running...
🔴 2024-01-22 19:56:08 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60012 50763 0 4 9228 17

Copy link

github-actions bot commented Jan 22, 2024

2024-01-22 18:44:00 UTC Pre-commit check for 7e49643 has started.
2024-01-22 18:44:03 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-22 18:46:50 UTC Build failed. see the build logs.
2024-01-22 18:46:59 UTC Tests are running...
🔴 2024-01-22 20:25:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15914 15792 0 36 66 20

@@ -2205,13 +2205,13 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
}
}

const bool enableOptForTasks = !UnknownAffectedShardCount && !HasExternalSources;
const bool singlePartitionOptAllowed = !UnknownAffectedShardCount && !HasExternalSources && (DatashardTxs.size() == 0);
const bool useDataQueryPool = !(HasExternalSources && DatashardTxs.size() == 0);
const bool localComputeTasks = !((HasExternalSources || HasOlapTable || HasDatashardSourceScan) && DatashardTxs.size() == 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот это условие для меня не очень понятно.

@@ -2205,13 +2205,13 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
}
}

const bool enableOptForTasks = !UnknownAffectedShardCount && !HasExternalSources;
const bool singlePartitionOptAllowed = !UnknownAffectedShardCount && !HasExternalSources && (DatashardTxs.size() == 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не совсем ясно чем тут релевантен HasExternalSources.

@gridnevvvit gridnevvvit merged commit d84a0c9 into ydb-platform:main Jan 23, 2024
@gridnevvvit gridnevvvit deleted the singlePartitionOpt branch January 23, 2024 08:59
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
@vitstn vitstn mentioned this pull request Jan 29, 2024
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants