-
Notifications
You must be signed in to change notification settings - Fork 638
fix allow single partition optimization #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚪
|
⚪
|
@@ -2205,13 +2205,13 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da | |||
} | |||
} | |||
|
|||
const bool enableOptForTasks = !UnknownAffectedShardCount && !HasExternalSources; | |||
const bool singlePartitionOptAllowed = !UnknownAffectedShardCount && !HasExternalSources && (DatashardTxs.size() == 0); | |||
const bool useDataQueryPool = !(HasExternalSources && DatashardTxs.size() == 0); | |||
const bool localComputeTasks = !((HasExternalSources || HasOlapTable || HasDatashardSourceScan) && DatashardTxs.size() == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вот это условие для меня не очень понятно.
@@ -2205,13 +2205,13 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da | |||
} | |||
} | |||
|
|||
const bool enableOptForTasks = !UnknownAffectedShardCount && !HasExternalSources; | |||
const bool singlePartitionOptAllowed = !UnknownAffectedShardCount && !HasExternalSources && (DatashardTxs.size() == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не совсем ясно чем тут релевантен HasExternalSources.
Changelog entry
fix single optimization in kqp planner
Changelog category
Additional information
...