Fix deadlines in DSProxy for Status, MultiPut, Patch requests, add UTs for deadlines #11780
Conversation
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
serbel324
force-pushed
the
bs/dsproxy/more-deadline-uts
branch
from
90f2f80 to
15ea38f
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
serbel324
changed the title
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
serbel324
force-pushed
the
bs/dsproxy/more-deadline-uts
branch
from
3cf7222 to
c4b96cf
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
alexvru
changed the title
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
serbel324
force-pushed
the
bs/dsproxy/more-deadline-uts
branch
from
2d003d6 to
3416d09
Compare
serbel324
force-pushed
the
bs/dsproxy/more-deadline-uts
branch
from
3416d09 to
b3ecf6a
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
| TBatchedVec<TStackVec<TRope, TypicalPartsInBlob>> PartSets; | ||
|
|
||
| static_assert(MaxBatchedPutRequests <= sizeof(ui64) * 8); | ||
| std::map<TInstant, ui64> PutDeadlineMasks; |
There was a problem hiding this comment.
https://en.cppreference.com/w/cpp/utility/bitset
| std::map<TInstant, ui64> PutDeadlineMasks; | |
| std::map<TInstant, std::bitset<MaxBatchedPutRequests>> PutDeadlineMasks; |
There was a problem hiding this comment.
please, don't add new asserts unless necessary
| template<class Tag> | ||
| void Test(const TBlobStorageGroupType&) {} | ||
|
|
||
| struct TTagPut {}; |
There was a problem hiding this comment.
What are these Tags supposed to be used for?
You can create functions with the same naming system as well and get rid of the third(!) request type list of in this file
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ui32 NodeCount; | ||
| TBlobStorageGroupType Erasure; | ||
| std::shared_ptr<TEnvironmentSetup> Env; | ||
| std::shared_ptr<TEnvironmentSetup> Env = nullptr; |
There was a problem hiding this comment.
| std::shared_ptr<TEnvironmentSetup> Env = nullptr; | |
| std::shared_ptr<TEnvironmentSetup> Env; |
| TActorId Edge; | ||
| TDuration VDiskDelay; | ||
| std::shared_ptr<TVDiskDelayEmulator> VDiskDelayEmulator; | ||
| std::shared_ptr<TVDiskDelayEmulator> VDiskDelayEmulator = nullptr; |
There was a problem hiding this comment.
| std::shared_ptr<TVDiskDelayEmulator> VDiskDelayEmulator = nullptr; | |
| std::shared_ptr<TVDiskDelayEmulator> VDiskDelayEmulator; |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…, add UTs for deadlines (ydb-platform#11780)" This reverts commit 7f6d8cc.
3 participants
Changelog entry
Add UT for restore and index Get request deadlines
Changelog category
Additional information
...