Skip to content

Fix set but unused varibles to fix -Wunused-but-set-variable #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix set but unused varibles to fix -Wunused-but-set-variable #1175

merged 2 commits into from
Jan 23, 2024

Conversation

dzen03
Copy link
Contributor

@dzen03 dzen03 commented Jan 19, 2024

When compiling with -Wunused-but-set-variable there are some warnings (errors) in YDB. To be able to compile with -Wunused-but-set-variable in the near future we should fix those warnings

@github-actions GitHub Actions
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@hdnpth hdnpth requested a review from alexv-smirnov January 22, 2024 11:06
@alexv-smirnov alexv-smirnov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Jan 23, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Jan 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-23 14:47:19 UTC Pre-commit check for f63bca9 has started.
⚪ 2024-01-23 14:47:21 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-23 14:50:08 UTC Build failed. see the build logs.
⚪ 2024-01-23 14:50:18 UTC Tests are running...
🔴 2024-01-23 16:26:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59810 50555 0 10 9231 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-23 14:52:56 UTC Pre-commit check for f63bca9 has started.
⚪ 2024-01-23 14:52:59 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-23 14:55:40 UTC Build failed. see the build logs.
⚪ 2024-01-23 14:55:50 UTC Tests are running...
🔴 2024-01-23 16:37:02 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15713 15623 0 22 60 8

@dcherednik
Copy link
Member

Could you please rebase on the latest main. Build is broken in your pr due to build issue not related to you changes. The issue is fixed now.

@alexv-smirnov alexv-smirnov enabled auto-merge (squash) January 23, 2024 15:37
@alexv-smirnov alexv-smirnov merged commit 0d6bce5 into ydb-platform:main Jan 23, 2024
vitstn
vitstn reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@vitstn vitstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn left review comments

@dcherednik dcherednik dcherednik approved these changes

@alexv-smirnov alexv-smirnov alexv-smirnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzen03 @dcherednik @vitstn @alexv-smirnov