Skip to content

Add more information to VERIFY message, YDBREQUESTS-2898 #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add more information to VERIFY message, YDBREQUESTS-2898 #1155

merged 2 commits into from
Jan 22, 2024

Conversation

serbel324
Copy link
Collaborator

No description provided.

@serbel324 serbel324 force-pushed the bs/nodewarden/YDBREQUESTS-2898 branch from 35eb4ef to f045544 Compare January 19, 2024 12:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

⚪ 2024-01-22 12:32:34 UTC Pre-commit check for 2399bc0 has started.
⚪ 2024-01-22 12:32:37 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-22 12:36:06 UTC Build failed. see the build logs.
⚪ 2024-01-22 12:36:19 UTC Tests are running...
🔴 2024-01-22 14:41:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15918 12451 0 2421 383 663

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

⚪ 2024-01-22 12:32:22 UTC Pre-commit check for 2399bc0 has started.
⚪ 2024-01-22 12:32:25 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-22 12:35:03 UTC Build failed. see the build logs.
⚪ 2024-01-22 12:35:19 UTC Tests are running...
🔴 2024-01-22 14:29:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60045 47148 0 2632 9599 666

kruall
kruall previously approved these changes Jan 19, 2024
View reviewed changes
nshestakov
nshestakov reviewed Jan 19, 2024
View reviewed changes
ydb/core/blobstorage/nodewarden/group_stat_aggregator.h Outdated
@@ -50,7 +52,14 @@ namespace NKikimr {
Y_ABORT_UNLESS(vdiskServiceId.IsService());
char x[12];
TStringBuf serviceId = vdiskServiceId.ServiceId();
Y_ABORT_UNLESS(serviceId[0] == 'b' && serviceId[1] == 's' && serviceId[2] == 'v' && serviceId[3] == 'd');
if (serviceId[0] != 'b' || serviceId[1] != 's' || serviceId[2] != 'v' || serviceId[3] != 'd') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO было бы читабельней написать так

Y_ABORT_UNLESS(serviceId[0] == 'b' && serviceId[1] == 's' && serviceId[2] == 'v' && serviceId[3] == 'd', "Invalid VDisk's ServiceId# %s", formatServiceId(serviceId))

а цикл унести в функцию FormatServiceId

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Покопался в утиле, нашел функцию HexEncode, она примерно то же самое делает.

alexvru
alexvru previously approved these changes Jan 22, 2024
View reviewed changes
@serbel324 serbel324 dismissed stale reviews from alexvru and kruall via fe3e6bb January 22, 2024 12:29
@serbel324 serbel324 force-pushed the bs/nodewarden/YDBREQUESTS-2898 branch from fe3e6bb to 2399bc0 Compare January 22, 2024 12:31
@serbel324 serbel324 merged commit 2a760a1 into ydb-platform:main Jan 22, 2024
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshestakov nshestakov nshestakov left review comments

@alexvru alexvru alexvru approved these changes

@kruall kruall kruall left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serbel324 @nshestakov @kruall @alexvru