Skip to content

Use GraceJoinCore instead of MapJoinCore #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 15, 2024
Merged

Use GraceJoinCore instead of MapJoinCore #11537

merged 9 commits into from
Nov 15, 2024

Conversation

@Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Nov 12, 2024

No description provided.

@Hor911 Hor911 requested a review from a team as a code owner November 12, 2024 15:34
@github-actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 15:38:23 UTC Pre-commit check for 7ca40f2 has started.
⚪ 2024-11-12 15:41:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-12 15:59:24 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 15:38:33 UTC Pre-commit check for 7ca40f2 has started.
⚪ 2024-11-12 15:41:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-12 16:29:33 UTC Build successful.
⚪ 2024-11-12 16:29:49 UTC Tests are running...
🔴 2024-11-12 18:42:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73556 60058 0 24 13434 40

🟡 2024-11-12 18:43:25 UTC ydbd size 8.3 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: afbd118 merge: 7ca40f2 diff diff %
ydbd size 8 858 816 656 Bytes 8 860 038 848 Bytes +1.2 MiB +0.014%
ydbd stripped size 483 705 224 Bytes 483 771 528 Bytes +64.8 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 15:38:35 UTC Pre-commit check for 7ca40f2 has started.
⚪ 2024-11-12 15:41:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-12 16:12:30 UTC Build successful.
⚪ 2024-11-12 16:12:44 UTC Tests are running...
🔴 2024-11-12 18:22:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12463 12332 0 39 48 44

🟡 2024-11-12 18:23:31 UTC ydbd size 5.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: afbd118 merge: 7ca40f2 diff diff %
ydbd size 5 991 968 752 Bytes 5 993 078 720 Bytes +1.1 MiB +0.019%
ydbd stripped size 1 501 736 064 Bytes 1 502 023 072 Bytes +280.3 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 16:23:09 UTC Pre-commit check for ba87cdb has started.
⚪ 2024-11-13 16:26:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-13 16:53:20 UTC Build successful.
⚪ 2024-11-13 16:53:37 UTC Tests are running...
🔴 2024-11-13 19:08:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12472 12337 0 41 52 42

🟡 2024-11-13 19:09:44 UTC ydbd size 5.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 063dc25 merge: ba87cdb diff diff %
ydbd size 5 992 962 544 Bytes 5 994 068 408 Bytes +1.1 MiB +0.018%
ydbd stripped size 1 501 944 672 Bytes 1 502 227 584 Bytes +276.3 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 16:23:29 UTC Pre-commit check for ba87cdb has started.
⚪ 2024-11-13 16:26:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-13 17:11:31 UTC Build successful.
⚪ 2024-11-13 17:11:55 UTC Tests are running...
🔴 2024-11-13 19:24:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73565 60081 0 14 13432 38

🟡 2024-11-13 19:25:16 UTC ydbd size 8.3 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 063dc25 merge: ba87cdb diff diff %
ydbd size 8 860 677 120 Bytes 8 861 899 296 Bytes +1.2 MiB +0.014%
ydbd stripped size 483 744 904 Bytes 483 811 208 Bytes +64.8 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 16:25:42 UTC Pre-commit check for ba87cdb has started.
⚪ 2024-11-13 16:28:21 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-13 17:09:55 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 23:29:03 UTC Pre-commit check for 3013bd5 has started.
⚪ 2024-11-13 23:31:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-13 23:39:12 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 23:29:28 UTC Pre-commit check for 3013bd5 has started.
⚪ 2024-11-13 23:32:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-14 00:13:51 UTC Build successful.
⚪ 2024-11-14 00:14:07 UTC Tests are running...
🔴 2024-11-14 02:24:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73564 60080 0 10 13435 39

🟡 2024-11-14 02:25:37 UTC ydbd size 8.3 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 063dc25 merge: 3013bd5 diff diff %
ydbd size 8 860 677 120 Bytes 8 861 899 296 Bytes +1.2 MiB +0.014%
ydbd stripped size 483 744 904 Bytes 483 811 208 Bytes +64.8 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 23:31:35 UTC Pre-commit check for 3013bd5 has started.
⚪ 2024-11-13 23:34:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-13 23:58:30 UTC Build successful.
⚪ 2024-11-14 00:01:08 UTC Tests are running...
🔴 2024-11-14 02:09:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12471 12344 0 36 52 39

🟡 2024-11-14 02:10:12 UTC ydbd size 5.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 063dc25 merge: 3013bd5 diff diff %
ydbd size 5 992 962 544 Bytes 5 994 068 408 Bytes +1.1 MiB +0.018%
ydbd stripped size 1 501 944 672 Bytes 1 502 227 584 Bytes +276.3 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 added the rebase-and-check Rebase PR with the current base branch and check label Nov 15, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 15, 2024
@github-actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 08:12:05 UTC Pre-commit check for f3a198d has started.
⚪ 2024-11-15 08:14:45 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-15 08:26:22 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 08:12:56 UTC Pre-commit check for f3a198d has started.
⚪ 2024-11-15 08:15:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-15 08:43:27 UTC Build successful.
⚪ 2024-11-15 08:43:48 UTC Tests are running...
🔴 2024-11-15 10:58:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12474 12335 0 44 50 45

🟡 2024-11-15 10:59:37 UTC ydbd size 5.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: cb324c9 merge: f3a198d diff diff %
ydbd size 5 994 161 184 Bytes 5 995 271 144 Bytes +1.1 MiB +0.019%
ydbd stripped size 1 502 406 624 Bytes 1 502 693 632 Bytes +280.3 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 08:13:12 UTC Pre-commit check for f3a198d has started.
⚪ 2024-11-15 08:15:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-15 09:01:21 UTC Build successful.
⚪ 2024-11-15 09:01:37 UTC Tests are running...
🔴 2024-11-15 11:11:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73566 60082 0 13 13432 39

🟡 2024-11-15 11:12:21 UTC ydbd size 8.3 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: cb324c9 merge: f3a198d diff diff %
ydbd size 8 862 043 752 Bytes 8 863 265 992 Bytes +1.2 MiB +0.014%
ydbd stripped size 483 862 056 Bytes 483 928 424 Bytes +64.8 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 merged commit ee21311 into ydb-platform:stable-24-3 Nov 15, 2024
11 of 17 checks passed
This was referenced Jun 3, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hor911 @fomichev3000