Skip to content

ensure reads are sequential (#11280) #11317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ssmike
Copy link
Collaborator

@ssmike ssmike commented Nov 6, 2024

Changelog entry

Prefer only sequential reads in secondary indices chooser

Changelog category

  • Bugfix

@ssmike ssmike requested a review from a team as a code owner November 6, 2024 11:27
Copy link

github-actions bot commented Nov 6, 2024

2024-11-06 11:28:34 UTC Pre-commit check for 47eb490 has started.
2024-11-06 11:31:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-06 12:11:24 UTC Build successful.
2024-11-06 12:20:42 UTC Tests are running...
🔴 2024-11-06 13:52:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14390 13031 0 15 1302 42

🟢 2024-11-06 13:53:31 UTC ydbd size 8.2 GiB changed* by +32.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 00669fd merge: 47eb490 diff diff %
ydbd size 8 857 967 504 Bytes 8 858 000 840 Bytes +32.6 KiB +0.000%
ydbd stripped size 483 659 304 Bytes 483 661 032 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ssmike
Copy link
Collaborator Author

ssmike commented Nov 6, 2024

#11253 related

Copy link

github-actions bot commented Nov 6, 2024

2024-11-06 11:30:40 UTC Pre-commit check for 47eb490 has started.
2024-11-06 11:33:42 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-06 12:12:55 UTC Build successful.

Copy link

github-actions bot commented Nov 6, 2024

2024-11-06 11:31:33 UTC Pre-commit check for 47eb490 has started.
2024-11-06 11:34:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-06 11:56:18 UTC Build successful.
2024-11-06 11:56:34 UTC Tests are running...
🔴 2024-11-06 14:01:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10242 10149 0 24 28 41

🟢 2024-11-06 14:02:19 UTC ydbd size 5.6 GiB changed* by +54.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 00669fd merge: 47eb490 diff diff %
ydbd size 5 991 007 136 Bytes 5 991 062 936 Bytes +54.5 KiB +0.001%
ydbd stripped size 1 501 529 600 Bytes 1 501 539 168 Bytes +9.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ssmike ssmike enabled auto-merge (squash) November 6, 2024 12:36
@gridnevvvit gridnevvvit self-requested a review November 6, 2024 14:02
@ssmike ssmike merged commit 4d45fe1 into ydb-platform:stable-24-3 Nov 6, 2024
8 of 12 checks passed
@ssmike ssmike deleted the fix-24-3 branch November 6, 2024 14:07
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants