Skip to content

streamlookup join: add lru size monitoring #11303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

streamlookup join: add lru size monitoring #11303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98b05b7
streamlookup join: add lru size monitoring
yumkam Nov 6, 2024
1587573
shorten counter name
yumkam Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class TInputTransformStreamLookupBase
, MaxDelayedRows(maxDelayedRows)
, CacheTtl(cacheTtl)
, ReadyQueue(OutputRowType)
, LastLruSize(0)
{
Y_ABORT_UNLESS(Alloc);
for (size_t i = 0; i != LookupInputIndexes.size(); ++i) {
Expand Down Expand Up @@ -172,11 +173,14 @@ class TInputTransformStreamLookupBase
LruCache->Update(NUdf::TUnboxedValue(const_cast<NUdf::TUnboxedValue&&>(k)), std::move(v), now + CacheTtl);
}
KeysForLookup->clear();
auto deltaLruSize = (i64)LruCache->Size() - LastLruSize;
auto deltaTime = GetCpuTimeDelta(startCycleCount);
CpuTime += deltaTime;
if (CpuTimeUs) {
LruSize->Add(deltaLruSize); // Note: there can be several streamlookup tied to same counter, so Add instead of Set
CpuTimeUs->Add(deltaTime.MicroSeconds());
}
LastLruSize += deltaLruSize;
Send(ComputeActorId, new TEvNewAsyncInputDataArrived{InputIndex});
}

Expand All @@ -200,6 +204,10 @@ class TInputTransformStreamLookupBase
}

void Free() {
if (LruSize && LastLruSize) {
LruSize->Add(-LastLruSize);
LastLruSize = 0;
}
auto guard = BindAllocator();
//All resources, held by this class, that have been created with mkql allocator, must be deallocated here
KeysForLookup.reset();
Expand Down Expand Up @@ -290,6 +298,7 @@ class TInputTransformStreamLookupBase
auto component = taskCounters->GetSubgroup("component", "Lookup");
LruHits = component->GetCounter("Hits");
Copy link
Collaborator

@uzhastik uzhastik Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в моем понимании тут два сенсора должны быть deriv и один non deriv

LruMiss = component->GetCounter("Miss");
LruSize = component->GetCounter("Size");
CpuTimeUs = component->GetCounter("CpuUs");
Batches = component->GetCounter("Batches");
}
Expand Down Expand Up @@ -358,9 +367,11 @@ class TInputTransformStreamLookupBase
NKikimr::NMiniKQL::TUnboxedValueBatch ReadyQueue;
NYql::NDq::TDqAsyncStats IngressStats;
std::shared_ptr<IDqAsyncLookupSource::TUnboxedValueMap> KeysForLookup;
i64 LastLruSize;

::NMonitoring::TDynamicCounters::TCounterPtr LruHits;
::NMonitoring::TDynamicCounters::TCounterPtr LruMiss;
::NMonitoring::TDynamicCounters::TCounterPtr LruSize;
::NMonitoring::TDynamicCounters::TCounterPtr CpuTimeUs;
::NMonitoring::TDynamicCounters::TCounterPtr Batches;
TDuration CpuTime;
Expand Down
Loading