Skip to content

Fix flow control in run script actor #11241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

Control memory consumption in run script actor.
Unify memory consumption in execute query RPC and run script actor

Changelog category

  • Bugfix

Additional information

...

@github-actions github-actions bot added the bugfix label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

2024-11-04 08:39:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7cb2000 has started.
2024-11-04 08:40:05 UTC Artifacts will be uploaded here
2024-11-04 08:43:10 UTC ya make is running...
🟡 2024-11-04 09:33:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15304 13799 0 4 1404 97

2024-11-04 09:34:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-04 09:46:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 7 0 0 1 93

🟢 2024-11-04 09:46:28 UTC Build successful.
🟢 2024-11-04 09:46:49 UTC ydbd size 2.8 GiB changed* by -20.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d354357 merge: 7cb2000 diff diff %
ydbd size 3 038 072 456 Bytes 3 038 051 384 Bytes -20.6 KiB -0.001%
ydbd stripped size 481 429 176 Bytes 481 424 760 Bytes -4.3 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 4, 2024

2024-11-04 08:39:54 UTC Pre-commit check linux-x86_64-release-asan for 7cb2000 has started.
2024-11-04 08:40:05 UTC Artifacts will be uploaded here
2024-11-04 08:43:08 UTC ya make is running...
🟡 2024-11-04 09:48:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9245 9157 0 48 10 30

🟢 2024-11-04 09:49:08 UTC Build successful.
🟢 2024-11-04 09:49:39 UTC ydbd size 5.7 GiB changed* by -24.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d354357 merge: 7cb2000 diff diff %
ydbd size 6 147 342 800 Bytes 6 147 317 776 Bytes -24.4 KiB -0.000%
ydbd stripped size 1 534 493 616 Bytes 1 534 488 624 Bytes -4.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

GrigoriyPA
GrigoriyPA previously approved these changes Nov 6, 2024
@GrigoriyPA GrigoriyPA self-requested a review November 6, 2024 11:58
Copy link

github-actions bot commented Nov 7, 2024

2024-11-07 09:18:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0e6f635 has started.
2024-11-07 09:18:43 UTC Artifacts will be uploaded here
2024-11-07 09:21:55 UTC ya make is running...
🟢 2024-11-07 10:10:53 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15322 13819 0 0 1404 99

🟢 2024-11-07 10:12:10 UTC Build successful.
🟢 2024-11-07 10:12:29 UTC ydbd size 2.8 GiB changed* by -20.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd7ceac merge: 0e6f635 diff diff %
ydbd size 3 045 156 984 Bytes 3 045 136 288 Bytes -20.2 KiB -0.001%
ydbd stripped size 481 969 976 Bytes 481 965 752 Bytes -4.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 7, 2024

2024-11-07 09:18:44 UTC Pre-commit check linux-x86_64-release-asan for 0e6f635 has started.
2024-11-07 09:18:54 UTC Artifacts will be uploaded here
2024-11-07 09:22:01 UTC ya make is running...
🟡 2024-11-07 10:31:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9256 9169 0 37 15 35

🟢 2024-11-07 10:32:20 UTC Build successful.
🟢 2024-11-07 10:32:53 UTC ydbd size 5.7 GiB changed* by -24.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd7ceac merge: 0e6f635 diff diff %
ydbd size 6 162 296 552 Bytes 6 162 271 800 Bytes -24.2 KiB -0.000%
ydbd stripped size 1 536 570 768 Bytes 1 536 565 712 Bytes -4.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit 27f35fa into ydb-platform:main Nov 7, 2024
10 checks passed
@UgnineSirdis UgnineSirdis deleted the fix-execute-script-memory-control branch November 7, 2024 10:48
gridnevvvit pushed a commit to gridnevvvit/ydb that referenced this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants