Skip to content

Fixed parsing decimals from string #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2024
Merged

Fixed parsing decimals from string #11017

merged 5 commits into from
Oct 29, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Oct 28, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@vitstn vitstn requested a review from a team as a code owner October 28, 2024 18:14
@vitstn vitstn added the area/yql YQL query language issues label Oct 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

⚪ 2024-10-28 18:18:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 609a66f has started.
⚪ 2024-10-28 18:18:21 UTC Artifacts will be uploaded here
⚪ 2024-10-28 18:21:39 UTC ya make is running...
🟡 2024-10-28 19:27:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79637 65585 0 1 13952 99

⚪ 2024-10-28 19:34:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-28 19:46:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 6 0 0 1 93

🟢 2024-10-28 19:46:43 UTC Build successful.
🟢 2024-10-28 19:47:02 UTC ydbd size 2.8 GiB changed* by +208 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 634dc20 merge: 609a66f diff diff %
ydbd size 3 033 916 896 Bytes 3 033 917 104 Bytes +208 Bytes +0.000%
ydbd stripped size 480 681 240 Bytes 480 681 368 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

⚪ 2024-10-28 18:18:16 UTC Pre-commit check linux-x86_64-release-asan for 609a66f has started.
⚪ 2024-10-28 18:18:27 UTC Artifacts will be uploaded here
⚪ 2024-10-28 18:21:41 UTC ya make is running...
🟡 2024-10-28 19:40:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15687 15447 0 54 88 98

🟢 2024-10-28 19:41:42 UTC Build successful.
🟢 2024-10-28 19:42:16 UTC ydbd size 5.7 GiB changed* by +208 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 634dc20 merge: 609a66f diff diff %
ydbd size 6 139 711 072 Bytes 6 139 711 280 Bytes +208 Bytes +0.000%
ydbd stripped size 1 532 097 520 Bytes 1 532 097 648 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

rvu1024
rvu1024 previously approved these changes Oct 29, 2024
View reviewed changes
@vitstn vitstn requested a review from rvu1024 October 29, 2024 08:56
@vitstn vitstn enabled auto-merge (squash) October 29, 2024 08:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:01:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for c36baf9 has started.
⚪ 2024-10-29 09:01:41 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:04:50 UTC ya make is running...
⚫ 2024-10-29 09:10:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:01:47 UTC Pre-commit check linux-x86_64-release-asan for c36baf9 has started.
⚪ 2024-10-29 09:01:59 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:05:07 UTC ya make is running...
⚫ 2024-10-29 09:10:11 UTC Check cancelled

igormunkin
igormunkin previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the fix! LGTM.

@vitstn vitstn requested a review from igormunkin October 29, 2024 09:10
rvu1024
rvu1024 previously approved these changes Oct 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:12:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 32cacbd has started.
⚪ 2024-10-29 09:12:26 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:15:34 UTC ya make is running...
⚫ 2024-10-29 09:37:29 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:13:56 UTC Pre-commit check linux-x86_64-release-asan for 32cacbd has started.
⚪ 2024-10-29 09:14:10 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:17:21 UTC ya make is running...
⚫ 2024-10-29 09:37:45 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:39:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for ede8d13 has started.
⚪ 2024-10-29 09:39:17 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:42:21 UTC ya make is running...
⚫ 2024-10-29 09:48:30 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:39:41 UTC Pre-commit check linux-x86_64-release-asan for ede8d13 has started.
⚪ 2024-10-29 09:39:47 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:43:02 UTC ya make is running...
⚫ 2024-10-29 09:48:33 UTC Check cancelled

igormunkin
igormunkin previously approved these changes Oct 29, 2024
View reviewed changes
@vitstn vitstn requested review from igormunkin and rvu1024 October 29, 2024 09:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:56:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 96d5ed2 has started.
⚪ 2024-10-29 09:56:19 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:59:25 UTC ya make is running...
🟡 2024-10-29 11:04:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79643 65464 0 11 14057 111

⚪ 2024-10-29 11:12:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-29 11:23:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 124 0 0 1 97

🟢 2024-10-29 11:23:58 UTC Build successful.
🟢 2024-10-29 11:24:19 UTC ydbd size 2.8 GiB changed* by +4.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0a19242 merge: 96d5ed2 diff diff %
ydbd size 3 033 926 520 Bytes 3 033 931 512 Bytes +4.9 KiB +0.000%
ydbd stripped size 480 682 584 Bytes 480 686 808 Bytes +4.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 09:56:36 UTC Pre-commit check linux-x86_64-release-asan for 96d5ed2 has started.
⚪ 2024-10-29 09:56:46 UTC Artifacts will be uploaded here
⚪ 2024-10-29 09:59:53 UTC ya make is running...
🟡 2024-10-29 11:19:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15454 15300 0 42 82 30

🟢 2024-10-29 11:20:50 UTC Build successful.
🟢 2024-10-29 11:21:21 UTC ydbd size 5.7 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0a19242 merge: 96d5ed2 diff diff %
ydbd size 6 139 726 256 Bytes 6 139 733 920 Bytes +7.5 KiB +0.000%
ydbd stripped size 1 532 102 192 Bytes 1 532 107 440 Bytes +5.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn merged commit 1dd898c into ydb-platform:main Oct 29, 2024
10 checks passed
@vitstn vitstn deleted the fix_decimal_from_str branch October 29, 2024 11:24
vitstn added a commit to vitstn/ydb that referenced this pull request Oct 29, 2024
@vitstn
Fixed parsing decimals from string (ydb-platform#11017)
6629a3f
vitstn added a commit that referenced this pull request Oct 29, 2024
@vitstn
Backport #11017 (#11049)
29c3e3c
spuchin pushed a commit to spuchin/ydb that referenced this pull request Nov 1, 2024
@vitstn @spuchin
Fixed parsing decimals from string (ydb-platform#11017)
15ce533
spuchin added a commit that referenced this pull request Nov 1, 2024
@spuchin @vitstn
Fixed parsing decimals from string (#11017) (#11188)
cc3d9d3 
Co-authored-by: Vitaly Stoyan <vvvv@ydb.tech>
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 1, 2024
Open
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Nov 2, 2024
@spuchin @vitstn @azevaykin
Fixed parsing decimals from string (ydb-platform#11017) (ydb-platform…
1ba5182 
…#11188)

Co-authored-by: Vitaly Stoyan <vvvv@ydb.tech>
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 7, 2024
Merged
@shnikd shnikd mentioned this pull request Nov 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Nov 8, 2024
@spuchin @vitstn @uzhastik
Fixed parsing decimals from string (ydb-platform#11017) (ydb-platform…
e54af03 
…#11188)

Co-authored-by: Vitaly Stoyan <vvvv@ydb.tech>
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 13, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igormunkin igormunkin igormunkin approved these changes

@rvu1024 rvu1024 Awaiting requested review from rvu1024

Assignees
No one assigned
Labels
area/yql YQL query language issues bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitstn @igormunkin @rvu1024