Skip to content

[CBO] Merge transitive closure + cycles fixes in DPHyp #10857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 25, 2024
Merged

[CBO] Merge transitive closure + cycles fixes in DPHyp #10857

merged 7 commits into from
Oct 25, 2024

Conversation

pashandor789
Copy link
Collaborator

@pashandor789 pashandor789 commented Oct 24, 2024 •
edited
Loading

Improved transitive closure feature for CBO in join hypergraph building
Added cycles processing and cycles into DPHyp algorithm in the CBO

@pashandor789 pashandor789 requested a review from a team as a code owner October 24, 2024 15:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 15:37:54 UTC Pre-commit check for 138e547 has started.
⚪ 2024-10-24 15:40:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-24 16:24:47 UTC Build successful.
⚪ 2024-10-24 16:25:03 UTC Tests are running...
🔴 2024-10-24 18:36:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76528 63038 0 15 13434 41

🔴 2024-10-24 18:37:25 UTC ydbd size 8.2 GiB changed* by +2.5 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 93f64f6 merge: 138e547 diff diff %
ydbd size 8 852 157 144 Bytes 8 854 784 192 Bytes +2.5 MiB +0.030%
ydbd stripped size 483 371 016 Bytes 483 519 432 Bytes +144.9 KiB +0.031%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 15:37:58 UTC Pre-commit check for 138e547 has started.
⚪ 2024-10-24 15:41:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-24 15:50:51 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 15:37:59 UTC Pre-commit check for 138e547 has started.
⚪ 2024-10-24 15:40:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-24 16:08:02 UTC Build successful.
⚪ 2024-10-24 16:08:18 UTC Tests are running...
🔴 2024-10-24 18:17:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15433 15305 0 34 51 43

🔴 2024-10-24 18:18:13 UTC ydbd size 5.6 GiB changed* by +2.2 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 93f64f6 merge: 138e547 diff diff %
ydbd size 5 986 600 416 Bytes 5 988 929 504 Bytes +2.2 MiB +0.039%
ydbd stripped size 1 500 709 888 Bytes 1 501 114 848 Bytes +395.5 KiB +0.027%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pashandor789 pashandor789 merged commit 5ef387d into ydb-platform:stable-24-3 Oct 25, 2024
20 of 30 checks passed
nikvas0 pushed a commit to nikvas0/ydb that referenced this pull request Oct 25, 2024
@pashandor789 @yumkam
@pavelvelikhov @nikvas0
[CBO] Merge transitive closure + cycles fixes in DPHyp (ydb-platform…
6655b3e 
…#10857)

Co-authored-by: yumkam <yumkam7@ydb.tech>
Co-authored-by: Pavel Velikhov <pavelvelikhov@ydb.tech>
Co-authored-by: Pavel Ivanov <pudge1000-7@qavm-9f0570a4.qemu>
@StekPerepolnen StekPerepolnen mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pashandor789 @fomichev3000 @yumkam @pavelvelikhov