Skip to content

fix use after free on follower deletion #10850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix use after free on follower deletion #10850

merged 1 commit into from
Oct 24, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

fix use after free on follower deletion

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@vporyadke vporyadke requested a review from a team as a code owner October 24, 2024 14:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 14:43:47 UTC Pre-commit check for 5891d70 has started.
⚪ 2024-10-24 14:46:32 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-24 15:07:03 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 14:44:06 UTC Pre-commit check for 5891d70 has started.
⚪ 2024-10-24 14:46:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-24 15:29:24 UTC Build successful.
⚪ 2024-10-24 15:29:41 UTC Tests are running...
🔴 2024-10-24 16:55:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14560 13204 0 13 1300 43

🟢 2024-10-24 16:55:59 UTC ydbd size 8.2 GiB changed* by -32 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 93f64f6 merge: 5891d70 diff diff %
ydbd size 8 852 157 144 Bytes 8 852 157 112 Bytes -32 Bytes -0.000%
ydbd stripped size 483 371 016 Bytes 483 371 016 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 14:44:23 UTC Pre-commit check for 5891d70 has started.
⚪ 2024-10-24 14:46:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-24 15:10:35 UTC Build successful.
⚪ 2024-10-24 15:10:50 UTC Tests are running...
🔴 2024-10-24 17:17:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10261 10169 0 19 28 45

🟢 2024-10-24 17:17:55 UTC ydbd size 5.6 GiB changed* by -160 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 93f64f6 merge: 5891d70 diff diff %
ydbd size 5 986 600 416 Bytes 5 986 600 256 Bytes -160 Bytes -0.000%
ydbd stripped size 1 500 709 888 Bytes 1 500 709 760 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke added the rebase-and-check Rebase PR with the current base branch and check label Oct 24, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 18:13:35 UTC Pre-commit check for 5891d70 has started.
⚪ 2024-10-24 18:16:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-24 18:21:37 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 18:13:50 UTC Pre-commit check for 5891d70 has started.
⚪ 2024-10-24 18:16:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-24 18:40:29 UTC Build successful.
⚪ 2024-10-24 18:40:46 UTC Tests are running...
🔴 2024-10-24 20:50:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10260 10172 0 19 25 44

🟢 2024-10-24 20:50:52 UTC ydbd size 5.6 GiB changed* by -160 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 93f64f6 merge: 5891d70 diff diff %
ydbd size 5 986 600 416 Bytes 5 986 600 256 Bytes -160 Bytes -0.000%
ydbd stripped size 1 500 709 888 Bytes 1 500 709 760 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 18:13:50 UTC Pre-commit check for 5891d70 has started.
⚪ 2024-10-24 18:16:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-24 18:56:00 UTC Build successful.
⚪ 2024-10-24 18:56:14 UTC Tests are running...
🔴 2024-10-24 20:19:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14560 13206 0 12 1300 42

🟢 2024-10-24 20:20:36 UTC ydbd size 8.2 GiB changed* by -32 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 93f64f6 merge: 5891d70 diff diff %
ydbd size 8 852 157 144 Bytes 8 852 157 112 Bytes -32 Bytes -0.000%
ydbd stripped size 483 371 016 Bytes 483 371 016 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke merged commit 8d0968e into ydb-platform:stable-24-3 Oct 24, 2024
14 of 23 checks passed
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 24, 2024
@vporyadke @uzhastik
fix use after free on follower deletion (ydb-platform#10850)
fbead47
@vporyadke vporyadke self-assigned this Oct 28, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request Oct 29, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

@vporyadke vporyadke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vporyadke @fomichev3000