Skip to content

24-3: Stop writing indexImplTables' split boundaries to backups #10680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Oct 21, 2024

Ticket:

Do not request indexImplTable partitioning info for a backup. This would prevent indexImplTables' split boundaries from being written to the backup.

to avoid verify in schemeshard on Decimal key columns in indexImplTables
@jepett0 jepett0 changed the title 24-3 hotfix: Stop writing indexImplTables' split boundaries to backups 24-3: Stop writing indexImplTables' split boundaries to backups Oct 21, 2024
@jepett0 jepett0 marked this pull request as ready for review October 21, 2024 16:25
@jepett0 jepett0 requested a review from a team as a code owner October 21, 2024 16:25
Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 16:27:53 UTC Pre-commit check for 75284c4 has started.
2024-10-21 16:30:25 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-21 16:36:37 UTC Build successful.

Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 16:27:59 UTC Pre-commit check for 75284c4 has started.
2024-10-21 16:30:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-21 17:09:39 UTC Build successful.
2024-10-21 17:09:54 UTC Tests are running...
🔴 2024-10-21 18:33:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14383 13038 0 4 1299 42

🟢 2024-10-21 18:33:46 UTC ydbd size 8.2 GiB changed* by -584 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 59c7c77 merge: 75284c4 diff diff %
ydbd size 8 814 703 656 Bytes 8 814 703 072 Bytes -584 Bytes -0.000%
ydbd stripped size 481 912 776 Bytes 481 912 776 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 16:28:25 UTC Pre-commit check for 75284c4 has started.
2024-10-21 16:31:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-21 16:54:33 UTC Build successful.
2024-10-21 16:54:51 UTC Tests are running...
🔴 2024-10-21 19:01:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10084 10001 0 10 26 47

🟢 2024-10-21 19:02:21 UTC ydbd size 5.6 GiB changed* by -592 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 59c7c77 merge: 75284c4 diff diff %
ydbd size 5 960 242 704 Bytes 5 960 242 112 Bytes -592 Bytes -0.000%
ydbd stripped size 1 495 829 344 Bytes 1 495 829 216 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 enabled auto-merge (squash) October 21, 2024 20:05
@jepett0 jepett0 merged commit c3c5c05 into ydb-platform:stable-24-3 Oct 21, 2024
8 of 12 checks passed
jepett0 added a commit to jepett0/ydb that referenced this pull request Oct 23, 2024
jepett0 added a commit that referenced this pull request Oct 23, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 24, 2024
jepett0 added a commit to jepett0/ydb that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants