Skip to content

correctly pass, merge and check body parameters in local-rpc calls #10601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Oct 18, 2024

Changelog entry

correctly pass, merge and check body parameters in local-rpc calls
closes #10588

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner October 18, 2024 11:21
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 11:22:51 UTC Pre-commit check linux-x86_64-release-asan for f871f35 has started.
2024-10-18 11:25:16 UTC Artifacts will be uploaded here
2024-10-18 11:29:26 UTC ya make is running...
🟡 2024-10-18 13:38:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17320 17004 0 91 114 111

🟢 2024-10-18 13:40:16 UTC Build successful.
🟢 2024-10-18 13:40:53 UTC ydbd size 5.7 GiB changed* by +63.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cebe29d merge: f871f35 diff diff %
ydbd size 6 103 366 112 Bytes 6 103 431 296 Bytes +63.7 KiB +0.001%
ydbd stripped size 1 521 592 816 Bytes 1 521 608 272 Bytes +15.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) October 18, 2024 11:23
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 11:24:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for f871f35 has started.
2024-10-18 11:25:22 UTC Artifacts will be uploaded here
2024-10-18 11:29:21 UTC ya make is running...
🟡 2024-10-18 13:04:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
80202 66235 0 4 13870 93

2024-10-18 13:12:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-18 13:23:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 4 0 1 0 90

2024-10-18 13:23:57 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-18 13:35:30 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
91 (only retried tests) 0 0 1 0 90

🟢 2024-10-18 13:35:37 UTC Build successful.
🟢 2024-10-18 13:35:57 UTC ydbd size 2.8 GiB changed* by +31.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cebe29d merge: f871f35 diff diff %
ydbd size 3 012 456 960 Bytes 3 012 489 328 Bytes +31.6 KiB +0.001%
ydbd stripped size 477 649 976 Bytes 477 651 576 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 16:56:26 UTC Pre-commit check linux-x86_64-release-asan for d8f01d5 has started.
2024-10-18 16:56:39 UTC Artifacts will be uploaded here
2024-10-18 17:00:15 UTC ya make is running...
🟡 2024-10-18 19:13:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17335 16844 0 120 326 45

🟢 2024-10-18 19:15:32 UTC Build successful.
🟢 2024-10-18 19:16:06 UTC ydbd size 5.7 GiB changed* by +55.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 93e2e23 merge: d8f01d5 diff diff %
ydbd size 6 104 554 824 Bytes 6 104 611 832 Bytes +55.7 KiB +0.001%
ydbd stripped size 1 521 872 464 Bytes 1 521 879 728 Bytes +7.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 16:56:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for d8f01d5 has started.
2024-10-18 16:56:55 UTC Artifacts will be uploaded here
2024-10-18 17:00:29 UTC ya make is running...
🟡 2024-10-18 18:36:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
80261 66260 0 12 13892 97

2024-10-18 18:43:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 18:55:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 16 0 0 0 92

🟢 2024-10-18 18:55:21 UTC Build successful.
🟢 2024-10-18 18:55:39 UTC ydbd size 2.8 GiB changed* by +31.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 93e2e23 merge: d8f01d5 diff diff %
ydbd size 3 013 081 208 Bytes 3 013 113 640 Bytes +31.7 KiB +0.001%
ydbd stripped size 477 722 456 Bytes 477 724 120 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit 857b20e into ydb-platform:main Oct 18, 2024
14 of 15 checks passed
@adameat adameat deleted the fix-local-rpc-parameters branch November 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make directory via UI ends with Bad Request error
3 participants