Skip to content

KeyValue tracing sampling #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 25, 2024
Merged

KeyValue tracing sampling #1047

merged 14 commits into from
Jan 25, 2024

Conversation

domwst
Copy link
Contributor

@domwst domwst commented Jan 16, 2024 •
edited
Loading

Changelog entry

Introduced new ICB and CMS controls for KeyValue request sampling

Changelog category

  • New feature

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: Test run completed, no test results found for commit 2271edb. Please check build logs.

@domwst domwst force-pushed the kv-tracing-sampling branch from 63fc6b3 to 6515daf Compare January 17, 2024 05:58
kruall
kruall previously approved these changes Jan 17, 2024
View reviewed changes
@domwst domwst force-pushed the kv-tracing-sampling branch from 3c669ec to bd3bdcc Compare January 17, 2024 10:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚪ 2024-01-24 15:22:58 UTC Pre-commit check for 5b81c07 has started.
⚪ 2024-01-24 15:22:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 15:58:36 UTC Build successful.
⚪ 2024-01-24 15:58:46 UTC Tests are running...
🔴 2024-01-24 17:17:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60093 50830 0 5 9235 23

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚪ 2024-01-24 15:20:11 UTC Pre-commit check for 5b81c07 has started.
⚪ 2024-01-24 15:20:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 15:57:42 UTC Build successful.
⚪ 2024-01-24 15:57:51 UTC Tests are running...
🔴 2024-01-24 17:31:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15929 15833 0 20 54 22

@domwst domwst linked an issue Jan 17, 2024 that may be closed by this pull request
Implement ICB for KeyValue requests sampling #1091
Closed
@domwst domwst enabled auto-merge (squash) January 18, 2024 11:05
@domwst domwst disabled auto-merge January 18, 2024 11:05
kruall
kruall previously approved these changes Jan 19, 2024
View reviewed changes
@domwst domwst force-pushed the kv-tracing-sampling branch from 75678f1 to 33df511 Compare January 24, 2024 02:22
@domwst domwst merged commit acfb5fd into ydb-platform:main Jan 25, 2024
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherednik dcherednik dcherednik approved these changes

@kruall kruall kruall left review comments

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ICB for KeyValue requests sampling
3 participants
@domwst @dcherednik @kruall