Merge CBO + CBO-KQP improvements #10400

pashandor789 · 2024-10-14T12:04:50Z

No description provided.

Co-authored-by: Pavel Ivanov <pudge1000-7@ydb.tech>

)

…#10288)

…ges (ydb-platform#9770)

…atform#10141) Co-authored-by: Pavel Ivanov <pudge1000-7@qavm-9f0570a4.qemu>

…db-platform#10146)

github-actions · 2024-10-14T12:06:36Z

⚪ 2024-10-14 12:06:36 UTC Pre-commit check for a971c74 has started.
⚪ 2024-10-14 12:10:04 UTC Build linux-x86_64-release-asan is running...
🔴 2024-10-14 12:13:34 UTC Build failed. see the build logs.
🔴 2024-10-14 12:13:36 UTC Tests run skipped.

github-actions · 2024-10-14T12:07:20Z

⚪ 2024-10-14 12:07:20 UTC Pre-commit check for a971c74 has started.
⚪ 2024-10-14 12:10:45 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-10-14 12:15:49 UTC Build failed. see the build logs.

github-actions · 2024-10-14T12:07:30Z

⚪ 2024-10-14 12:07:30 UTC Pre-commit check for a971c74 has started.
⚪ 2024-10-14 12:10:56 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-10-14 12:15:14 UTC Build failed. see the build logs.
🔴 2024-10-14 12:15:16 UTC Tests run skipped.

IsReady returns true if exception or value was set. allows to check readiness without locking cheсker-thread NOTE: returns true even if value was extracted from promise good replace for HasValue() || HasException() b2d64093e25cef5a350dfebe784c449203a5b383

github-actions · 2024-10-14T14:29:28Z

⚪ 2024-10-14 14:29:27 UTC Pre-commit check for 4f4a2db has started.
⚪ 2024-10-14 14:32:48 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-10-14 14:39:45 UTC Build failed. see the build logs.
🔴 2024-10-14 14:39:47 UTC Tests run skipped.

github-actions · 2024-10-14T14:29:41Z

⚪ 2024-10-14 14:29:40 UTC Pre-commit check for 4f4a2db has started.
⚪ 2024-10-14 14:33:09 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-10-14 14:53:51 UTC Build failed. see the build logs.

github-actions · 2024-10-14T14:29:44Z

⚪ 2024-10-14 14:29:44 UTC Pre-commit check for 4f4a2db has started.
⚪ 2024-10-14 14:33:02 UTC Build linux-x86_64-release-asan is running...
🔴 2024-10-14 14:36:30 UTC Build failed. see the build logs.
🔴 2024-10-14 14:36:32 UTC Tests run skipped.

github-actions · 2024-10-14T17:57:17Z

⚪ 2024-10-14 17:57:16 UTC Pre-commit check for f8c87c3 has started.
⚪ 2024-10-14 18:00:39 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-10-14 18:34:01 UTC Build failed. see the build logs.

github-actions · 2024-10-14T17:57:27Z

⚪ 2024-10-14 17:57:26 UTC Pre-commit check for f8c87c3 has started.
⚪ 2024-10-14 18:00:45 UTC Build linux-x86_64-release-asan is running...
🔴 2024-10-14 18:45:00 UTC Build failed. see the build logs.
🔴 2024-10-14 18:45:02 UTC Tests run skipped.

github-actions · 2024-10-14T18:00:11Z

⚪ 2024-10-14 18:00:10 UTC Pre-commit check for f8c87c3 has started.
⚪ 2024-10-14 18:03:37 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-10-14 18:37:21 UTC Build failed. see the build logs.
🔴 2024-10-14 18:37:23 UTC Tests run skipped.

github-actions · 2024-10-14T19:35:10Z

⚪ 2024-10-14 19:35:10 UTC Pre-commit check for 7396aa1 has started.
⚪ 2024-10-14 19:38:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-14 20:29:16 UTC Build successful.
⚪ 2024-10-14 20:29:35 UTC Tests are running...
🔴 2024-10-14 22:39:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
77408	63919	0	5	13437	47

🟡 2024-10-14 22:40:36 UTC ydbd size 8.2 GiB changed* by +1.8 MiB, which is >= 100.0 KiB vs stable-24-3-8-analytics: Warning

ydbd size dash	stable-24-3-8-analytics: `3b364c1`	merge: `7396aa1`	diff	diff %
ydbd size	8 829 099 024 Bytes	8 830 959 520 Bytes	+1.8 MiB	+0.021%
ydbd stripped size	481 092 264 Bytes	481 141 608 Bytes	+48.2 KiB	+0.010%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T19:35:22Z

⚪ 2024-10-14 19:35:21 UTC Pre-commit check for 7396aa1 has started.
⚪ 2024-10-14 19:38:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-14 20:05:05 UTC Build successful.
⚪ 2024-10-14 20:05:25 UTC Tests are running...
🔴 2024-10-14 22:11:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16244	16112	0	31	52	49

🟡 2024-10-14 22:12:16 UTC ydbd size 5.6 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs stable-24-3-8-analytics: Warning

ydbd size dash	stable-24-3-8-analytics: `3b364c1`	merge: `7396aa1`	diff	diff %
ydbd size	5 980 246 688 Bytes	5 981 343 816 Bytes	+1.0 MiB	+0.018%
ydbd stripped size	1 495 812 928 Bytes	1 496 030 112 Bytes	+212.1 KiB	+0.015%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T19:35:33Z

⚪ 2024-10-14 19:35:32 UTC Pre-commit check for 7396aa1 has started.
⚪ 2024-10-14 19:38:56 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-14 19:59:26 UTC Build successful.

pavelvelikhov and others added 19 commits October 14, 2024 14:44

Fix Olap Filter selectivity computation (ydb-platform#9021)

63507d1

Co-authored-by: Pavel Ivanov <pudge1000-7@ydb.tech>

Fixed computation of ByteSize for CBO for OLAP tables (ydb-platform#9626

463649e

)

Lowered MapJoin threshold to avoid excessive broadcasts (ydb-platform…

ac5d781

…#10288)

Added ensure Node != nullptr. (ydb-platform#8855)

8225e62

[CBO] Hints parser added (ydb-platform#9252)

217b631

[CBO] hints parser fixes (ydb-platform#9463)

63a1d74

[KQP] Plan inf rec fix (ydb-platform#9519)

c683ef1

[CLI] Bugfix: remove item prefix correctly (ydb-platform#9663)

2897dbd

[KQP] Many result sets added (ydb-platform#9696)

41fb53f

[KQP] CBO hints warnings added (ydb-platform#9701)

42e64fe

[CBO] Ignore IsJoinApplicable with hints. Improve hints warning messa…

9085ecf

…ges (ydb-platform#9770)

[CBO] Asan test memory leak fix (ydb-platform#9791)

e8290ec

[CBO] Hint syntax fix (ydb-platform#9875)

b048dc7

[KQP] Fix plan olap filter selectivity estimation (ydb-platform#9936)

994e011

[CBO] Fix LeftOnly (LeftAntiJoin) algebraic matrix (ydb-platform#9974)

abe5dbf

[KQP] turn off CBO IsLookupJoinApplicable for not row column. (ydb-pl…

bf47906

…atform#10141) Co-authored-by: Pavel Ivanov <pudge1000-7@qavm-9f0570a4.qemu>

[KQP] Binary symbols in range breaks plan json and make server crash (y…

90fd6bf

…db-platform#10146)

[KQP] Fix comparison attributes OLAP (ydb-platform#10192)

07f6ccd

[KQP] Make TKqpColumnStatisticsRequester async (ydb-platform#10224)

d554307

pashandor789 requested a review from a team as a code owner October 14, 2024 12:04

pashandor789 changed the title ~~Analitek~~ Merge CBO + CBO-KQP improvements Oct 14, 2024

TFuture add IsReady method

70c8b76

IsReady returns true if exception or value was set. allows to check readiness without locking cheсker-thread NOTE: returns true even if value was extracted from promise good replace for HasValue() || HasException() b2d64093e25cef5a350dfebe784c449203a5b383

Tony-Romanov and others added 2 commits October 14, 2024 20:02

Don't lose 'any' flag after CBO. (ydb-platform#8674)

439089a

[] fix

93ee979

[] fix

e057121

zverevgeny approved these changes Oct 15, 2024

View reviewed changes

pashandor789 merged commit e8c42a4 into ydb-platform:stable-24-3-8-analytics Oct 15, 2024
8 of 12 checks passed

StekPerepolnen mentioned this pull request Oct 29, 2024

viewer healthcheck pathmerge stable 24 #11044

Closed

This was referenced Jun 3, 2025

Enable kafka port for local ydb container #19218

Closed

Enable kafka port for local ydb container #19220

Closed

StekPerepolnen mentioned this pull request Jul 28, 2025

audit extra merge stream nb 24 4 #21776

Closed

Merge CBO + CBO-KQP improvements #10400

Merge CBO + CBO-KQP improvements #10400

Uh oh!

Conversation

pashandor789 commented Oct 14, 2024

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading