Skip to content

do not trigger dead tablet issue during creation of a lot of tablets… #10398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2024
Merged

do not trigger dead tablet issue during creation of a lot of tablets… #10398

merged 3 commits into from
Oct 21, 2024

Conversation

@vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Oct 14, 2024 •
edited
Loading

Changelog entry

fix some false positives in healthcheck

Changelog category

  • Improvement

Additional information

Backport of #10235 and #9744

@vporyadke vporyadke requested a review from a team as a code owner October 14, 2024 11:43
@github-actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 11:46:58 UTC Pre-commit check for 3bd2fef has started.
⚪ 2024-10-14 11:49:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-14 12:53:43 UTC Build successful.
⚪ 2024-10-14 12:53:58 UTC Tests are running...
🔴 2024-10-14 14:44:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40056 34783 0 9 5215 49

🟢 2024-10-14 14:45:14 UTC ydbd size 8.2 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f6729a6 merge: 3bd2fef diff diff %
ydbd size 8 809 812 312 Bytes 8 809 819 616 Bytes +7.1 KiB +0.000%
ydbd stripped size 481 749 000 Bytes 481 749 064 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 11:47:11 UTC Pre-commit check for 3bd2fef has started.
⚪ 2024-10-14 11:50:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-14 12:22:50 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 11:47:15 UTC Pre-commit check for 3bd2fef has started.
⚪ 2024-10-14 11:50:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-14 12:33:21 UTC Build successful.
⚪ 2024-10-14 12:33:38 UTC Tests are running...
🔴 2024-10-14 14:33:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11499 11414 0 13 27 45

🟢 2024-10-14 14:34:33 UTC ydbd size 5.5 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f6729a6 merge: 3bd2fef diff diff %
ydbd size 5 956 818 096 Bytes 5 956 822 848 Bytes +4.6 KiB +0.000%
ydbd stripped size 1 495 164 896 Bytes 1 495 165 344 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

⚪ 2024-10-21 07:27:46 UTC Pre-commit check for 400af38 has started.
⚪ 2024-10-21 07:30:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-21 08:08:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

⚪ 2024-10-21 07:31:04 UTC Pre-commit check for 400af38 has started.
⚪ 2024-10-21 07:34:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-21 08:16:51 UTC Build successful.
⚪ 2024-10-21 08:17:08 UTC Tests are running...
🔴 2024-10-21 10:29:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11512 11421 0 19 24 48

🟢 2024-10-21 10:30:36 UTC ydbd size 5.6 GiB changed* by +4.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 4bbfda7 merge: 400af38 diff diff %
ydbd size 5 960 237 664 Bytes 5 960 242 608 Bytes +4.8 KiB +0.000%
ydbd stripped size 1 495 828 768 Bytes 1 495 829 280 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

⚪ 2024-10-21 07:55:22 UTC Pre-commit check for 400af38 has started.
⚪ 2024-10-21 07:58:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-21 09:00:57 UTC Build successful.
⚪ 2024-10-21 09:01:13 UTC Tests are running...
🔴 2024-10-21 10:54:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40060 34792 0 8 5214 46

🟢 2024-10-21 10:55:43 UTC ydbd size 8.2 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 4bbfda7 merge: 400af38 diff diff %
ydbd size 8 814 695 376 Bytes 8 814 703 624 Bytes +8.1 KiB +0.000%
ydbd stripped size 481 912 648 Bytes 481 912 776 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

vporyadke
vporyadke commented Oct 21, 2024
View reviewed changes
ydb/core/health_check/health_check_ut.cpp
UNIT_ASSERT_VALUES_EQUAL(database_status.storage().pools()[0].id(), "static");
}

void HiveSyncTest(bool syncPeriod) {
Copy link
Collaborator Author

@vporyadke vporyadke Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed from main in https://github.com/ydb-platform/ydb/pull/9221/files#diff-675b73abe14f4d7620595d2b5662d9f20998e0a13abcdabb0c61889bff7b3c43

@vporyadke vporyadke merged commit 59c7c77 into ydb-platform:stable-24-3 Oct 21, 2024
8 of 12 checks passed
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 24, 2024
@vporyadke @uzhastik
do not trigger dead tablet issue during creation of a lot of tablets… (
88d7d9d 
ydb-platform#10398)
This was referenced Oct 29, 2024
Closed
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vporyadke @fomichev3000