Skip to content

Fix VDisk replication token handling, add some extra checks and log points #10371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Oct 14, 2024

Changelog entry

Fix VDisk replication token handling, add some extra checks and log points

Changelog category

  • Bugfix

Additional information

VDisk replication token leak problem has been fixed.

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 06:45:10 UTC Pre-commit check linux-x86_64-release-asan for fa178f3 has started.
2024-10-14 06:45:22 UTC Artifacts will be uploaded here
2024-10-14 06:48:14 UTC ya make is running...
🟡 2024-10-14 08:13:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10564 10316 0 62 79 107

🟢 2024-10-14 08:14:25 UTC Build successful.
🟢 2024-10-14 08:14:58 UTC ydbd size 5.7 GiB changed* by +74.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ddea4fb merge: fa178f3 diff diff %
ydbd size 6 095 924 520 Bytes 6 096 000 712 Bytes +74.4 KiB +0.001%
ydbd stripped size 1 520 288 368 Bytes 1 520 315 248 Bytes +26.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 06:46:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa178f3 has started.
2024-10-14 06:46:28 UTC Artifacts will be uploaded here
2024-10-14 06:49:25 UTC ya make is running...
🟡 2024-10-14 07:36:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15514 14026 0 1 1382 105

2024-10-14 07:37:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 07:49:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 5 0 0 0 99

🟢 2024-10-14 07:49:16 UTC Build successful.
🟢 2024-10-14 07:49:34 UTC ydbd size 2.8 GiB changed* by +13.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ddea4fb merge: fa178f3 diff diff %
ydbd size 3 009 118 720 Bytes 3 009 132 872 Bytes +13.8 KiB +0.000%
ydbd stripped size 477 347 064 Bytes 477 353 336 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit 2414fb7 into ydb-platform:main Oct 14, 2024
11 checks passed
@alexvru alexvru deleted the vdisk/fix-repl-token-handling branch October 14, 2024 09:45
alexvru added a commit to alexvru/ydb that referenced this pull request Nov 2, 2024
alexvru added a commit that referenced this pull request Nov 5, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants