fix case removed column for stats usage #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsofya
reviewed
Jan 16, 2024
| @@ -18,7 +18,6 @@ namespace NKikimr::NOlap::NCompaction { | |||
|
|
|||
| void TGeneralCompactColumnEngineChanges::BuildAppendedPortionsByFullBatches(TConstructionContext& context) noexcept { | |||
| std::vector<TPortionInfoWithBlobs> portions = TPortionInfoWithBlobs::RestorePortions(SwitchedPortions, Blobs); | |||
| Blobs.clear(); | |||
| std::vector<std::shared_ptr<arrow::RecordBatch>> batchResults; | |||
There was a problem hiding this comment.
Это точно корректно? Какое это имеет отношение к проверке колонок?
There was a problem hiding this comment.
да. никакого.
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7c8565a.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 7c8565a.
|
nsofya
approved these changes
Jan 16, 2024
va-kuznecov
pushed a commit
to va-kuznecov/ydb
that referenced
this pull request
Jan 16, 2024
* fix case removed column for stats usage * additional logging
Merged
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Jan 29, 2024
Merged
Merged
This was referenced Jan 30, 2024
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont use column for stats calculation if one is removed