Skip to content

Fix rebinding an allocator to the same type should result in the original allocator #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

hdnpth
Copy link
Collaborator

@hdnpth hdnpth commented Jan 15, 2024

  1. This patch https://lists.llvm.org/pipermail/libcxx-commits/2022-October/045949.html introduces static_assert with the additional requirement on allocator — rebinding an allocator to the same type should result in the original allocator.

On the upcoming libcxx update I have got the following error:

/home/hiddenpath/ydb/contrib/libs/cxxsupp/libcxx/include/vector:367:5: error: static assertion failed due to requirement 'is_same<NKikimr::NMiniKQL::TMKQLAllocator<NYql::NUdf::TUnboxedValue, NKikimr::NMiniKQL::EMemorySubPool::Temporary>, NKikimr::NMiniKQL::TMKQLAllocator<NYql::NUdf::TUnboxedValue, NKikimr::NMiniKQL::EMemorySubPool::Default>>::value': [allocator.requirements] states that rebinding an allocator to the same type should result in the original allocator
    static_assert(is_same<allocator_type, __rebind_alloc<__alloc_traits, value_type> >::value,
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/hiddenpath/ydb/library/yql/minikql/computation/mkql_computation_node_holders.cpp:235:91: note: in instantiation of template class 'std::vector<NYql::NUdf::TUnboxedValue, NKikimr::NMiniKQL::TMKQLAllocator<NYql::NUdf::TUnboxedValue, NKikimr::NMiniKQL::EMemorySubPool::Temporary>>' requested here
class TVectorHolderBase: public TComputationValue<TVectorHolderBase<TBaseVector>>, public TBaseVector {
                                                                                          ^
  1. I have found some mistaken return keywords in various functions (since they have a void return type we have to get rid of them) as well.

Copy link

github-actions bot commented Jan 16, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 163217f.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59878 50653 0 3 9209 13

🔴 linux-x86_64-release-asan: some tests FAILED for commit 163217f.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15861 15707 0 33 106 15

@hdnpth hdnpth requested a review from vitstn January 16, 2024 08:34
@alexv-smirnov alexv-smirnov enabled auto-merge (squash) January 18, 2024 17:12
@alexv-smirnov alexv-smirnov merged commit fe8ac5a into ydb-platform:main Jan 18, 2024
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
@vitstn vitstn mentioned this pull request Jan 29, 2024
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants