fix validation of negative partition count value

nshestakov · nshestakov · commit fca5d5cc8a31 · 2024-06-06T11:28:15.000Z
diff --git a/ydb/services/lib/actors/pq_schema_actor.cpp b/ydb/services/lib/actors/pq_schema_actor.cpp
@@ -764,9 +764,11 @@ namespace NKikimr::NGRpcProxy::V1 {
         }
 
         if (settings.has_partitions_count()) {
-            if (settings.partitions_count() > 0) {
-                minParts = settings.partitions_count();
+            if (settings.partitions_count() <= 0) {
+                error = TStringBuilder() << "Partitions count must be positive, provided " << settings.partitions_count();
+                return Ydb::StatusIds::BAD_REQUEST;
             }
+            minParts = settings.partitions_count();
         } else if (settings.has_autoscaling_settings()) {
             const auto& autoScalteSettings = settings.autoscaling_settings();
             if (autoScalteSettings.min_active_partitions() > 0) {

Original file line number	Diff line number	Diff line change
`@@ -764,9 +764,11 @@ namespace NKikimr::NGRpcProxy::V1 {`
`764`	`764`	`}`
`765`	`765`
`766`	`766`	`if (settings.has_partitions_count()) {`
`767`		`- if (settings.partitions_count() > 0) {`
`768`		`- minParts = settings.partitions_count();`
	`767`	`+ if (settings.partitions_count() <= 0) {`
	`768`	`+ error = TStringBuilder() << "Partitions count must be positive, provided " << settings.partitions_count();`
	`769`	`+ return Ydb::StatusIds::BAD_REQUEST;`
`769`	`770`	`}`
	`771`	`+ minParts = settings.partitions_count();`
`770`	`772`	`} else if (settings.has_autoscaling_settings()) {`
`771`	`773`	`const auto& autoScalteSettings = settings.autoscaling_settings();`
`772`	`774`	`if (autoScalteSettings.min_active_partitions() > 0) {`