Skip to content

Commit ec68e19

Browse files
authored
Merge 476cf5b into 5c989e0
2 parents 5c989e0 + 476cf5b commit ec68e19

File tree

5 files changed

+1
-5
lines changed

5 files changed

+1
-5
lines changed

ydb/core/kqp/ut/common/kqp_ut_common.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ TKikimrRunner::TKikimrRunner(const TKikimrSettings& settings) {
123123
appConfig.MutableTableServiceConfig()->SetEnableRowsDuplicationCheck(true);
124124
ServerSettings->SetAppConfig(appConfig);
125125
ServerSettings->SetFeatureFlags(settings.FeatureFlags);
126-
ServerSettings->FeatureFlags.SetEnableImmediateWritingOnBulkUpsert(true);
127126
ServerSettings->SetNodeCount(settings.NodeCount);
128127
ServerSettings->SetEnableKqpSpilling(enableSpilling);
129128
ServerSettings->SetEnableDataColumnForIndexTable(true);

ydb/core/kqp/ut/common/kqp_ut_common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ struct TKikimrSettings: public TTestFeatureFlagsHolder<TKikimrSettings> {
9999
exchangerSettings->SetMaxDelayMs(10);
100100
AppConfig.MutableColumnShardConfig()->SetDisabledOnSchemeShard(false);
101101
FeatureFlags.SetEnableSparsedColumns(true);
102-
FeatureFlags.SetEnableImmediateWritingOnBulkUpsert(true);
103102
FeatureFlags.SetEnableWritePortionsOnInsert(true);
104103
FeatureFlags.SetEnableParameterizedDecimal(true);
105104
FeatureFlags.SetEnableTopicAutopartitioningForCDC(true);

ydb/core/kqp/ut/olap/write_ut.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ Y_UNIT_TEST_SUITE(KqpOlapWrite) {
2424

2525
auto settings = TKikimrSettings().SetWithSampleTables(false);
2626
TKikimrRunner kikimr(settings);
27-
kikimr.GetTestServer().GetRuntime()->GetAppData().FeatureFlags.SetEnableImmediateWritingOnBulkUpsert(true);
2827
kikimr.GetTestServer().GetRuntime()->GetAppData().FeatureFlags.SetEnableWritePortionsOnInsert(true);
2928
TLocalHelper(kikimr).CreateTestOlapTable();
3029
Tests::NCommon::TLoggerInit(kikimr)

ydb/core/protos/feature_flags.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ message TFeatureFlags {
168168
optional bool EnableExternalDataSourcesOnServerless = 143 [default = true];
169169
optional bool EnableSparsedColumns = 144 [default = false];
170170
optional bool EnableParameterizedDecimal = 145 [default = true];
171-
optional bool EnableImmediateWritingOnBulkUpsert = 146 [default = false];
171+
optional bool EnableImmediateWritingOnBulkUpsert = 146 [default = true];
172172
optional bool EnableInsertWriteIdSpecialColumnCompatibility = 147 [default = false];
173173
optional bool EnableTopicAutopartitioningForCDC = 148 [default = false];
174174
optional bool EnableWritePortionsOnInsert = 149 [default = false];

ydb/core/testlib/test_client.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,6 @@ namespace Tests {
258258
AppConfig->MutableHiveConfig()->SetObjectImbalanceToBalance(100);
259259
AppConfig->MutableColumnShardConfig()->SetDisabledOnSchemeShard(false);
260260
FeatureFlags.SetEnableSeparationComputeActorsFromRead(true);
261-
FeatureFlags.SetEnableImmediateWritingOnBulkUpsert(true);
262261
FeatureFlags.SetEnableWritePortionsOnInsert(true);
263262
FeatureFlags.SetEnableFollowerStats(true);
264263
}

0 commit comments

Comments
 (0)