Skip to content

Commit eb3b7df

Browse files
committed
cleanup
1 parent aa344c4 commit eb3b7df

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

ydb/library/yql/providers/generic/provider/yql_generic_cluster_config.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ namespace NYql {
326326
NConnector::NApi::EDataSourceKind::GREENPLUM,
327327
NConnector::NApi::EDataSourceKind::MS_SQL_SERVER,
328328
NConnector::NApi::EDataSourceKind::MYSQL,
329-
NConnector::NApi::EDataSourceKind::ORACLE,
330329
NConnector::NApi::EDataSourceKind::POSTGRESQL,
331330
};
332331

@@ -404,17 +403,6 @@ namespace NYql {
404403
}
405404
}
406405

407-
// Oracle:
408-
// * always set service_name for oracle;
409-
if (clusterConfig.GetKind() == NConnector::NApi::ORACLE) {
410-
if (!clusterConfig.GetDataSourceOptions().contains("service_name")) {
411-
return ValidationError(
412-
clusterConfig,
413-
context,
414-
"For Oracle databases you must set service, but you have not set it");
415-
}
416-
}
417-
418406
// All the databases with exception to managed YDB:
419407
// * DATABASE_NAME is mandatory field
420408
if (traditionalRelationalDatabaseKinds.contains(clusterConfig.GetKind())) {

0 commit comments

Comments
 (0)