Return consistency settings in description (#13236)

Author: CyberROFL

ydb/core/grpc_services/rpc_replication.cpp

@@ -131,6 +131,7 @@ class TDescribeReplicationRPC: public TRpcSchemeRequestActor<TDescribeReplicatio
         }
 
         ConvertConnectionParams(record.GetConnectionParams(), *Result.mutable_connection_params());
+        ConvertConsistencySettings(record.GetConsistencySettings(), Result);
         ConvertState(*record.MutableState(), Result);
 
         for (const auto& target : record.GetTargets()) {
@@ -172,6 +173,26 @@ class TDescribeReplicationRPC: public TRpcSchemeRequestActor<TDescribeReplicatio
         to.set_token_secret_name(from.GetTokenSecretName());
     }
 
+    static void ConvertConsistencySettings(const NKikimrReplication::TConsistencySettings& from, Ydb::Replication::DescribeReplicationResult& to) {
+        switch (from.GetLevelCase()) {
+        case NKikimrReplication::TConsistencySettings::kRow:
+            return ConvertRowConsistencySettings(from.GetRow(), *to.mutable_row_consistency());
+        case NKikimrReplication::TConsistencySettings::kGlobal:
+            return ConvertGlobalConsistencySettings(from.GetGlobal(), *to.mutable_global_consistency());
+        default:
+            break;
+        }
+    }
+
+    static void ConvertRowConsistencySettings(const NKikimrReplication::TConsistencySettings::TRowConsistency&, Ydb::Replication::ConsistencyLevelRow&) {
+        // nop
+    }
+
+    static void ConvertGlobalConsistencySettings(const NKikimrReplication::TConsistencySettings::TGlobalConsistency& from, Ydb::Replication::ConsistencyLevelGlobal& to) {
+        *to.mutable_commit_interval() = google::protobuf::util::TimeUtil::MillisecondsToDuration(
+            from.GetCommitIntervalMilliSeconds());
+    }
+
     static void ConvertItem(const NKikimrReplication::TReplicationConfig::TTargetSpecific::TTarget& from, Ydb::Replication::DescribeReplicationResult::Item& to) {
         to.set_id(from.GetId());
         to.set_source_path(from.GetSrcPath());

ydb/core/protos/replication.proto

@@ -213,6 +213,7 @@ message TEvDescribeReplicationResult {
 
     optional EStatus Status = 1;
     optional TConnectionParams ConnectionParams = 2;
+    optional TConsistencySettings ConsistencySettings = 5;
     repeated TReplicationConfig.TTargetSpecific.TTarget Targets = 3;
     optional TReplicationState State = 4;
 }

ydb/core/tx/replication/controller/tx_describe_replication.cpp

@@ -187,6 +187,7 @@ class TController::TTxDescribeReplication: public TTxBase {
         Result = MakeHolder<TEvController::TEvDescribeReplicationResult>();
         Result->Record.SetStatus(NKikimrReplication::TEvDescribeReplicationResult::SUCCESS);
         Result->Record.MutableConnectionParams()->CopyFrom(replication->GetConfig().GetSrcConnectionParams());
+        Result->Record.MutableConsistencySettings()->CopyFrom(replication->GetConfig().GetConsistencySettings());
 
         using TInitialScanProgress = NYdb::NTable::TChangefeedDescription::TInitialScanProgress;
         std::optional<TInitialScanProgress> totalScanProgress;

ydb/public/api/protos/draft/ydb_replication.proto

@@ -45,6 +45,13 @@ message ConnectionParams {
     }
 }
 
+message ConsistencyLevelRow {
+}
+
+message ConsistencyLevelGlobal {
+    google.protobuf.Duration commit_interval = 1;
+}
+
 message DescribeReplicationResult {
     message Stats {
         optional google.protobuf.Duration lag = 1;
@@ -72,7 +79,12 @@ message DescribeReplicationResult {
 
     // Description of scheme object.
     Ydb.Scheme.Entry self = 1;
+
     ConnectionParams connection_params = 2;
+    oneof consistency_level {
+        ConsistencyLevelRow row_consistency = 7;
+        ConsistencyLevelGlobal global_consistency = 8;
+    }
     repeated Item items = 3;
     oneof state {
         RunningState running = 4;