fix segfault

Author: swalrus1

ydb/core/tx/columnshard/columnshard__write.cpp

@@ -16,7 +16,7 @@ void TColumnShard::OverloadWriteFail(const EOverloadStatus overloadReason, const
     Counters.GetTabletCounters()->IncCounter(COUNTER_WRITE_FAIL);
     switch (overloadReason) {
         case EOverloadStatus::Disk:
-            Counters.GetCSCounters().OnWriteOverloadDisk(writeData.GetSize());
+            Counters.GetCSCounters().OnWriteOverloadDisk();
             break;
         case EOverloadStatus::InsertTable:
             Counters.GetCSCounters().OnWriteOverloadInsertTable(writeData.GetSize());

ydb/core/tx/columnshard/counters/columnshard.cpp

@@ -6,9 +6,11 @@
 
 namespace NKikimr::NColumnShard {
 
-TCSCounters::TCSCounters()
-    : TBase("CS")
+TCSCounters::TCSCounters(std::shared_ptr<const TTabletCountersHandle> tabletCounters)
+    : TBase("CS"), TabletCounters(std::move(tabletCounters))
 {
+    Y_ABORT_UNLESS(TabletCounters);
+
     StartBackgroundCount = TBase::GetDeriviative("StartBackground/Count");
     TooEarlyBackgroundCount = TBase::GetDeriviative("TooEarlyBackground/Count");
     SetupCompactionCount = TBase::GetDeriviative("SetupCompaction/Count");

ydb/core/tx/columnshard/counters/columnshard.h

@@ -21,7 +21,7 @@ class TCSCounters: public TCommonCountersOwner {
 private:
     using TBase = TCommonCountersOwner;
 
-    std::shared_ptr<TTabletCountersHandle> TabletCounters;
+    std::shared_ptr<const TTabletCountersHandle> TabletCounters;
 
     NMonitoring::TDynamicCounters::TCounterPtr StartBackgroundCount;
     NMonitoring::TDynamicCounters::TCounterPtr TooEarlyBackgroundCount;
@@ -133,7 +133,7 @@ class TCSCounters: public TCommonCountersOwner {
         SplitCompactionGranulePortionsCount->SetValue(portionsCount);
     }
 
-    void OnWriteOverloadDisk(const ui64 /*size*/) const {
+    void OnWriteOverloadDisk() const {
         TabletCounters->IncCounter(COUNTER_OUT_OF_SPACE);
     }
 
@@ -213,7 +213,7 @@ class TCSCounters: public TCommonCountersOwner {
         SetupCleanupCount->Add(1);
     }
 
-    TCSCounters();
+    TCSCounters(std::shared_ptr<const TTabletCountersHandle> tabletCounters);
 };
 
 }

ydb/core/tx/columnshard/counters/counters_manager.h

@@ -21,26 +21,26 @@ namespace NKikimr::NColumnShard {
 
 class TCountersManager {
 private:
-    YDB_READONLY(TCSCounters, CSCounters, TCSCounters());
+    YDB_READONLY_DEF(std::shared_ptr<const TTabletCountersHandle>, TabletCounters);
+    YDB_READONLY_DEF(std::shared_ptr<TWritesMonitor>, WritesMonitor);
+
+    YDB_READONLY_DEF(std::shared_ptr<TBackgroundControllerCounters>, BackgroundControllerCounters);
+    YDB_READONLY_DEF(std::shared_ptr<TColumnTablesCounters>, ColumnTablesCounters);
+
+    YDB_READONLY(TCSCounters, CSCounters, TCSCounters(TabletCounters));
     YDB_READONLY(TIndexationCounters, EvictionCounters, TIndexationCounters("Eviction"));
     YDB_READONLY(TIndexationCounters, IndexationCounters, TIndexationCounters("Indexation"));
     YDB_READONLY(TIndexationCounters, CompactionCounters, TIndexationCounters("GeneralCompaction"));
     YDB_READONLY(TScanCounters, ScanCounters, TScanCounters("Scan"));
     YDB_READONLY_DEF(std::shared_ptr<NOlap::NResourceBroker::NSubscribe::TSubscriberCounters>, SubscribeCounters);
 
-    YDB_READONLY_DEF(std::shared_ptr<TBackgroundControllerCounters>, BackgroundControllerCounters);
-    YDB_READONLY_DEF(std::shared_ptr<TColumnTablesCounters>, ColumnTablesCounters);
-
-    YDB_READONLY_DEF(std::shared_ptr<const TTabletCountersHandle>, TabletCounters);
-    YDB_READONLY_DEF(std::shared_ptr<TWritesMonitor>, WritesMonitor);
-
 public:
     TCountersManager(TTabletCountersBase& tabletCounters)
-        : SubscribeCounters(std::make_shared<NOlap::NResourceBroker::NSubscribe::TSubscriberCounters>())
+        : TabletCounters(std::make_shared<const TTabletCountersHandle>(tabletCounters))
+        , WritesMonitor(std::make_shared<TWritesMonitor>(tabletCounters))
         , BackgroundControllerCounters(std::make_shared<TBackgroundControllerCounters>())
         , ColumnTablesCounters(std::make_shared<TColumnTablesCounters>())
-        , TabletCounters(std::make_shared<const TTabletCountersHandle>(tabletCounters))
-        , WritesMonitor(std::make_shared<TWritesMonitor>(tabletCounters)) {
+        , SubscribeCounters(std::make_shared<NOlap::NResourceBroker::NSubscribe::TSubscriberCounters>()) {
     }
 };