Skip to content

Commit e38b47a

Browse files
committed
remove provocative comment
1 parent e8d3934 commit e38b47a

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

ydb/library/yql/core/common_opt/yql_co_simple1.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3316,24 +3316,6 @@ TExprNode::TPtr RewriteAsHoppingWindowFullOutput(const TCoAggregate& aggregate,
33163316
const auto aggregateInputType = GetSeqItemType(*aggregate.Ptr()->Head().GetTypeAnn()).Cast<TStructExprType>();
33173317
NHopping::TKeysDescription keysDescription(*aggregateInputType, aggregate.Keys(), hopTraits.Column);
33183318

3319-
// TODO(YQ-3699)
3320-
// To enable aggregation not only for simple types (int, string, etc) but also for complex types (list, dict, set, null, etc),
3321-
// uncomment these lines and fix the constaints for TCoMap in ydb/library/yql/core/yql_expr_constraint.cpp
3322-
// if (keysDescription.NeedPickle()) {
3323-
// return Build<TCoMap>(ctx, pos)
3324-
// .Lambda(keysDescription.BuildUnpickleLambda(ctx, pos, *aggregateInputType))
3325-
// .Input<TCoAggregate>()
3326-
// .InitFrom(aggregate)
3327-
// .Input<TCoMap>()
3328-
// .Lambda(keysDescription.BuildPickleLambda(ctx, pos))
3329-
// .Input(aggregate.Input())
3330-
// .Build()
3331-
// .Settings(RemoveSetting(aggregate.Settings().Ref(), "output_columns", ctx))
3332-
// .Build()
3333-
// .Done()
3334-
// .Ptr();
3335-
// }
3336-
33373319
const auto keyLambda = keysDescription.GetKeySelector(ctx, pos, aggregateInputType);
33383320
const auto timeExtractorLambda = NHopping::BuildTimeExtractor(hopTraits.Traits, ctx);
33393321
const auto initLambda = NHopping::BuildInitHopLambda(aggregate, ctx);

0 commit comments

Comments
 (0)