cr: fix HasKeyCells name

Author: kungasc

ydb/core/tablet_flat/flat_part_btree_index_iter.h

@@ -264,7 +264,7 @@ class TPartBtreeIndexIt : public IIndexIter {
         return State.back().EndRowId;
     }
 
-    TPos HasKeyCells() const override {
+    TPos GetKeyCellsCount() const override {
         Y_ABORT_UNLESS(IsLeaf());
         return State.back().BeginKey.Count();
     }

ydb/core/tablet_flat/flat_part_index_iter.h

@@ -128,7 +128,7 @@ class TPartIndexIt : public IIndexIter, public IStatsPartGroupIterator {
             : EndRowId;
     }
 
-    TPos HasKeyCells() const override {
+    TPos GetKeyCellsCount() const override {
         Y_ABORT_UNLESS(Index);
         Y_ABORT_UNLESS(Iter);
         return GroupInfo.KeyTypes.size();

ydb/core/tablet_flat/flat_part_index_iter_iface.h

@@ -22,7 +22,7 @@ namespace NKikimr::NTable {
         virtual TRowId GetRowId() const = 0;
         virtual TRowId GetNextRowId() const = 0;
 
-        virtual TPos HasKeyCells() const = 0;
+        virtual TPos GetKeyCellsCount() const = 0;
         virtual TCell GetKeyCell(TPos index) const = 0;
 
         virtual ~IIndexIter() = default;

ydb/core/tablet_flat/flat_part_iter_multi.h

@@ -544,8 +544,8 @@ namespace NTable {
                                 return Exhausted();
                             };
                             case EReady::Data: {
-                                Y_DEBUG_ABORT_UNLESS(Index.HasKeyCells(), "Non-first page is expected to have key cells");
-                                if (Index.HasKeyCells()) {
+                                Y_DEBUG_ABORT_UNLESS(Index.GetKeyCellsCount(), "Non-first page is expected to have key cells");
+                                if (Index.GetKeyCellsCount()) {
                                     if (!checkIndex()) {
                                         // First row for the next RowId
                                         MaxVersion = TRowVersion::Max();
@@ -632,8 +632,8 @@ namespace NTable {
             }
 
             // We need exact match on rowId, bail on larger values
-            Y_DEBUG_ABORT_UNLESS(Index.GetRowId() == 0 || Index.HasKeyCells(), "Non-first page is expected to have key cells");
-            if (Index.HasKeyCells()) {
+            Y_DEBUG_ABORT_UNLESS(Index.GetRowId() == 0 || Index.GetKeyCellsCount(), "Non-first page is expected to have key cells");
+            if (Index.GetKeyCellsCount()) {
                 TRowId indexRowId = Index.GetKeyCell(0).AsValue<TRowId>();
                 if (rowId < indexRowId) {
                     // We cannot compute MaxVersion anyway as indexRowId row may be presented on the previous page
@@ -675,8 +675,8 @@ namespace NTable {
                 return Terminate(ready);
             }
 
-            Y_DEBUG_ABORT_UNLESS(Index.HasKeyCells(), "Non-first page is expected to have key cells");
-            if (Y_LIKELY(Index.HasKeyCells())) {
+            Y_DEBUG_ABORT_UNLESS(Index.GetKeyCellsCount(), "Non-first page is expected to have key cells");
+            if (Y_LIKELY(Index.GetKeyCellsCount())) {
                 if (!checkIndex()) {
                     // First row for the nextRowId
                     MaxVersion = TRowVersion::Max();
@@ -706,7 +706,7 @@ namespace NTable {
             Data = Page->Begin();
             Y_ABORT_UNLESS(Data);
 
-            if (Index.HasKeyCells()) {
+            if (Index.GetKeyCellsCount()) {
                 // Must have rowId as we have checked index
                 Y_ABORT_UNLESS(checkData() && RowVersion <= rowVersion, "Index and Data are out of sync");
 

ydb/core/tablet_flat/flat_stat_part.h

@@ -113,9 +113,8 @@ class TStatsScreenedPartIterator {
         }
 
         if (HistoricGroups) {
-            const auto& historyScheme = Part->Scheme->HistoryGroup;
-            Y_DEBUG_ABORT_UNLESS(historyScheme.ColsKeyIdx.size() == 3);
-            while (HistoricGroups[0]->IsValid() && (!HistoricGroups[0]->HasKeyCells() || HistoricGroups[0]->GetKeyCell(0).AsValue<TRowId>() < nextRowId)) {
+            Y_DEBUG_ABORT_UNLESS(Part->Scheme->HistoryGroup.ColsKeyIdx.size() == 3);
+            while (HistoricGroups[0]->IsValid() && (!HistoricGroups[0]->GetKeyCellsCount() || HistoricGroups[0]->GetKeyCell(0).AsValue<TRowId>() < nextRowId)) {
                 // eagerly include all history up to the next row id
                 if (rowCount) {
                     AddPageSize(stats.DataSize, HistoricGroups[0]->GetPageId(), TGroupId(0, true));
@@ -190,7 +189,7 @@ class TStatsScreenedPartIterator {
 
         ui32 keyIdx = 0;
         // Add columns that are present in the part
-        if (ui32 keyCellsCount = Groups[0]->HasKeyCells()) {
+        if (ui32 keyCellsCount = Groups[0]->GetKeyCellsCount()) {
             for (;keyIdx < keyCellsCount; ++keyIdx) {
                 CurrentKey.push_back(Groups[0]->GetKeyCell(keyIdx));
             }

ydb/core/tablet_flat/flat_stat_part_group_btree_index.h

@@ -132,7 +132,7 @@ class TStatsPartGroupBtreeIndexIterator : public IStatsPartGroupIterator {
         return State.back().BeginRowId;
     }
 
-    TPos HasKeyCells() const override {
+    TPos GetKeyCellsCount() const override {
         Y_ABORT_UNLESS(IsLeaf());
         return State.back().BeginKey.Count();
     }

ydb/core/tablet_flat/flat_stat_part_group_iter_iface.h

@@ -15,7 +15,7 @@ namespace NKikimr::NTable {
         virtual TPageId GetPageId() const = 0;
         virtual TRowId GetRowId() const = 0;
 
-        virtual TPos HasKeyCells() const = 0;
+        virtual TPos GetKeyCellsCount() const = 0;
         virtual TCell GetKeyCell(TPos index) const = 0;
 
         virtual ~IStatsPartGroupIterator() = default;