Skip to content

Commit c80bfea

Browse files
committed
Get right TraceId in SessionActor
1 parent ea061ca commit c80bfea

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

ydb/core/kqp/common/events/query.h

+7
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,13 @@ struct TEvQueryRequest: public NActors::TEventLocal<TEvQueryRequest, TKqpEvents:
161161
return Record.GetTraceId();
162162
}
163163

164+
NWilson::TTraceId GetWilsonTraceId() const {
165+
if (RequestCtx) {
166+
return RequestCtx->GetWilsonTraceId();
167+
}
168+
return {};
169+
}
170+
164171
const TString& GetRequestType() const {
165172
if (RequestCtx) {
166173
if (!RequestType) {

ydb/core/kqp/session_actor/kqp_query_state.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class TKqpQueryState : public TNonCopyable {
3535
TKqpQueryState(TEvKqp::TEvQueryRequest::TPtr& ev, ui64 queryId, const TString& database,
3636
const TString& cluster, TKqpDbCountersPtr dbCounters, bool longSession,
3737
const NKikimrConfig::TTableServiceConfig& tableServiceConfig, const NKikimrConfig::TQueryServiceConfig& queryServiceConfig,
38-
NWilson::TTraceId&& traceId, const TString& sessionId, TMonotonic startedAt)
38+
const TString& sessionId, TMonotonic startedAt)
3939
: QueryId(queryId)
4040
, Database(database)
4141
, Cluster(cluster)
@@ -62,7 +62,7 @@ class TKqpQueryState : public TNonCopyable {
6262
SetQueryDeadlines(tableServiceConfig, queryServiceConfig);
6363
auto action = GetAction();
6464
KqpSessionSpan = NWilson::TSpan(
65-
TWilsonKqp::KqpSession, std::move(traceId),
65+
TWilsonKqp::KqpSession, std::move(RequestEv->GetWilsonTraceId()),
6666
"Session.query." + NKikimrKqp::EQueryAction_Name(action), NWilson::EFlags::AUTO_END);
6767
if (RequestEv->GetUserRequestContext()) {
6868
UserRequestContext = RequestEv->GetUserRequestContext();

ydb/core/kqp/session_actor/kqp_session_actor.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
213213
ev->Get()->SetClientLostAction(selfId, as);
214214
QueryState = std::make_shared<TKqpQueryState>(
215215
ev, QueryId, Settings.Database, Settings.Cluster, Settings.DbCounters, Settings.LongSession,
216-
Settings.TableService, Settings.QueryService, std::move(ev->TraceId), SessionId,
217-
AppData()->MonotonicTimeProvider->Now());
216+
Settings.TableService, Settings.QueryService, SessionId, AppData()->MonotonicTimeProvider->Now());
218217
if (QueryState->UserRequestContext->TraceId.empty()) {
219218
QueryState->UserRequestContext->TraceId = UlidGen.Next().ToString();
220219
}

0 commit comments

Comments
 (0)