Skip to content

Commit c6ecfbb

Browse files
committed
[refactor]
1 parent a0fc4ef commit c6ecfbb

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

ydb/core/fq/libs/actors/clusters_from_connections.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,9 @@ void AddClustersFromConnections(
287287
FillGenericClusterConfig(
288288
common,
289289
*gatewaysConfig.MutableGeneric()->AddClusterMapping(),
290-
conn.content().setting().greenplum_cluster(),
290+
conn.content().setting().mysql_cluster(),
291291
connectionName,
292-
NYql::NConnector::NApi::EDataSourceKind::GREENPLUM,
292+
NYql::NConnector::NApi::EDataSourceKind::MYSQL,
293293
authToken,
294294
accountIdSignatures);
295295
clusters.emplace(connectionName, GenericProviderName);

ydb/core/fq/libs/common/util.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ TMaybe<TString> GetLogin(const FederatedQuery::ConnectionSetting& setting) {
166166
case FederatedQuery::ConnectionSetting::kGreenplumCluster:
167167
return setting.greenplum_cluster().login();
168168
case FederatedQuery::ConnectionSetting::kMysqlCluster:
169-
return setting.greenplum_cluster().login();
169+
return setting.mysql_cluster().login();
170170
}
171171
}
172172

ydb/core/fq/libs/control_plane_proxy/actors/query_utils.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ TString MakeCreateExternalDataSourceQuery(
255255
MDB_CLUSTER_ID={mdb_cluster_id},
256256
DATABASE_NAME={database_name},
257257
USE_TLS="{use_tls}"
258-
{schema}
259258
)",
260259
"mdb_cluster_id"_a = EncloseAndEscapeString(connectionContent.setting().mysql_cluster().database_id(), '"'),
261260
"database_name"_a = EncloseAndEscapeString(connectionContent.setting().mysql_cluster().database_name(), '"'),

ydb/core/fq/libs/control_plane_proxy/utils/utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ TString ExtractServiceAccountIdWithConnection(const T& setting) {
3535
return GetServiceAccountId(setting.greenplum_cluster().auth());
3636
}
3737
case FederatedQuery::ConnectionSetting::kMysqlCluster: {
38-
return GetServiceAccountId(setting.greenplum_cluster().auth());
38+
return GetServiceAccountId(setting.mysql_cluster().auth());
3939
}
4040
// Do not replace with default. Adding a new connection should cause a compilation error
4141
case FederatedQuery::ConnectionSetting::CONNECTION_NOT_SET:

ydb/core/fq/libs/control_plane_storage/request_validators.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,17 +85,17 @@ NYql::TIssues ValidateConnectionSetting(
8585
break;
8686
}
8787
case FederatedQuery::ConnectionSetting::kMysqlCluster: {
88-
const FederatedQuery::GreenplumCluster database = setting.greenplum_cluster();
88+
const FederatedQuery::MySQLCluster database = setting.mysql_cluster();
8989
if (!database.has_auth() || database.auth().identity_case() == FederatedQuery::IamAuth::IDENTITY_NOT_SET) {
90-
issues.AddIssue(MakeErrorIssue(TIssuesIds::BAD_REQUEST, "content.setting.greenplum_database.auth field is not specified"));
90+
issues.AddIssue(MakeErrorIssue(TIssuesIds::BAD_REQUEST, "content.setting.mysql_database.auth field is not specified"));
9191
}
9292

9393
if (database.auth().identity_case() == FederatedQuery::IamAuth::kCurrentIam && disableCurrentIam) {
9494
issues.AddIssue(MakeErrorIssue(TIssuesIds::BAD_REQUEST, "current iam authorization is disabled"));
9595
}
9696

9797
if (!database.database_id() && !database.database_name()) {
98-
issues.AddIssue(MakeErrorIssue(TIssuesIds::BAD_REQUEST, "content.setting.greenplum_database.{database_id or database_name} field is not specified"));
98+
issues.AddIssue(MakeErrorIssue(TIssuesIds::BAD_REQUEST, "content.setting.mysql_database.{database_id or database_name} field is not specified"));
9999
}
100100
break;
101101
}

0 commit comments

Comments
 (0)