Refuse empty query text

Author: Hor911

ydb/public/api/protos/draft/fq.proto

@@ -118,7 +118,7 @@ message QueryContent {
     string name = 2 [(Ydb.length).le = 1024];
     Acl acl = 3;
     Limits limits = 4;
-    string text = 5 [(Ydb.length).le = 102400]; // The text of the query itself
+    string text = 5 [(Ydb.length).range = {min: 1, max: 102400}]; // The text of the query itself
     bool automatic = 6; // Is used for queries that are created by automatic systems (robots, jdbc driver, ...)
     string description = 7 [(Ydb.length).le = 10240]; // Description of the query, there can be any text
     // Specified settings for query's executor

ydb/tests/fq/s3/test_empty.py

@@ -0,0 +1,24 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+import boto3
+import json
+
+import pytest
+
+import ydb.public.api.protos.draft.fq_pb2 as fq
+
+from ydb.tests.tools.fq_runner.fq_client import FederatedQueryException
+from ydb.tests.tools.fq_runner.kikimr_utils import yq_all
+
+
+class TestS3(object):
+
+    @yq_all
+    @pytest.mark.parametrize("client", [{"folder_id": "my_folder"}], indirect=True)
+    def test_empty(self, kikimr, client):
+        try:
+            client.create_query("simple", "", type=fq.QueryContent.QueryType.ANALYTICS).result.query_id
+        except FederatedQueryException as e:
+            assert "message: \"text\\\'s length is not in [1; 102400]" in e.args[0]
+            pass

ydb/tests/fq/s3/ya.make

@@ -23,6 +23,7 @@ TEST_SRCS(
     test_bindings.py
     test_compressions.py
     test_early_finish.py
+    test_empty.py
     test_explicit_partitioning.py
     test_format_setting.py
     test_formats.py