Fix by pr comments

Author: kardymonds

ydb/core/fq/libs/actors/database_resolver.cpp

@@ -140,14 +140,14 @@ class TResponseProcessor : public TActorBootstrapped<TResponseProcessor>
 
         try {
             HandleResponse(ev, requestIter, errorMessage, result);
-        }
-        catch (const std::exception& e) {
+        } catch (...) {
             const TString msg = TStringBuilder() << "error while response processing, params "
                 << ((requestIter != Requests.end()) ? requestIter->second.ToDebugString() : TString{"unknown"})
-                << ", details: " << e.what();
+                << ", details: " << CurrentExceptionMessage();
             LOG_E("ResponseProccessor::Handle(TEvHttpIncomingResponse): " << msg);
         }
-        LOG_D("ResponseProcessor::Handle(HttpIncomingResponse): progress: " 
+
+        LOG_T("ResponseProcessor::Handle(HttpIncomingResponse): progress: " 
               << DatabaseId2Description.size() << " of " << Requests.size() << " requests are done");
 
         if (HandledIds == Requests.size()) {
@@ -241,15 +241,7 @@ class TResponseProcessor : public TActorBootstrapped<TResponseProcessor>
         const auto& status = ev->Get()->Response->Status;
 
         if (status == "403") {
-            const auto second = requestIter->second;
-
-            auto result = TStringBuilder() << "You have no permission to resolve database id into database endpoint. ";
-            if (second.DatabaseType == EDatabaseType::ClickHouse || second.DatabaseType == EDatabaseType::PostgreSQL) {
-                auto mdbTypeStr = NYql::DatabaseTypeLowercase(second.DatabaseType);
-                result << "Please check that your service account has role "  << 
-                                       "`managed-" << mdbTypeStr << ".viewer`.";
-            }
-            return result;
+            return TStringBuilder() << "You have no permission to resolve database id into database endpoint. " + DetailedPermissionsError(requestIter->second);
         }
 
         auto errorMessage = ev->Get()->Error;
@@ -265,6 +257,17 @@ class TResponseProcessor : public TActorBootstrapped<TResponseProcessor>
         return errorMessage;
     }
 
+
+    TString DetailedPermissionsError(const TResolveParams& params) const {
+ 
+        if (params.DatabaseType == EDatabaseType::ClickHouse || params.DatabaseType == EDatabaseType::PostgreSQL) {
+                auto mdbTypeStr = NYql::DatabaseTypeLowercase(params.DatabaseType);
+                return TStringBuilder() << "Please check that your service account has role "  << 
+                                       "`managed-" << mdbTypeStr << ".viewer`.";
+        }
+        return "";
+    }
+
     const TActorId Sender;
     TCache& Cache;
     const TRequestMap Requests;

ydb/core/fq/libs/actors/ut/database_resolver_ut.cpp

@@ -297,7 +297,7 @@ Y_UNIT_TEST_SUITE(TDatabaseResolverTests) {
     Y_UNIT_TEST(ClickHouse_PermissionDenied) {
         NYql::TIssues issues{
             NYql::TIssue(
-                NoPermissionStr + "Please check that your service account has role `managed-clickhouse.viewer`."
+                TStringBuilder{} << NoPermissionStr << "Please check that your service account has role `managed-clickhouse.viewer`."
             )
         };
 
@@ -365,7 +365,7 @@ Y_UNIT_TEST_SUITE(TDatabaseResolverTests) {
     Y_UNIT_TEST(PostgreSQL_PermissionDenied) {
         NYql::TIssues issues{
             NYql::TIssue(
-                NoPermissionStr + "Please check that your service account has role `managed-postgresql.viewer`."
+                TStringBuilder{} << NoPermissionStr << "Please check that your service account has role `managed-postgresql.viewer`."
             )
         };
 

ydb/library/yql/providers/common/db_id_async_resolver/db_async_resolver.h

@@ -66,7 +66,7 @@ struct TDatabaseAuth {
     NConnector::NApi::EProtocol Protocol = NConnector::NApi::EProtocol::PROTOCOL_UNSPECIFIED;
 
     bool operator==(const TDatabaseAuth& other) const {
-        return std::tie(StructuredToken, AddBearerToToken, UseTls) == std::tie(other.StructuredToken, other.AddBearerToToken, other.UseTls);
+        return std::tie(StructuredToken, AddBearerToToken, UseTls, Protocol) == std::tie(other.StructuredToken, other.AddBearerToToken, other.UseTls, Protocol);
     }
 
     bool operator!=(const TDatabaseAuth& other) const {