Skip to content

Commit a353d1e

Browse files
committed
fix build, improve error message
1 parent e2c7642 commit a353d1e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

ydb/core/http_proxy/ut/datastreams_fixture.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,8 +547,8 @@ class THttpProxyTestMock : public NUnitTest::TBaseFixture {
547547
{"cloud_id", "cloud4"},
548548
{"database_id", "database4"}}));
549549

550-
client.CreateGroup("/Root", "Service1_id@as");
551-
client.CreateGroup("/Root", "proxy_sa@as");
550+
client.CreateUser("/Root", "Service1_id@as", "password1");
551+
client.CreateUser("/Root", "proxy_sa@as", "password2");
552552

553553
NACLib::TDiffACL acl;
554554
acl.AddAccess(NACLib::EAccessType::Allow, NACLib::GenericFull, "Service1_id@as");

ydb/core/tx/schemeshard/schemeshard__operation_modify_acl.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,15 @@ class TModifyACL: public TSubOperationBase {
5656
for (const NACLibProto::TDiffACE& diffACE : diffACL.GetDiffACE()) {
5757
if (static_cast<NACLib::EDiffType>(diffACE.GetDiffType()) == NACLib::EDiffType::Add) {
5858
if (!context.SS->LoginProvider.Sids.contains(diffACE.GetACE().GetSID())) {
59-
result->SetError(NKikimrScheme::StatusPreconditionFailed, "Sid not found");
59+
result->SetError(NKikimrScheme::StatusPreconditionFailed, "SID not found");
6060
return result;
6161
}
6262
} // remove diff type is allowed in any case
6363
}
6464
}
6565
if (owner) {
6666
if (!context.SS->LoginProvider.Sids.contains(owner)) {
67-
result->SetError(NKikimrScheme::StatusPreconditionFailed, "Sid not found");
67+
result->SetError(NKikimrScheme::StatusPreconditionFailed, "Owner SID not found");
6868
return result;
6969
}
7070
}

ydb/core/tx/schemeshard/ut_login/ut_login.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,12 +283,12 @@ Y_UNIT_TEST_SUITE(TSchemeShardLoginTest) {
283283
NACLib::TDiffACL diffACL;
284284
diffACL.AddAccess(NACLib::EAccessType::Allow, NACLib::GenericUse, "user1");
285285
AsyncModifyACL(runtime, ++txId, "/MyRoot", "Dir1", diffACL.SerializeAsString(), "");
286-
TestModificationResults(runtime, txId, {{NKikimrScheme::StatusPreconditionFailed, "Sid not found"}});
286+
TestModificationResults(runtime, txId, {{NKikimrScheme::StatusPreconditionFailed, "SID not found"}});
287287
}
288288

289289
{
290290
AsyncModifyACL(runtime, ++txId, "/MyRoot", "Dir1", NACLib::TDiffACL{}.SerializeAsString(), "user1");
291-
TestModificationResults(runtime, txId, {{NKikimrScheme::StatusPreconditionFailed, "Sid not found"}});
291+
TestModificationResults(runtime, txId, {{NKikimrScheme::StatusPreconditionFailed, "Owner SID not found"}});
292292
}
293293

294294
CreateAlterLoginCreateUser(runtime, ++txId, "/MyRoot", "user1", "password1");

0 commit comments

Comments
 (0)