Skip to content

Commit a1f5cb2

Browse files
authored
Explicit ydb/tools/cfg/bin/ydb_configure path (#12213)
1 parent 7cae2d2 commit a1f5cb2

File tree

6 files changed

+15
-6
lines changed

6 files changed

+15
-6
lines changed

ydb/tests/library/harness/kikimr_cluster.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class ExternalKiKiMRCluster(KiKiMRClusterInterface):
3333
def __init__(
3434
self,
3535
config_path,
36+
kikimr_configure_binary_path,
3637
kikimr_path,
3738
kikimr_next_path=None,
3839
ssh_username=None,
@@ -41,6 +42,7 @@ def __init__(
4142
self.__config_path = config_path
4243
with open(config_path, 'r') as r:
4344
self.__yaml_config = yaml.safe_load(r.read())
45+
self.__kikimr_configure_binary_path = kikimr_configure_binary_path
4446
self.__hosts = [host['name'] for host in self.__yaml_config.get('hosts')]
4547
self._slots = None
4648
self.__kikimr_path = kikimr_path
@@ -188,6 +190,7 @@ def _prepare_cluster(self):
188190
def nodes(self):
189191
return {
190192
node_id: KikimrExternalNode(
193+
kikimr_configure_binary_path=self.__kikimr_configure_binary_path,
191194
kikimr_path=self.__kikimr_path,
192195
kikimr_next_path=self.__kikimr_next_path,
193196
node_id=node_id,
@@ -218,6 +221,7 @@ def slots(self):
218221
ic_port = start + 3
219222

220223
self._slots[slot_idx] = KikimrExternalNode(
224+
kikimr_configure_binary_path=self.__kikimr_configure_binary_path,
221225
kikimr_path=self.__kikimr_path,
222226
kikimr_next_path=self.__kikimr_next_path,
223227
node_id=node_id,

ydb/tests/library/harness/kikimr_runner.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
from ydb.tests.library.common.wait_for import wait_for
1414
from . import daemon
15-
from . import param_constants
1615
from . import kikimr_config
1716
from . import kikimr_node_interface
1817
from . import kikimr_cluster_interface
@@ -571,6 +570,7 @@ class KikimrExternalNode(daemon.ExternalNodeDaemon, kikimr_node_interface.NodeIn
571570

572571
def __init__(
573572
self,
573+
kikimr_configure_binary_path,
574574
kikimr_path,
575575
kikimr_next_path,
576576
node_id,
@@ -600,6 +600,7 @@ def __init__(
600600

601601
self._can_update = None
602602
self.current_version_idx = 0
603+
self.__kikimr_configure_binary_path = kikimr_configure_binary_path
603604
self.versions = [
604605
self.kikimr_binary_deploy_path + "_last",
605606
self.kikimr_binary_deploy_path + "_next",
@@ -733,7 +734,7 @@ def switch_version(self):
733734

734735
def prepare_artifacts(self, cluster_yml):
735736
self.copy_file_or_dir(
736-
param_constants.kikimr_configure_binary_path(), self.kikimr_configure_binary_deploy_path)
737+
self.__kikimr_configure_binary_path, self.kikimr_configure_binary_deploy_path)
737738

738739
for version, local_driver in zip(self.versions, self.local_drivers_path):
739740
self.ssh_command("sudo rm -rf %s" % version)

ydb/tests/library/harness/param_constants.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,3 @@ def kikimr_driver_path():
88
return yatest.common.binary_path(os.getenv("YDB_DRIVER_BINARY"))
99

1010
return yatest.common.binary_path("kikimr/driver/kikimr")
11-
12-
13-
def kikimr_configure_binary_path():
14-
return yatest.common.binary_path("ydb/tools/cfg/bin/ydb_configure")

ydb/tests/library/harness/ydbd_slice.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ def nodes(self):
107107
# TODO: use from config?
108108
return {
109109
node_id: KikimrExternalNode(
110+
kikimr_configure_binary_path=self.__kikimr_configure_binary_path,
110111
kikimr_path=self.__kikimr_path,
111112
kikimr_next_path=None,
112113
node_id=node_id,

ydb/tests/stability/ydb/test_stability.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ def get_slice_name():
3636
return yatest.common.get_param("kikimr.ci.cluster_name", None)
3737

3838

39+
def get_configure_binary_path():
40+
return yatest.common.binary_path("ydb/tools/cfg/bin/ydb_configure")
41+
42+
3943
def next_version_kikimr_driver_path():
4044
return yatest.common.get_param("kikimr.ci.kikimr_driver_next", None)
4145

@@ -64,6 +68,7 @@ def setup_class(cls):
6468

6569
logger.info('setup_class started for slice = {}'.format(cls.slice_name))
6670
cls.kikimr_cluster = ExternalKiKiMRCluster(
71+
kikimr_configure_binary_path=get_configure_binary_path(),
6772
config_path=get_slice_directory(),
6873
kikimr_path=kikimr_driver_path(),
6974
kikimr_next_path=next_version_kikimr_driver_path(),
@@ -187,6 +192,7 @@ def test_liveness_and_safety(self):
187192
logger.info('slice = {}'.format(slice_name))
188193
assert slice_name is not None
189194
kikimr_cluster = ExternalKiKiMRCluster(
195+
kikimr_configure_binary_path=get_configure_binary_path(),
190196
config_path=get_slice_directory(),
191197
kikimr_path=kikimr_driver_path(),
192198
kikimr_next_path=next_version_kikimr_driver_path(),

ydb/tests/tools/nemesis/driver/__main__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ def nemesis_logic(arguments):
131131
nemesis = catalog.nemesis_factory(
132132
ExternalKiKiMRCluster(
133133
arguments.ydb_cluster_template,
134+
kikimr_configure_binary_path=None,
134135
kikimr_path=arguments.ydb_binary_path,
135136
ssh_username=ssh_username,
136137
),

0 commit comments

Comments
 (0)