Fix of INSERT with no columns specified + removed redundant patches + updated tests

Author: marsaly79

ydb/library/yql/providers/common/provider/yql_provider.cpp

@@ -1475,7 +1475,7 @@ bool NeedToRenamePgSelectColumns(const TCoPgSelect& pgSelect) {
 bool RenamePgSelectColumns(
     const TCoPgSelect& node,
     TExprNode::TPtr& output,
-    TMaybe<TVector<TString>> tableColumnOrder,
+    const TMaybe<TColumnOrder>& tableColumnOrder,
     TExprContext& ctx,
     TTypeAnnotationContext& types) {
 

ydb/library/yql/providers/common/provider/yql_provider.h

@@ -209,7 +209,7 @@ bool NeedToRenamePgSelectColumns(const NNodes::TCoPgSelect& pgSelect);
 bool RenamePgSelectColumns(
     const NNodes::TCoPgSelect& node,
     TExprNode::TPtr& output,
-    TMaybe<TVector<TString>> tableColumnOrder,
+    const TMaybe<TColumnOrder>& tableColumnOrder,
     TExprContext& ctx,
     TTypeAnnotationContext& types);
 } // namespace NCommon

ydb/library/yql/providers/yt/provider/yql_yt_datasink_type_ann.cpp

@@ -445,9 +445,8 @@ class TYtDataSinkTypeAnnotationTransformer : public TVisitorTransformerBase {
             }
         }
 
-        TMaybe<TColumnOrder> contentColumnOrder;
+        const TMaybe<TColumnOrder> contentColumnOrder = outTableInfo.RowSpec->GetColumnOrder();
         if (content) {
-            contentColumnOrder = State_->Types->LookupColumnOrder(*content);
             if (content->IsCallable("AssumeColumnOrder")) {
                 YQL_ENSURE(contentColumnOrder);
                 YQL_CLOG(INFO, ProviderYt) << "Dropping top level " << content->Content() << " from WriteTable input";

ydb/library/yql/tests/postgresql/cases/aggregates.out

@@ -270,6 +270,13 @@ SELECT covar_pop(1::float8,'nan'::float8), covar_samp(3::float8,'nan'::float8);
 -- test accum and combine functions directly
 CREATE TABLE regr_test (x float8, y float8);
 INSERT INTO regr_test VALUES (10,150),(20,250),(30,350),(80,540),(100,200);
+SELECT count(*), sum(x), regr_sxx(y,x), sum(y),regr_syy(y,x), regr_sxy(y,x)
+FROM regr_test;
+ count | sum | regr_sxx | sum  | regr_syy | regr_sxy 
+-------+-----+----------+------+----------+----------
+     5 | 240 |     6280 | 1490 |    95080 |     8680
+(1 row)
+
 SELECT float8_accum('{4,140,2900}'::float8[], 100);
  float8_accum 
 --------------

ydb/library/yql/tests/postgresql/cases/aggregates.sql

@@ -65,6 +65,8 @@ SELECT covar_pop(1::float8,'nan'::float8), covar_samp(3::float8,'nan'::float8);
 -- test accum and combine functions directly
 CREATE TABLE regr_test (x float8, y float8);
 INSERT INTO regr_test VALUES (10,150),(20,250),(30,350),(80,540),(100,200);
+SELECT count(*), sum(x), regr_sxx(y,x), sum(y),regr_syy(y,x), regr_sxy(y,x)
+FROM regr_test;
 SELECT float8_accum('{4,140,2900}'::float8[], 100);
 SELECT float8_regr_accum('{4,140,2900,1290,83075,15050}'::float8[], 200, 100);
 SELECT float8_combine('{3,60,200}'::float8[], '{0,0,0}'::float8[]);