Skip to content

Commit 94ddfa3

Browse files
StekPerepolnenStekPerepolnen
committed
impersonate
1 parent 34dcd14 commit 94ddfa3

15 files changed

+494
-133
lines changed

‎ydb/mvp/oidc_proxy/mvp.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ void TMVP::TryGetOidcOptionsFromConfig(const YAML::Node& config) {
233233
OpenIdConnectSettings.AuthUrlPath = oidc["auth_url_path"].as<std::string>(OpenIdConnectSettings.DEFAULT_AUTH_URL_PATH);
234234
OpenIdConnectSettings.TokenUrlPath = oidc["token_url_path"].as<std::string>(OpenIdConnectSettings.DEFAULT_TOKEN_URL_PATH);
235235
OpenIdConnectSettings.ExchangeUrlPath = oidc["exchange_url_path"].as<std::string>(OpenIdConnectSettings.DEFAULT_EXCHANGE_URL_PATH);
236+
OpenIdConnectSettings.ImpersonateUrlPath = oidc["impersonate_url_path"].as<std::string>(OpenIdConnectSettings.DEFAULT_IMPERSONATE_URL_PATH);
236237
Cout << "Started processing allowed_proxy_hosts..." << Endl;
237238
for (const std::string& host : oidc["allowed_proxy_hosts"].as<std::vector<std::string>>()) {
238239
Cout << host << " added to allowed_proxy_hosts" << Endl;

‎ydb/mvp/oidc_proxy/oidc_client.cpp

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#include "oidc_client.h"
22
#include "oidc_protected_page_handler.h"
33
#include "oidc_session_create_handler.h"
4+
#include "oidc_impersonate_start_page_nebius.h"
5+
#include "oidc_impersonate_stop_page_nebius.h"
46

57
namespace NMVP {
68
namespace NOIDC {
@@ -14,17 +16,19 @@ void InitOIDC(NActors::TActorSystem& actorSystem,
1416
)
1517
);
1618

17-
actorSystem.Send(httpProxyId, new NHttp::TEvHttpProxy::TEvRegisterHandler(
18-
"/impersonate/start",
19-
actorSystem.Register(new THandlerImpersonateStart(httpProxyId, settings))
20-
)
21-
);
19+
if (settings.AccessServiceType == NMvp::nebius_v1) {
20+
actorSystem.Send(httpProxyId, new NHttp::TEvHttpProxy::TEvRegisterHandler(
21+
"/impersonate/start",
22+
actorSystem.Register(new TImpersonateStartPageHandler(httpProxyId, settings))
23+
)
24+
);
2225

23-
actorSystem.Send(httpProxyId, new NHttp::TEvHttpProxy::TEvRegisterHandler(
24-
"/impersonate/stop",
25-
actorSystem.Register(new THandlerImpersonateStop(httpProxyId, settings))
26-
)
27-
);
26+
actorSystem.Send(httpProxyId, new NHttp::TEvHttpProxy::TEvRegisterHandler(
27+
"/impersonate/stop",
28+
actorSystem.Register(new TImpersonateStopPageHandler(httpProxyId, settings))
29+
)
30+
);
31+
}
2832

2933
actorSystem.Send(httpProxyId, new NHttp::TEvHttpProxy::TEvRegisterHandler(
3034
"/",

‎ydb/mvp/oidc_proxy/oidc_impersonate_start_page_nebius.cpp

Lines changed: 72 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,74 @@
1-
#include <library/cpp/json/json_reader.h>
21
#include <library/cpp/string_utils/base64/base64.h>
32
#include <ydb/library/actors/http/http.h>
3+
#include <ydb/library/security/util.h>
44
#include <ydb/mvp/core/mvp_log.h>
5+
#include <ydb/mvp/core/mvp_tokens.h>
56
#include "openid_connect.h"
67
#include "oidc_session_create.h"
7-
#include "oidc_settings.h"
8+
#include "oidc_impersonate_start_page_nebius.h"
89

910
namespace NMVP {
1011
namespace NOIDC {
1112

1213
THandlerImpersonateStart::THandlerImpersonateStart(const NActors::TActorId& sender,
13-
const NHttp::THttpIncomingRequestPtr& request,
14-
const NActors::TActorId& httpProxyId,
15-
const TOpenIdConnectSettings& settings)
14+
const NHttp::THttpIncomingRequestPtr& request,
15+
const NActors::TActorId& httpProxyId,
16+
const TOpenIdConnectSettings& settings)
1617
: Sender(sender)
1718
, Request(request)
1819
, HttpProxyId(httpProxyId)
1920
, Settings(settings)
2021
{}
2122

23+
TString THandlerImpersonateStart::DecodeToken(const TStringBuf& cookie, const NActors::TActorContext& ctx) {
24+
TString token;
25+
try {
26+
Base64StrictDecode(cookie, token);
27+
} catch (std::exception& e) {
28+
LOG_DEBUG_S(ctx, EService::MVP, "Base64Decode " << cookie << " cookie: " << e.what());
29+
token.clear();
30+
}
31+
return token;
32+
}
33+
2234
void THandlerImpersonateStart::Bootstrap(const NActors::TActorContext& ctx) {
35+
LOG_DEBUG_S(ctx, EService::MVP, "Start impersonation process");
2336
NHttp::TUrlParameters urlParameters(Request->URL);
24-
TString serviceAccountId = urlParameters["service_accound_id"];
37+
TString serviceAccountId = urlParameters["service_account_id"];
2538

2639
NHttp::THeaders headers(Request->Headers);
27-
LOG_DEBUG_S(ctx, EService::MVP, "Start impersonation process");
2840
NHttp::TCookies cookies(headers.Get("Cookie"));
29-
TString sessionToken = DecodeToken(cookies, CreateNameSessionCookie(Settings.ClientId));
3041

31-
if (sessionToken && serviceAccountId) {
32-
RequestImpersonatedToken(sessionToken, serviceAccountId, ctx);
33-
} else {
42+
TString sessionCookieName = CreateNameSessionCookie(Settings.ClientId);
43+
TStringBuf sessionCookieValue = cookies.Get(sessionCookieName);
44+
if (!sessionCookieValue.Empty()) {
45+
LOG_DEBUG_S(ctx, EService::MVP, "Using session cookie (" << sessionCookieName << ": " << NKikimr::MaskTicket(sessionCookieValue) << ")");
46+
}
47+
48+
TString sessionToken = DecodeToken(sessionCookieValue, ctx);
49+
50+
TString jsonError;
51+
if (sessionToken.empty()) {
52+
jsonError = "Wrong impersonate parameter: session cookie not found";
53+
} else if (serviceAccountId.empty()) {
54+
jsonError = "Wrong impersonate parameter: account_id not found";
55+
}
56+
57+
if (jsonError) {
3458
NHttp::THeadersBuilder responseHeaders;
3559
responseHeaders.Set("Content-Type", "text/plain");
36-
httpResponse = Request->CreateResponse("400", "Bad Request", responseHeaders, event->Get()->Error);
60+
SetCORS(Request, &responseHeaders);
61+
NHttp::THttpOutgoingResponsePtr httpResponse = Request->CreateResponse("400", "Bad Request", responseHeaders, jsonError);
62+
ctx.Send(Sender, new NHttp::TEvHttpProxy::TEvHttpOutgoingResponse(httpResponse));
63+
Die(ctx);
64+
} else {
65+
RequestImpersonatedToken(sessionToken, serviceAccountId, ctx);
3766
}
3867
}
3968

40-
void THandlerImpersonateStart::RequestImpersonatedToken(const TString sessionToken, const TString serviceAccountId, const NActors::TActorContext& ctx) {
69+
void THandlerImpersonateStart::RequestImpersonatedToken(const TString& sessionToken, const TString& serviceAccountId, const NActors::TActorContext& ctx) {
4170
LOG_DEBUG_S(ctx, EService::MVP, "Request impersonated token");
42-
NHttp::THttpOutgoingRequestPtr httpRequest = NHttp::THttpOutgoingRequest::CreateRequestPost(Settings.GetExchangeEndpointURL());
71+
NHttp::THttpOutgoingRequestPtr httpRequest = NHttp::THttpOutgoingRequest::CreateRequestPost(Settings.GetImpersonateEndpointURL());
4372
httpRequest->Set<&NHttp::THttpRequest::ContentType>("application/x-www-form-urlencoded");
4473

4574
TMvpTokenator* tokenator = MVPAppData()->Tokenator;
@@ -48,16 +77,28 @@ void THandlerImpersonateStart::RequestImpersonatedToken(const TString sessionTok
4877
token = tokenator->GetToken(Settings.SessionServiceTokenName);
4978
}
5079
httpRequest->Set("Authorization", token); // Bearer included
80+
5181
TStringBuilder body;
52-
body << "grant_type=urn:ietf:params:oauth:grant-type:token-exchange"
53-
<< "&requested_token_type=urn:ietf:params:oauth:token-type:access_token"
54-
<< "&subject_token_type=urn:ietf:params:oauth:token-type:session_token"
55-
<< "&subject_token=" << sessionToken;
82+
body << "session=" << sessionToken
83+
<< "&service_account_id=" << serviceAccountId;
5684
httpRequest->Set<&NHttp::THttpRequest::Body>(body);
5785

5886
ctx.Send(HttpProxyId, new NHttp::TEvHttpProxy::TEvHttpOutgoingRequest(httpRequest));
87+
Become(&THandlerImpersonateStart::StateWork);
88+
}
5989

60-
Become(&THandlerSessionServiceCheckNebius::StateExchange);
90+
void THandlerImpersonateStart::ProcessImpersonatedToken(const TString& impersonatedToken, const NActors::TActorContext& ctx) {
91+
TString impersonatedCookieName = CreateNameImpersonatedCookie(Settings.ClientId);
92+
TString impersonatedCookieValue = Base64Encode(impersonatedToken);
93+
LOG_DEBUG_S(ctx, EService::MVP, "Set impersonated cookie: (" << impersonatedCookieName << ": " << NKikimr::MaskTicket(impersonatedCookieValue) << ")");
94+
95+
NHttp::THeadersBuilder responseHeaders;
96+
responseHeaders.Set("Set-Cookie", CreateSecureCookie(impersonatedCookieName, impersonatedCookieValue));
97+
SetCORS(Request, &responseHeaders);
98+
NHttp::THttpOutgoingResponsePtr httpResponse;
99+
httpResponse = Request->CreateResponse("200", "OK", responseHeaders);
100+
ctx.Send(Sender, new NHttp::TEvHttpProxy::TEvHttpOutgoingResponse(httpResponse));
101+
Die(ctx);
61102
}
62103

63104
void THandlerImpersonateStart::Handle(NHttp::TEvHttpProxy::TEvHttpIncomingResponse::TPtr event, const NActors::TActorContext& ctx) {
@@ -70,13 +111,13 @@ void THandlerImpersonateStart::Handle(NHttp::TEvHttpProxy::TEvHttpIncomingRespon
70111
NJson::TJsonValue jsonValue;
71112
NJson::TJsonReaderConfig jsonConfig;
72113
if (NJson::ReadJsonTree(response->Body, &jsonConfig, &jsonValue)) {
73-
const NJson::TJsonValue* jsonAccessToken;
74-
if (jsonValue.GetValuePointer("access_token", &jsonAccessToken)) {
75-
TString sessionToken = jsonAccessToken->GetStringRobust();
76-
ProcessSessionToken(sessionToken, ctx);
114+
const NJson::TJsonValue* jsonImpersonatedToken;
115+
if (jsonValue.GetValuePointer("impersonation", &jsonImpersonatedToken)) {
116+
TString impersonatedToken = jsonImpersonatedToken->GetStringRobust();
117+
ProcessImpersonatedToken(impersonatedToken, ctx);
77118
return;
78119
} else {
79-
jsonError = "Wrong OIDC provider response: access_token not found";
120+
jsonError = "Wrong OIDC provider response: impersonated token not found";
80121
}
81122
} else {
82123
jsonError = "Wrong OIDC response";
@@ -98,51 +139,14 @@ void THandlerImpersonateStart::Handle(NHttp::TEvHttpProxy::TEvHttpIncomingRespon
98139
Die(ctx);
99140
}
100141

101-
TString THandlerImpersonateStart::ChangeSameSiteFieldInSessionCookie(const TString& cookie) {
102-
const static TStringBuf SameSiteParameter {"SameSite=Lax"};
103-
size_t n = cookie.find(SameSiteParameter);
104-
if (n == TString::npos) {
105-
return cookie;
106-
}
107-
TStringBuilder cookieBuilder;
108-
cookieBuilder << cookie.substr(0, n);
109-
cookieBuilder << "SameSite=None";
110-
cookieBuilder << cookie.substr(n + SameSiteParameter.size());
111-
return cookieBuilder;
112-
}
113-
114-
void THandlerImpersonateStart::RetryRequestToProtectedResourceAndDie(const NActors::TActorContext& ctx) {
115-
NHttp::THeadersBuilder responseHeaders;
116-
RetryRequestToProtectedResourceAndDie(&responseHeaders, ctx);
117-
}
118-
119-
void THandlerImpersonateStart::RetryRequestToProtectedResourceAndDie(NHttp::THeadersBuilder* responseHeaders, const NActors::TActorContext& ctx) {
120-
SetCORS(Request, responseHeaders);
121-
responseHeaders->Set("Location", Context.GetRequestedAddress());
122-
ctx.Send(Sender, new NHttp::TEvHttpProxy::TEvHttpOutgoingResponse(Request->CreateResponse("302", "Found", *responseHeaders)));
123-
Die(ctx);
124-
}
142+
TImpersonateStartPageHandler::TImpersonateStartPageHandler(const NActors::TActorId& httpProxyId, const TOpenIdConnectSettings& settings)
143+
: TBase(&TImpersonateStartPageHandler::StateWork)
144+
, HttpProxyId(httpProxyId)
145+
, Settings(settings)
146+
{}
125147

126-
void THandlerImpersonateStart::SendUnknownErrorResponseAndDie(const NActors::TActorContext& ctx) {
127-
NHttp::THeadersBuilder responseHeaders;
128-
responseHeaders.Set("Content-Type", "text/html");
129-
SetCORS(Request, &responseHeaders);
130-
const static TStringBuf BAD_REQUEST_HTML_PAGE = "<html>"
131-
"<head>"
132-
"<title>"
133-
"400 Bad Request"
134-
"</title>"
135-
"</head>"
136-
"<body bgcolor=\"white\">"
137-
"<center>"
138-
"<h1>"
139-
"Unknown error has occurred. Please open the page again"
140-
"</h1>"
141-
"</center>"
142-
"</body>"
143-
"</html>";
144-
ctx.Send(Sender, new NHttp::TEvHttpProxy::TEvHttpOutgoingResponse(Request->CreateResponse("400", "Bad Request", responseHeaders, BAD_REQUEST_HTML_PAGE)));
145-
Die(ctx);
148+
void TImpersonateStartPageHandler::Handle(NHttp::TEvHttpProxy::TEvHttpIncomingRequest::TPtr event, const NActors::TActorContext& ctx) {
149+
ctx.Register(new THandlerImpersonateStart(event->Sender, event->Get()->Request, HttpProxyId, Settings));
146150
}
147151

148152
} // NOIDC

‎ydb/mvp/oidc_proxy/oidc_impersonate_start_page_nebius.h

Lines changed: 27 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
#pragma once
22

3-
#include <util/generic/string.h>
4-
#include <util/generic/strbuf.h>
5-
#include <ydb/library/actors/core/actor_bootstrapped.h>
6-
#include <ydb/library/actors/core/actorid.h>
7-
#include <ydb/library/actors/http/http.h>
8-
#include <ydb/library/actors/http/http_proxy.h>
93
#include "oidc_settings.h"
104
#include "context.h"
115

@@ -24,24 +18,39 @@ class THandlerImpersonateStart : public NActors::TActorBootstrapped<THandlerImpe
2418
TContext Context;
2519

2620
public:
21+
TString DecodeToken(const TStringBuf& cookie, const NActors::TActorContext& ctx);
2722
THandlerImpersonateStart(const NActors::TActorId& sender,
28-
const NHttp::THttpIncomingRequestPtr& request,
29-
const NActors::TActorId& httpProxyId,
30-
const TOpenIdConnectSettings& settings);
31-
32-
virtual void RequestSessionToken(const TString&, const NActors::TActorContext&) = 0;
33-
virtual void ProcessSessionToken(const TString& accessToken, const NActors::TActorContext&) = 0;
23+
const NHttp::THttpIncomingRequestPtr& request,
24+
const NActors::TActorId& httpProxyId,
25+
const TOpenIdConnectSettings& settings);
26+
void RequestImpersonatedToken(const TString&, const TString&, const NActors::TActorContext&);
27+
void ProcessImpersonatedToken(const TString& impersonatedToken, const NActors::TActorContext& ctx);
3428

3529
void Bootstrap(const NActors::TActorContext& ctx);
3630
void Handle(NHttp::TEvHttpProxy::TEvHttpIncomingResponse::TPtr event, const NActors::TActorContext& ctx);
3731

38-
protected:
39-
TString ChangeSameSiteFieldInSessionCookie(const TString& cookie);
40-
void RetryRequestToProtectedResourceAndDie(const NActors::TActorContext& ctx);
41-
void RetryRequestToProtectedResourceAndDie(NHttp::THeadersBuilder* responseHeaders, const NActors::TActorContext& ctx);
32+
STFUNC(StateWork) {
33+
switch (ev->GetTypeRewrite()) {
34+
HFunc(NHttp::TEvHttpProxy::TEvHttpIncomingResponse, Handle);
35+
}
36+
}
37+
};
4238

43-
private:
44-
void SendUnknownErrorResponseAndDie(const NActors::TActorContext& ctx);
39+
class TImpersonateStartPageHandler : public NActors::TActor<TImpersonateStartPageHandler> {
40+
using TBase = NActors::TActor<TImpersonateStartPageHandler>;
41+
42+
const NActors::TActorId HttpProxyId;
43+
const TOpenIdConnectSettings Settings;
44+
45+
public:
46+
TImpersonateStartPageHandler(const NActors::TActorId& httpProxyId, const TOpenIdConnectSettings& settings);
47+
void Handle(NHttp::TEvHttpProxy::TEvHttpIncomingRequest::TPtr event, const NActors::TActorContext& ctx);
48+
49+
STFUNC(StateWork) {
50+
switch (ev->GetTypeRewrite()) {
51+
HFunc(NHttp::TEvHttpProxy::TEvHttpIncomingRequest, Handle);
52+
}
53+
}
4554
};
4655

4756
} // NOIDC

‎ydb/mvp/oidc_proxy/oidc_impersonate_stop_page_nebius.cpp

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,43 @@
1-
#include <library/cpp/json/json_reader.h>
2-
#include <library/cpp/string_utils/base64/base64.h>
3-
#include <ydb/library/actors/http/http.h>
4-
#include <ydb/mvp/core/mvp_log.h>
51
#include "openid_connect.h"
62
#include "oidc_session_create.h"
7-
#include "oidc_settings.h"
3+
#include "oidc_impersonate_stop_page_nebius.h"
84

95
namespace NMVP {
106
namespace NOIDC {
117

12-
THandlerImpersonateStop::THandlerSessionCreate(const NActors::TActorId& sender,
13-
const NHttp::THttpIncomingRequestPtr& request,
14-
const NActors::TActorId& httpProxyId,
15-
const TOpenIdConnectSettings& settings)
8+
THandlerImpersonateStop::THandlerImpersonateStop(const NActors::TActorId& sender,
9+
const NHttp::THttpIncomingRequestPtr& request,
10+
const NActors::TActorId& httpProxyId,
11+
const TOpenIdConnectSettings& settings)
1612
: Sender(sender)
1713
, Request(request)
1814
, HttpProxyId(httpProxyId)
1915
, Settings(settings)
2016
{}
2117

2218
void THandlerImpersonateStop::Bootstrap(const NActors::TActorContext& ctx) {
23-
NHttp::THeadersBuilder responseHeaders;responseHeaders
19+
TString impersonatedCookieName = CreateNameImpersonatedCookie(Settings.ClientId);
20+
LOG_DEBUG_S(ctx, EService::MVP, "Clear impersonated cookie: (" << impersonatedCookieName << ")");
21+
22+
NHttp::THeadersBuilder responseHeaders;
23+
responseHeaders.Set("Set-Cookie", ClearSecureCookie(impersonatedCookieName));
2424
SetCORS(Request, &responseHeaders);
25-
responseHeaders.Set("Set-Cookie", CreateSecureCookie(Settings.ClientId, sessionToken));
2625

2726
NHttp::THttpOutgoingResponsePtr httpResponse;
2827
httpResponse = Request->CreateResponse("200", "OK", responseHeaders);
2928
ctx.Send(Sender, new NHttp::TEvHttpProxy::TEvHttpOutgoingResponse(httpResponse));
3029
Die(ctx);
3130
}
3231

32+
TImpersonateStopPageHandler::TImpersonateStopPageHandler(const NActors::TActorId& httpProxyId, const TOpenIdConnectSettings& settings)
33+
: TBase(&TImpersonateStopPageHandler::StateWork)
34+
, HttpProxyId(httpProxyId)
35+
, Settings(settings)
36+
{}
37+
38+
void TImpersonateStopPageHandler::Handle(NHttp::TEvHttpProxy::TEvHttpIncomingRequest::TPtr event, const NActors::TActorContext& ctx) {
39+
ctx.Register(new THandlerImpersonateStop(event->Sender, event->Get()->Request, HttpProxyId, Settings));
40+
}
41+
3342
} // NOIDC
3443
} // NMVP

0 commit comments

Comments
 (0)