Skip to content

Commit 82d69fe

Browse files
authored
Some minor KeyValue tablet improvements (merge from main #1900) (#4644)
1 parent 6e76cc8 commit 82d69fe

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

ydb/core/keyvalue/channel_balancer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ namespace NKikimr::NKeyValue {
114114
const size_t index = (LatencyQueue.size() - 1) * 99 / 100;
115115
const TDuration perc = latencies[index];
116116
weight = MeanExpectedLatency.GetValue() * weight / Max(perc, TDuration::MilliSeconds(1)).GetValue();
117-
Y_DEBUG_ABORT_UNLESS(weight);
117+
//Y_DEBUG_ABORT_UNLESS(weight);
118118
if (!weight) {
119119
weight = 1;
120120
}

ydb/core/keyvalue/keyvalue_state.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -634,6 +634,9 @@ void TKeyValueState::InitExecute(ui64 tabletId, TActorId keyValueActorId, ui32 e
634634
}
635635

636636
THelpers::DbEraseCollect(db, ctx);
637+
if (IsEmptyDbStart) {
638+
THelpers::DbUpdateState(StoredState, db, ctx);
639+
}
637640

638641
// corner case, if no CollectGarbage events were sent
639642
if (InitialCollectsSent == 0) {

ydb/core/keyvalue/keyvalue_storage_request.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,11 @@ class TKeyValueStorageRequest : public TActorBootstrapped<TKeyValueStorageReques
296296
IntermediateResults->Stat.GroupReadIops[std::make_pair(response.Id.Channel(), groupId)] += 1; // FIXME: count distinct blobs?
297297
read.Value.Write(readItem.ValueOffset, std::move(response.Buffer));
298298
} else {
299+
Y_VERIFY_DEBUG_S(response.Status != NKikimrProto::NODATA, "NODATA received for TEvGet"
300+
<< " TabletId# " << TabletInfo->TabletID
301+
<< " Id# " << response.Id
302+
<< " Key# " << read.Key);
303+
299304
TStringStream err;
300305
if (read.Message.size()) {
301306
err << read.Message << Endl;

0 commit comments

Comments
 (0)