Skip to content

Commit 81935d7

Browse files
authored
task_runner_local: avoid formatting log messages when logging disabled (#10130)
1 parent 6595ec0 commit 81935d7

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ class TLocalFactory: public IProxyFactory {
225225
}
226226

227227
TIntrusivePtr<NDq::IDqTaskRunner> Get(std::shared_ptr<NKikimr::NMiniKQL::TScopedAlloc> alloc, const TDqTaskSettings& task, NDqProto::EDqStatsMode statsMode, const TString& traceId) override {
228-
Y_UNUSED(traceId);
229228
NDq::TDqTaskRunnerSettings settings;
230229
settings.TerminateOnError = TerminateOnError;
231230
settings.StatsMode = statsMode;
@@ -261,11 +260,15 @@ class TLocalFactory: public IProxyFactory {
261260
settings.ReadRanges.push_back(readRange);
262261
}
263262
auto ctx = ExecutionContext;
263+
TLogFunc logger;
264+
if (YQL_CLOG_ACTIVE(DEBUG, ProviderDq)) {
265+
logger = [taskId = ToString(task.GetId()), traceId = traceId](const TString& message) {
266+
YQL_LOG_CTX_ROOT_SESSION_SCOPE(traceId, taskId);
267+
YQL_CLOG(DEBUG, ProviderDq) << message;
268+
};
269+
}
264270
ctx.FuncProvider = TaskTransformFactory(settings.TaskParams, ctx.FuncRegistry);
265-
return MakeDqTaskRunner(alloc, ctx, settings, [taskId = task.GetId(), traceId = traceId](const TString& message) {
266-
YQL_LOG_CTX_ROOT_SESSION_SCOPE(traceId, ToString(taskId));
267-
YQL_CLOG(DEBUG, ProviderDq) << message;
268-
});
271+
return MakeDqTaskRunner(alloc, ctx, settings, logger);
269272
}
270273

271274
private:

0 commit comments

Comments
 (0)